Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-71997

Warning descriptions are barely readable in dark mode

      I am generating plain JSON-based reports without corresponding source files. When rendering the result table, expanding the row in the table to see the actual error message presents me with white text on white background with having dark mode enabled. This complicates reading the message itself, as only hovering over it makes it slightly visible (the alternative is to select the whole message for copying, but this is no usable approach as well).

          [JENKINS-71997] Warning descriptions are barely readable in dark mode

          Ulli Hafner added a comment -

          This requires changes in the data-tables plugin that is responsible to render the details (child) row.

          Ulli Hafner added a comment - This requires changes in the data-tables plugin that is responsible to render the details (child) row.

          Udit added a comment -

          Hello drulli. I am fairly new to open source and I would like to work on this issue. Can you help me how can  generate plain JSON-based reports as mentioned in description.
          What build steps should I execute?

          Thanks!

          Udit added a comment - Hello drulli . I am fairly new to open source and I would like to work on this issue. Can you help me how can  generate plain JSON-based reports as mentioned in description. What build steps should I execute? Thanks!

          Stefan added a comment -

          There is no need to use plain JSON-based reports for reproducing this - you can use any type of report from the warnings-ng-plugin which finds violations. The above screenshots are from https://ci.jenkins.io/job/Plugins/job/coverage-model/job/main/44/cpd/ An example JSON file is available in the tests of the plugin at https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/src/test/resources/io/jenkins/plugins/analysis/warnings/steps/issues.json

          Stefan added a comment - There is no need to use plain JSON-based reports for reproducing this - you can use any type of report from the warnings-ng-plugin which finds violations. The above screenshots are from https://ci.jenkins.io/job/Plugins/job/coverage-model/job/main/44/cpd/ An example JSON file is available in the tests of the plugin at https://github.com/jenkinsci/warnings-ng-plugin/blob/master/plugin/src/test/resources/io/jenkins/plugins/analysis/warnings/steps/issues.json

          Ulli Hafner added a comment -

          Actually you can see this problem with all warning types. Do you know how to setup a Jenkins job that shows the warnings from the warnings plugin?

          E.g. I have a sample Jenkinsfile: https://github.com/jenkinsci/analysis-model/blob/master/etc/Jenkinsfile.valgrind. This file can be used to set up a local Jenkins job, that shows the problem. This recordIssues step requires the warnings plugin to be installed. Then the Jenkinsfile checks out the sources from the analysis-model project and scans for files that match the pattern valgrind.xml. You can setup your own job using pipelines or freestyle jobs.

          Ulli Hafner added a comment - Actually you can see this problem with all warning types. Do you know how to setup a Jenkins job that shows the warnings from the warnings plugin? E.g. I have a sample Jenkinsfile: https://github.com/jenkinsci/analysis-model/blob/master/etc/Jenkinsfile.valgrind . This file can be used to set up a local Jenkins job, that shows the problem. This recordIssues step requires the warnings plugin to be installed. Then the Jenkinsfile checks out the sources from the analysis-model project and scans for files that match the pattern valgrind.xml. You can setup your own job using pipelines or freestyle jobs.

          Ulli Hafner added a comment -

          Example in our CI instance: https://ci.jenkins.io/job/Plugins/job/analysis-model/job/master/1651/spotbugs/

          Navigate to the issues tab and open the child rows using the + symbol.

          Ulli Hafner added a comment - Example in our CI instance: https://ci.jenkins.io/job/Plugins/job/analysis-model/job/master/1651/spotbugs/ Navigate to the issues tab and open the child rows using the + symbol.

          Udit added a comment -

          Hello drulli 
           I don't know how to setup a Jenkins job that shows the warnings from the warnings plugin.
          I stopped my local jenkins instance. Then ran mvn hpi:run in data-tables plugin project. I have server running on localhost:8080/jenkins.

          I have understood the bug quite well. The only issue is I dont know how to set up local instance on my laptop.
          I got .valgrind and .json file. Then how can I use those to reproduce the bug? 
          I'll look on internet do a bit more RnD regarding using plugins and warning ng{}{-}plugin.

          Udit added a comment - Hello drulli    I don't know how to setup a Jenkins job that shows the warnings from the warnings plugin. I stopped my local jenkins instance. Then ran mvn hpi:run in data-tables plugin project. I have server running on localhost:8080/jenkins. I have understood the bug quite well. The only issue is I dont know how to set up local instance on my laptop. I got .valgrind and .json file. Then how can I use those to reproduce the bug?  I'll look on internet do a bit more RnD regarding using plugins and warning ng{ } {-}plugin.

          Ulli Hafner added a comment -

          You can use my development environment: https://github.com/uhafner/warnings-ng-plugin-devenv

          It contains a docker container with some jobs that produce warnings.

          Ulli Hafner added a comment - You can use my development environment: https://github.com/uhafner/warnings-ng-plugin-devenv It contains a docker container with some jobs that produce warnings.

            Unassigned Unassigned
            stefan6419846 Stefan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: