Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72117

[ldap] Un-inlining validation/validate.jelly

XMLWordPrintable

      Level easy
      Skills a bit of JavaScript, a bit of Jelly

      Culprit:
      (1) - validation/validate.jelly#L58
      (2) - validation/validate.jelly#L71

      Reproduction steps:

      • Install LDAP or clone https://github.com/jenkinsci/ldap-plugin and then mvn hpi:run
      • Go to Manage Jenkins > Security
      • Select "LDAP" as your Security Realm
      • Click on "Test LDAP settings" (1)
        (2) I didn't quickly found it, but it should also be in this page.

      Screenshot attached about where the feature is displayed.

      Proposal
      https://www.jenkins.io/doc/developer/security/csp/#inline-event-handlers

      Testing notes
       - Ensure to reproduce the feature before any change
       - Ensure that you reproduce the feature after you have made the change

        1. image-2023-10-04-09-14-12-721.png
          image-2023-10-04-09-14-12-721.png
          81 kB
        2. Screenshot from 2023-10-10 19-23-32-1.png
          Screenshot from 2023-10-10 19-23-32-1.png
          68 kB

          [JENKINS-72117] [ldap] Un-inlining validation/validate.jelly

          Neetigya added a comment - - edited

          Hi, can you please help me reproduce this issue?

          I went to Manage Jenkins> Configure Security but I cannot find LDAP as an option in security realm
          I have attached my screenshot in the attachment for reference.

          Neetigya added a comment - - edited Hi, can you please help me reproduce this issue? I went to Manage Jenkins> Configure Security but I cannot find LDAP as an option in security realm I have attached my screenshot in the attachment for reference.

          Kevin Guerroudj added a comment - - edited

          Hi neetigyapod, it seems you don't have the LDAP plugin installed.
          To verify if this is really the case, go to "Manage Jenkins > Plugins > Installed" and search to see if LDAP is present in the list.
          If it's not the case, go to "Available plugins" and install it

          Kevin Guerroudj added a comment - - edited Hi neetigyapod , it seems you don't have the LDAP plugin installed. To verify if this is really the case, go to "Manage Jenkins > Plugins > Installed" and search to see if LDAP is present in the list. If it's not the case, go to "Available plugins" and install it

          Neetigya added a comment -

          Thank you kevingrdj . Fixed this issue and attached my screenshot in https://github.com/jenkinsci/ldap-plugin/pull/257 .

          Neetigya added a comment - Thank you kevingrdj . Fixed this issue and attached my screenshot in https://github.com/jenkinsci/ldap-plugin/pull/257 .

          Kevin Guerroudj added a comment -

          Closing this one in favor of JENKINS-70529.

          Kevin Guerroudj added a comment - Closing this one in favor of JENKINS-70529 .

            neetigyapod Neetigya
            kevingrdj Kevin Guerroudj
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: