Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72276

GitHub Auth plugin 596.v0646c4a_0a_962 severe performance regression

XMLWordPrintable

    • 597.ve0c3480fcb_d0

      Since installing 596.v0646c4a_0a_962 version of the GH auth plugin, performance of declarative pipeline degraded by about 20X making Jenkins pretty much unusable with this version of the plugin. I believe https://github.com/jenkinsci/github-oauth-plugin/pull/256 is responsible since it's the only true code change between this version.

       

          [JENKINS-72276] GitHub Auth plugin 596.v0646c4a_0a_962 severe performance regression

          Lenny added a comment -

          I made some comments on the GitHub PR for the probable issue... have you seen those?

          Lenny added a comment - I made some comments on the GitHub PR for the probable issue... have you seen those?

          Wadeck Follonier added a comment -

          not on the computer for a period

          Wadeck Follonier added a comment - not on the computer for a period

          Andreas Nygard added a comment -

          Hi there, I can assist with this, however my test environment isn't available until Monday.

          I feel we should roll back this change until it can be investigated properly, and so I'll do as such. Users of this feature can continue to pin to the version that was published.

          Andreas Nygard added a comment - Hi there, I can assist with this, however my test environment isn't available until Monday. I feel we should roll back this change until it can be investigated properly, and so I'll do as such. Users of this feature can continue to pin to the version that was published.

          Andreas Nygard added a comment -

          https://github.com/jenkinsci/github-oauth-plugin/pull/257

          Andreas Nygard added a comment - https://github.com/jenkinsci/github-oauth-plugin/pull/257

          Sam Gleske added a comment -

          I asked some followup questions in https://github.com/jenkinsci/github-oauth-plugin/pull/256#discussion_r1382401743

          Lenny, if you like, I can share some script console scripts where you can quickly gather this information.

          Sam Gleske added a comment - I asked some followup questions in https://github.com/jenkinsci/github-oauth-plugin/pull/256#discussion_r1382401743 Lenny, if you like, I can share some script console scripts where you can quickly gather this information.

          Lenny added a comment - - edited

          Thank you for the revert Andreas. It has fixed the problem.

          Lenny added a comment - - edited Thank you for the revert Andreas. It has fixed the problem.

          Lenny added a comment -

          Sam, I answered all your questions in the PR. You can share the scripts if my help is still needed. I will be glad to help

          Lenny added a comment - Sam, I answered all your questions in the PR. You can share the scripts if my help is still needed. I will be glad to help

          Wadeck Follonier added a comment -

          From a look at the pipelines in the repo, I don't understand why "all" become slow. If it was only https://github.com/flowlogix/jenkins/blob/main/CreateJenkinsJobs.groovy I could better understand.

          My gut feeling at this point is that my change was expected to have close to no impact on regular flow.
          Perhaps the lines loadMyself cache insertion have a larger impact than what I expected. I have not tested in depth the cache usage in the plugin.

          Wadeck Follonier added a comment - From a look at the pipelines in the repo, I don't understand why "all" become slow. If it was only https://github.com/flowlogix/jenkins/blob/main/CreateJenkinsJobs.groovy I could better understand. My gut feeling at this point is that my change was expected to have close to no impact on regular flow. Perhaps the lines loadMyself cache insertion have a larger impact than what I expected. I have not tested in depth the cache usage in the plugin.

          Lenny added a comment -

          That's correct. The cache usage is what I would guess as well. I already mentioned this in the original PR: https://github.com/jenkinsci/github-oauth-plugin/pull/256#issuecomment-1791969578

           

          From what I am casually observing, OAuth flow is being executed at least once, if not more than once, per every pipeline step command.

          Lenny added a comment - That's correct. The cache usage is what I would guess as well. I already mentioned this in the original PR: https://github.com/jenkinsci/github-oauth-plugin/pull/256#issuecomment-1791969578   From what I am casually observing, OAuth flow is being executed at least once, if not more than once, per every pipeline step command.

          Basil Crow added a comment -

          Fixed in jenkinsci/github-oauth-plugin#257. Released in 597.ve0c3480fcb_d0.

          Basil Crow added a comment - Fixed in jenkinsci/github-oauth-plugin#257 . Released in 597.ve0c3480fcb_d0 .

            wfollonier Wadeck Follonier
            lprimak Lenny
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: