Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72637

matrix-auth lacks support for Agent/Provision permission in Cloud scope

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      The permission doesn't show up. Something seems wrong with the showPermission logic given it's the only Cloud-scoped permission.

          [JENKINS-72637] matrix-auth lacks support for Agent/Provision permission in Cloud scope

          Markus Winter added a comment - - edited

          Potentially because
          https://github.com/jenkinsci/jenkins/blob/c00a30da805e95e7fb69104af2ddaedb2a0fc74b/core/src/main/java/hudson/slaves/Cloud.java#L266 is not inheriting the scope from JENKINS or COMPUTER
          It should be 

          private static final PermissionScope PERMISSION_SCOPE = new PermissionScope(Cloud.class, PermissionScope.COMPUTER);

          I think, given that the Permission is added to Permission group of computers

          Maybe also move that definition to PermissionScope class and make it public

          Markus Winter added a comment - - edited Potentially because https://github.com/jenkinsci/jenkins/blob/c00a30da805e95e7fb69104af2ddaedb2a0fc74b/core/src/main/java/hudson/slaves/Cloud.java#L266 is not inheriting the scope from JENKINS or COMPUTER It should be  private static final PermissionScope PERMISSION_SCOPE = new PermissionScope(Cloud.class, PermissionScope.COMPUTER); I think, given that the Permission is added to Permission group of computers Maybe also move that definition to PermissionScope class and make it public

          Daniel Beck added a comment -

          Agree, this looks more like a core bug. I tried the change locally and it would work with the existing plugin logic.

          Daniel Beck added a comment - Agree, this looks more like a core bug. I tried the change locally and it would work with the existing plugin logic.

            danielbeck Daniel Beck
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: