Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73316

Adapt SAML plugin for Jetty 12 (EE 9) or remove Mockito usages from OpenSamlWrapperTest

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Major Major
    • saml-plugin
    • None
    • 4.485.v99810fb_34d77

      When a Jetty 12 EE 9 core (i.e., one built from the jakarta branch of jenkins) and Jetty 12 EE 9 compatible test harness (i.e., one built from the forward branch of jenkins-test-harness) are used, the following test fails:

      • org.jenkinsci.plugins.saml.OpenSamlWrapperTest

      One solution is e.g. https://github.com/jenkinsci/saml-plugin/pull/421 to migrate to using Mockito with Jetty 12 EE 9. Unfortunately, that approach is not backward compatible with Jetty 10 or Jetty 12 EE 8, so the PR will have to remain in draft until we release Jetty 12 EE 9 support. Still, we should prepare the PR in advance.

      Alternatively, it would be more desirable if this test could instead stop using Mockito as in https://github.com/jenkinsci/view-job-filters-plugin/pull/58 and https://github.com/jenkinsci/configuration-as-code-plugin/pull/2494. That change could be prepared and released in advance without updating this plugin's core baseline.

          [JENKINS-73316] Adapt SAML plugin for Jetty 12 (EE 9) or remove Mockito usages from OpenSamlWrapperTest

          Basil Crow created issue -
          Basil Crow made changes -
          Link New: This issue is blocking JENKINS-73283 [ JENKINS-73283 ]
          Basil Crow made changes -
          Assignee Original: Ivan Fernandez Calvo [ ifernandezcalvo ]
          Basil Crow made changes -
          Link New: This issue depends on JENKINS-73278 [ JENKINS-73278 ]
          Basil Crow made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Basil Crow made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]
          Basil Crow made changes -
          Remote Link New: This issue links to "jenkinsci/saml-plugin#421 (Web Link)" [ 29712 ]
          Basil Crow made changes -
          Assignee New: Basil Crow [ basil ]

          Basil Crow added a comment -

          Basil Crow added a comment - Fixed in jenkinsci/saml-plugin#421 . Released in 4.485.v99810fb_34d77 .
          Basil Crow made changes -
          Released As New: 4.485.v99810fb_34d77
          Resolution New: Fixed [ 1 ]
          Status Original: In Review [ 10005 ] New: Closed [ 6 ]

            basil Basil Crow
            basil Basil Crow
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: