Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-73831

Use modern symbol instead of png

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • pipeline-maven-plugin
    • None
    • All
    • 1457.vf7a_de13b_c0d4

      Hi,

      The pipeline-maven-plugin still bundle old png instead of modern svg symbol.

      Those symbols are for example not themable

      Example

      https://github.com/jenkinsci/pipeline-maven-plugin/tree/master/pipeline-maven/src/main/webapp/images

      This issue suggest to get rid of old png, gifs et replace by modern theamable symbol/svg

        1. Screenshot from 2024-09-28 12-50-33.png
          Screenshot from 2024-09-28 12-50-33.png
          24 kB
        2. Screenshot from 2024-09-28 13-54-24.png
          Screenshot from 2024-09-28 13-54-24.png
          21 kB
        3. Screenshot from 2024-09-28 13-54-54.png
          Screenshot from 2024-09-28 13-54-54.png
          21 kB
        4. Screenshot from 2024-09-29 06-26-33.png
          Screenshot from 2024-09-29 06-26-33.png
          41 kB
        5. Screenshot from 2024-09-29 06-26-33-1.png
          Screenshot from 2024-09-29 06-26-33-1.png
          41 kB
        6. Screenshot from 2024-09-29 06-26-59.png
          Screenshot from 2024-09-29 06-26-59.png
          41 kB
        7. Screenshot from 2024-09-29 06-26-59-1.png
          Screenshot from 2024-09-29 06-26-59-1.png
          41 kB
        8. Screenshot from 2024-09-29 06-37-07.png
          Screenshot from 2024-09-29 06-37-07.png
          41 kB

          [JENKINS-73831] Use modern symbol instead of png

          Valentin Delaye added a comment -

          Some idea with symbols

          Dark theme

          Default theme

          Added on the oss-symbol-api plugin (can be taken from there). Probably not worth to add dependency for one icon

          Valentin Delaye added a comment - Some idea with symbols Dark theme Default theme Added on the oss-symbol-api plugin (can be taken from there). Probably not worth to add dependency for one icon

          Markus Winter added a comment -

          I like the colored feathers (Maven2), though the monocolor feathers are also ok as all other icons in Jenkins are also monocolor.

          The icons with text don't look so good (Maven3 in dark mode is hard to read).

          Could also be used for the old Maven plugin

          Markus Winter added a comment - I like the colored feathers (Maven2), though the monocolor feathers are also ok as all other icons in Jenkins are also monocolor. The icons with text don't look so good (Maven3 in dark mode is hard to read). Could also be used for the old Maven plugin

          Valentin Delaye added a comment - - edited

          Thanks. I think I will submit a PR with the monochrome for 2 logo.

          The point is that all other symbol are monochrome and having only one with color looks a be weird to me

          For example the git logo doesn't have the orange color

          Monochrome

          Color

           

           

          Valentin Delaye added a comment - - edited Thanks. I think I will submit a PR with the monochrome for 2 logo. The point is that all other symbol are monochrome and having only one with color looks a be weird to me For example the git logo doesn't have the orange color Monochrome Color    

          Valentin Delaye added a comment -

          PR open https://github.com/jenkinsci/pipeline-maven-plugin/pull/839

          Valentin Delaye added a comment - PR open https://github.com/jenkinsci/pipeline-maven-plugin/pull/839

            jonesbusy Valentin Delaye
            jonesbusy Valentin Delaye
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: