Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-74811

Default behavior was changed for pull request display name

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • branch-api-plugin
    • None

      When we upgraded branch api plugin to version 2.1197.vfa_d0c47c267d from a half year old version the behavior for pull request title in multi branch pipeline jobs changed.

      Previously PR-XXX was shown if multiBranchProjectDisplayNaming trait was not configured but now it seems to default to RAW_AND_OBJECT_DISPLAY_NAME.

      There doesn't seem to be any way to get back the old behavior of only showing PR id.

      Looking it at this recently merged pull request the change looks intentional:

      https://github.com/jenkinsci/branch-api-plugin/pull/476

       

      But it would be useful if there was an option to keep the old behavior as it makes it very hard to read the build queue (due to very long job names) and also build status sent to other integration applications (such as bitbucket branch source plugin) which also seems to send the display name which gets very messy.

          [JENKINS-74811] Default behavior was changed for pull request display name

          Tim Jacomb added a comment -

          I setup a bitbucket project to see what it looks like and yes it does look quite silly:

          Yes it makes sense to be able to disable this but I think bitbucket-branch-source should send something more sensible

          Tim Jacomb added a comment - I setup a bitbucket project to see what it looks like and yes it does look quite silly: Yes it makes sense to be able to disable this but I think bitbucket-branch-source should send something more sensible

          Tim Jacomb added a comment -

          I didn't find the job queue hard to read when I looked although it could possibly be optimised to make it look a bit better, cc janfaracik

          Tim Jacomb added a comment - I didn't find the job queue hard to read when I looked although it could possibly be optimised to make it look a bit better, cc janfaracik

          Daniel added a comment -

          Awesome, big thanks for fixing!

          We have a monorepo setup with a folder hierarchy for jobs so everything gets quite long since the full path is shown in the build queue and when the pull request title was added too it could easily occupy 5 lines per job in the build queue. But this is not really an issue, the real issue is as you say in the Bitbucket branch source plugin, it makes no sense to send the full title in build status notification since build status is recorded per pull request. We had 50 jobs in the build tab all displaying the name of the PR we were currently viewing.

           

          Will see if it is possible to add a config to the Bitbucket branch source plugin for build status notification name.

          Daniel added a comment - Awesome, big thanks for fixing! We have a monorepo setup with a folder hierarchy for jobs so everything gets quite long since the full path is shown in the build queue and when the pull request title was added too it could easily occupy 5 lines per job in the build queue. But this is not really an issue, the real issue is as you say in the Bitbucket branch source plugin, it makes no sense to send the full title in build status notification since build status is recorded per pull request. We had 50 jobs in the build tab all displaying the name of the PR we were currently viewing.   Will see if it is possible to add a config to the Bitbucket branch source plugin for build status notification name.

          Tim Jacomb added a comment -

          Would you mind given an example of your hierarchy? or if you can share a screenshot of what it looks like in the build queue?

          Tim Jacomb added a comment - Would you mind given an example of your hierarchy? or if you can share a screenshot of what it looks like in the build queue?

            Unassigned Unassigned
            danielnilsson9 Daniel
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: