-
New Feature
-
Resolution: Unresolved
-
Minor
-
None
Hello!
Long ago we forked the text-finder-plugin to enable many small features which were not accepted to text-finder-plugin in that time.
On long run, it seems that all the major the features were accepted into text-finder-plugin, except one - ability to change display name based on the content of files/logs.
I had implemented the feature like:
https://github.com/judovana/text-finders-plugin/pull/2
and result is as shown on the attached screenshot. User sets up regex, and if line matches this regex, the non matching part of the regex on that line is set as displayName. You can see it on the screenshot - user set `^future VR: ` it is matched on `future VR: jdk.11.0.19.6-0.ojdk11~ufips~upstream` and `jdk.11.0.19.6-0.ojdk11~ufips~upstream` is set as displayName.
There are few more missing features in myh fork (eg force "sucess" status (https://github.com/judovana/text-finders-plugin/commit/0132ab83146a25201caad7d7922e0233f165cc80) or setDescription which works on in same way as the set displayName (https://github.com/judovana/text-finders-plugin/commit/7c0091f6e428841357a48c0249e244deb548e31e and https://github.com/judovana/text-finders-plugin/commit/f5de3ea949b22c23e2d117f4246b13503c7df4fe )).
but the set displayName is most important to me. And text-finder-plugin is moving, and I would rather move with it. Before making any PRs, wdyt? Is the setDisplay name feature ok to contribute ? What about the other two?
This seems fine to me.