Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7733

System Message - Doesnt appear on any view other than the default view

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      System Message Configured to be : "<h1>Official Hudson Server</h1>"

      This message appears only in the default "All" view. Once you click on any other view, the message is not displayed

          [JENKINS-7733] System Message - Doesnt appear on any view other than the default view

          saimad created issue -
          sogabe made changes -
          Attachment New: SystemMessage_OK.png [ 21512 ]
          sogabe made changes -
          Attachment New: SystemMessage_NG.png [ 21513 ]

          sogabe added a comment -

          I tried pull request https://github.com/jenkinsci/jenkins/pull/369.
          But I found bug (see SystemMessage_NG.png).

          steps to reproduce.

          1. enter system message on "All" view. It's OK! (SystemMessage_OK.png)
          2. Click "GitHub" view. I can see system message.
          3. click "edit description" and submit without no change.
          4. I can see "System Message<br/>System Message" (SystemMessage_NG.png)

          sogabe added a comment - I tried pull request https://github.com/jenkinsci/jenkins/pull/369 . But I found bug (see SystemMessage_NG.png). steps to reproduce. 1. enter system message on "All" view. It's OK! (SystemMessage_OK.png) 2. Click "GitHub" view. I can see system message. 3. click "edit description" and submit without no change. 4. I can see "System Message<br/>System Message" (SystemMessage_NG.png)

          Code changed in jenkins
          User: baileys
          Path:
          core/src/main/java/hudson/model/MyViewsProperty.java
          core/src/main/java/hudson/model/TreeView.java
          core/src/main/java/hudson/model/View.java
          core/src/main/java/hudson/model/ViewGroup.java
          core/src/main/resources/lib/hudson/editableDescription.jelly
          http://jenkins-ci.org/commit/jenkins/f469733fbaa60cb93d92eed5842df46c5e1edb0c
          Log:
          [FIXED JENKINS-7733] System Message - Doesnt appear on any view other
          than the default view - In the view object appended the system message
          to the view description so that the system message now displays in all
          views.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: baileys Path: core/src/main/java/hudson/model/MyViewsProperty.java core/src/main/java/hudson/model/TreeView.java core/src/main/java/hudson/model/View.java core/src/main/java/hudson/model/ViewGroup.java core/src/main/resources/lib/hudson/editableDescription.jelly http://jenkins-ci.org/commit/jenkins/f469733fbaa60cb93d92eed5842df46c5e1edb0c Log: [FIXED JENKINS-7733] System Message - Doesnt appear on any view other than the default view - In the view object appended the system message to the view description so that the system message now displays in all views.
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Seiji Sogabe Path: changelog.html http://jenkins-ci.org/commit/jenkins/546157701b2b95ff8232c01e62e7476cd16003fa Log: changelog for JENKINS-7733 Compare: https://github.com/jenkinsci/jenkins/compare/ff1214f...5461577

          sogabe added a comment -

          I clicked 'MyView' link and clicked view tab then I got the following exception.

          org.apache.commons.jelly.JellyTagException: jar:file:/var/lib/tomcat-7/webapps/jenkins/WEB-INF/lib/jenkins-core-1.453-SNAPSHOT.jar!/lib/hudson/editableDescription.jelly:40:117: <j:out> java.lang.StackOverflowError
          	org.apache.commons.jelly.impl.TagScript.handleException(TagScript.java:735)
          	org.apache.commons.jelly.impl.TagScript.run(TagScript.java:290)
          	org.kohsuke.stapler.jelly.ReallyStaticTagLibrary$1.run(ReallyStaticTagLibrary.java:99)
          	org.kohsuke.stapler.jelly.ReallyStaticTagLibrary$1.run(ReallyStaticTagLibrary.java:99)
          	org.apache.commons.jelly.tags.core.CoreTagLibrary$1.run(CoreTagLibrary.java:98)
          
          (snip)
          
          java.lang.StackOverflowError
          	hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260)
          	hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260)
          	hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260)
          	hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260)
          	hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260)
          	hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260)
          	hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260)
          

          sogabe added a comment - I clicked 'MyView' link and clicked view tab then I got the following exception. org.apache.commons.jelly.JellyTagException: jar:file:/ var /lib/tomcat-7/webapps/jenkins/WEB-INF/lib/jenkins-core-1.453-SNAPSHOT.jar!/lib/hudson/editableDescription.jelly:40:117: <j:out> java.lang.StackOverflowError org.apache.commons.jelly.impl.TagScript.handleException(TagScript.java:735) org.apache.commons.jelly.impl.TagScript.run(TagScript.java:290) org.kohsuke.stapler.jelly.ReallyStaticTagLibrary$1.run(ReallyStaticTagLibrary.java:99) org.kohsuke.stapler.jelly.ReallyStaticTagLibrary$1.run(ReallyStaticTagLibrary.java:99) org.apache.commons.jelly.tags.core.CoreTagLibrary$1.run(CoreTagLibrary.java:98) (snip) java.lang.StackOverflowError hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260) hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260) hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260) hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260) hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260) hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260) hudson.model.MyViewsProperty.getSystemMessage(MyViewsProperty.java:260)
          sogabe made changes -
          Assignee New: sogabe [ sogabe ]
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]

          Code changed in jenkins
          User: Seiji Sogabe
          Path:
          core/src/main/java/hudson/model/MyViewsProperty.java
          core/src/main/java/hudson/model/TreeView.java
          core/src/main/java/hudson/model/View.java
          core/src/main/java/hudson/model/ViewGroup.java
          core/src/main/resources/lib/hudson/editableDescription.jelly
          http://jenkins-ci.org/commit/jenkins/875b3f628b9127661a3b84945df30bcaf66f3534
          Log:
          [FIXED JENKINS-7733] reimplementation of JENKINS-7733.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Seiji Sogabe Path: core/src/main/java/hudson/model/MyViewsProperty.java core/src/main/java/hudson/model/TreeView.java core/src/main/java/hudson/model/View.java core/src/main/java/hudson/model/ViewGroup.java core/src/main/resources/lib/hudson/editableDescription.jelly http://jenkins-ci.org/commit/jenkins/875b3f628b9127661a3b84945df30bcaf66f3534 Log: [FIXED JENKINS-7733] reimplementation of JENKINS-7733 .

            sogabe sogabe
            saimad saimad
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: