Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7798

File size should be shown on project dashboard for archived artifacts

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None

      The File size of an artifact should be shown on the project dashboard.

          [JENKINS-7798] File size should be shown on project dashboard for archived artifacts

          markus_keunecke created issue -

          Peter Hayes added a comment -

          This enhancement does not pertain to the dashboard-view plugin, but the dashboard in core.

          Peter Hayes added a comment - This enhancement does not pertain to the dashboard-view plugin, but the dashboard in core.
          Peter Hayes made changes -
          Component/s New: core [ 15593 ]
          Component/s Original: dashboard-view [ 15679 ]
          Assignee Original: Peter Hayes [ petehayes ]
          Fred G made changes -
          Assignee New: Fred G [ fredg ]

          stephen ware added a comment - - edited

          I needed this as well. Here is a solution patch.

          stephen ware added a comment - - edited I needed this as well. Here is a solution patch.
          stephen ware made changes -

          stephen ware added a comment -

          IGNORE THE ABOVE PATCH....HERE IS A PULL REQUEST.

          https://github.com/jenkinsci/jenkins/pull/240

          -stephen

          stephen ware added a comment - IGNORE THE ABOVE PATCH....HERE IS A PULL REQUEST. https://github.com/jenkinsci/jenkins/pull/240 -stephen

          Code changed in jenkins
          User: Stephen Ware
          Path:
          changelog.html
          core/src/main/java/hudson/model/Run.java
          core/src/main/resources/hudson/model/Run/artifacts-index.jelly
          core/src/main/resources/lib/hudson/artifactList.jelly
          http://jenkins-ci.org/commit/jenkins/94cbf5baf8640ff748332fb7799de2a978c72584
          Log:
          [FIXED JENKINS-7798]
          File size should be shown on project dashboard for archived artifacts.

          Run.java:
          Add member String length to Artifact object.
          Add paramter String len to Artifact constructor.
          Add method String getLength to Artifact object.
          addArtifacts method of Run class gets length of files as string
          for actual files or "0" if a directory and passes this as arg
          to Artifact constructor.

          artifacts-index.jelly and artifactList.jelly
          reworked to use same approach as
          core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly
          The desire being a consistent look in the interface.

          Signed-off-by: Stephen Ware <stephen.e.ware@intel.com>

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Ware Path: changelog.html core/src/main/java/hudson/model/Run.java core/src/main/resources/hudson/model/Run/artifacts-index.jelly core/src/main/resources/lib/hudson/artifactList.jelly http://jenkins-ci.org/commit/jenkins/94cbf5baf8640ff748332fb7799de2a978c72584 Log: [FIXED JENKINS-7798] File size should be shown on project dashboard for archived artifacts. Run.java: Add member String length to Artifact object. Add paramter String len to Artifact constructor. Add method String getLength to Artifact object. addArtifacts method of Run class gets length of files as string for actual files or "0" if a directory and passes this as arg to Artifact constructor. artifacts-index.jelly and artifactList.jelly reworked to use same approach as core/src/main/resources/hudson/model/DirectoryBrowserSupport/dir.jelly The desire being a consistent look in the interface. Signed-off-by: Stephen Ware <stephen.e.ware@intel.com>
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          core/src/main/java/hudson/model/Run.java
          http://jenkins-ci.org/commit/jenkins/96bc767965888a920f118d61b89241bc2fc9e11d
          Log:
          JENKINS-7798 better not to show the size for directories, I think.

          Compare: https://github.com/jenkinsci/jenkins/compare/37a22a1...96bc767

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: core/src/main/java/hudson/model/Run.java http://jenkins-ci.org/commit/jenkins/96bc767965888a920f118d61b89241bc2fc9e11d Log: JENKINS-7798 better not to show the size for directories, I think. Compare: https://github.com/jenkinsci/jenkins/compare/37a22a1...96bc767

            fredg Fred G
            markus_keunecke markus_keunecke
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: