Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7824

Claim plugin: Allow assigning builds/tests to other users

    XMLWordPrintable

Details

    • Improvement
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • claim-plugin
    • None

    Description

      Currently the plugin only allows claiming a build or test for yourself. It would be very helpful to also allow assigning a build to another user. For example, when working on a team of a few people, only one of us needs to check unstable builds and then assign out builds/tests to the team members.

      I've attached a patch with an initial implementation. It adds "assign" and "reassign" buttons on the UI, bringing up the same form but with an extra field for the target username. An email is sent to the assignee when he is not the user claiming the build for himself.

      Attachments

        Issue Links

          Activity

            trejkaz trejkaz added a comment -

            A patch was attached in October 2010. It's now December 2013 and no replies have come after the patch. Is there anything we can do to push progress forward here?

            trejkaz trejkaz added a comment - A patch was attached in October 2010. It's now December 2013 and no replies have come after the patch. Is there anything we can do to push progress forward here?
            drekbour Marc Carter added a comment -

            I want this as well and am picking this up as back-burner project. I've taken the original 2010 patch, simplified it and "rebased" it onto the current master branch. It's actually almost nothing so there's a lot required to productionise this - it will take a few weeks before I submit anything back.
            https://github.com/drekbour/claim-plugin/tree/assign-claim

            drekbour Marc Carter added a comment - I want this as well and am picking this up as back-burner project. I've taken the original 2010 patch, simplified it and "rebased" it onto the current master branch. It's actually almost nothing so there's a lot required to productionise this - it will take a few weeks before I submit anything back. https://github.com/drekbour/claim-plugin/tree/assign-claim
            ninian Ninian added a comment -

            Hi Marc,

            We're interested in this too, and the branch you've put together looks great and seems to cover everything we would want. Can I help in any way to assist in completing this?

            ninian Ninian added a comment - Hi Marc, We're interested in this too, and the branch you've put together looks great and seems to cover everything we would want. Can I help in any way to assist in completing this?
            drekbour Marc Carter added a comment -

            Having put this into use in my organisation there are two outstanding issues. Very much in descending order:
            1. autofill for the assignee box. This is generally quite easy but I don't know how to register a Descriptor for this type of class. Probably need to seek advice more actively as I'm sure those who know will understand immediately.
            2. "assigned to XXX" (no one likes finding their name on something they were not told about). Option A: Add an assignedBy property to the Action and add an optional rewording of the ui text. Option B: Just change "this build was claimed by" to "this build is assigned to" which covers all cases but drops the word "claim" from the claim plugin

            ping me on GH and I'll give you write access to my fork if you feel like chasing up those two items with the developer mailing list.

            drekbour Marc Carter added a comment - Having put this into use in my organisation there are two outstanding issues. Very much in descending order: 1. autofill for the assignee box. This is generally quite easy but I don't know how to register a Descriptor for this type of class. Probably need to seek advice more actively as I'm sure those who know will understand immediately. 2. "assigned to XXX" (no one likes finding their name on something they were not told about). Option A: Add an assignedBy property to the Action and add an optional rewording of the ui text. Option B: Just change "this build was claimed by" to "this build is assigned to" which covers all cases but drops the word "claim" from the claim plugin ping me on GH and I'll give you write access to my fork if you feel like chasing up those two items with the developer mailing list.
            abishop adam bishop added a comment -

            This is so important in organizations that aren't agile.

            abishop adam bishop added a comment - This is so important in organizations that aren't agile.

            Code changed in jenkins
            User: Marc Carter
            Path:
            readme.md
            src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
            src/main/webapp/help-assignee.html
            src/test/java/hudson/plugins/claim/ClaimTest.java
            http://jenkins-ci.org/commit/claim-plugin/c235979ff34b97b707d125d595d7cd330a029802
            Log:
            JENKINS-7824 Allow assigning builds/tests to other users

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marc Carter Path: readme.md src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly src/main/webapp/help-assignee.html src/test/java/hudson/plugins/claim/ClaimTest.java http://jenkins-ci.org/commit/claim-plugin/c235979ff34b97b707d125d595d7cd330a029802 Log: JENKINS-7824 Allow assigning builds/tests to other users

            Code changed in jenkins
            User: ninian
            Path:
            pom.xml
            src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java
            src/main/java/hudson/plugins/claim/DescribableTestAction.java
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
            src/main/resources/index.jelly
            http://jenkins-ci.org/commit/claim-plugin/8241d95ed43cbfbc842c88c9c3ce6f862df01a15
            Log:
            JENKINS-7824: Change assign to field to be a drop down list of users
            from the user DB

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: pom.xml src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java src/main/java/hudson/plugins/claim/DescribableTestAction.java src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly src/main/resources/index.jelly http://jenkins-ci.org/commit/claim-plugin/8241d95ed43cbfbc842c88c9c3ce6f862df01a15 Log: JENKINS-7824 : Change assign to field to be a drop down list of users from the user DB

            Code changed in jenkins
            User: ninian
            Path:
            src/main/java/hudson/plugins/claim/DescribableTestAction.java
            src/test/java/hudson/plugins/claim/ClaimReportTest.java
            src/test/java/hudson/plugins/claim/ClaimTest.java
            http://jenkins-ci.org/commit/claim-plugin/d8d105492041032941760adf256642236cffd557
            Log:
            JENKINS-7824: Make the unit tests work and order the list of users
            such that the current user is selected by default

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/java/hudson/plugins/claim/DescribableTestAction.java src/test/java/hudson/plugins/claim/ClaimReportTest.java src/test/java/hudson/plugins/claim/ClaimTest.java http://jenkins-ci.org/commit/claim-plugin/d8d105492041032941760adf256642236cffd557 Log: JENKINS-7824 : Make the unit tests work and order the list of users such that the current user is selected by default

            Code changed in jenkins
            User: Marc Carter
            Path:
            pom.xml
            src/test/java/hudson/plugins/claim/ClaimTest.java
            http://jenkins-ci.org/commit/claim-plugin/cc86aacef6cd87c70fea5ee0ce7c19679969953f
            Log:
            JENKINS-7824 testcase to prove default assignee is yourself

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marc Carter Path: pom.xml src/test/java/hudson/plugins/claim/ClaimTest.java http://jenkins-ci.org/commit/claim-plugin/cc86aacef6cd87c70fea5ee0ce7c19679969953f Log: JENKINS-7824 testcase to prove default assignee is yourself

            Code changed in jenkins
            User: ki82
            Path:
            readme.md
            src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java
            src/main/java/hudson/plugins/claim/DescribableTestAction.java
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.properties
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary_zh_TW.properties
            src/main/resources/index.jelly
            src/main/webapp/help-assignee.html
            src/main/webapp/help-assignee_zh_TW.html
            src/test/java/hudson/plugins/claim/ClaimReportTest.java
            src/test/java/hudson/plugins/claim/ClaimTest.java
            http://jenkins-ci.org/commit/claim-plugin/dcefc3d941f9598663e35f4994c75bf6f7dac725
            Log:
            Merge pull request #12 from drekbour/assign-claim

            JENKINS-7824 Allow assigning builds/tests to other users

            Compare: https://github.com/jenkinsci/claim-plugin/compare/c474b1bd27cf...dcefc3d941f9

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ki82 Path: readme.md src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java src/main/java/hudson/plugins/claim/DescribableTestAction.java src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.properties src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary_zh_TW.properties src/main/resources/index.jelly src/main/webapp/help-assignee.html src/main/webapp/help-assignee_zh_TW.html src/test/java/hudson/plugins/claim/ClaimReportTest.java src/test/java/hudson/plugins/claim/ClaimTest.java http://jenkins-ci.org/commit/claim-plugin/dcefc3d941f9598663e35f4994c75bf6f7dac725 Log: Merge pull request #12 from drekbour/assign-claim JENKINS-7824 Allow assigning builds/tests to other users Compare: https://github.com/jenkinsci/claim-plugin/compare/c474b1bd27cf...dcefc3d941f9

            Code changed in jenkins
            User: ninian
            Path:
            src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java
            src/main/java/hudson/plugins/claim/ClaimTestAction.java
            src/main/java/hudson/plugins/claim/ClaimedBuildsReport.java
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.properties
            src/main/resources/hudson/plugins/claim/ClaimColumn/column.jelly
            src/main/resources/hudson/plugins/claim/ClaimColumn/column.properties
            src/main/resources/hudson/plugins/claim/Messages.properties
            src/main/webapp/help-assignee.html
            src/test/java/hudson/plugins/claim/ClaimTest.java
            http://jenkins-ci.org/commit/claim-plugin/69dd1a8827220bdd2d3456e8744f8ce1e3003d92
            Log:
            JENKINS-7824: Add a record of who assigned the build failure and display
            it

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java src/main/java/hudson/plugins/claim/ClaimTestAction.java src/main/java/hudson/plugins/claim/ClaimedBuildsReport.java src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.properties src/main/resources/hudson/plugins/claim/ClaimColumn/column.jelly src/main/resources/hudson/plugins/claim/ClaimColumn/column.properties src/main/resources/hudson/plugins/claim/Messages.properties src/main/webapp/help-assignee.html src/test/java/hudson/plugins/claim/ClaimTest.java http://jenkins-ci.org/commit/claim-plugin/69dd1a8827220bdd2d3456e8744f8ce1e3003d92 Log: JENKINS-7824 : Add a record of who assigned the build failure and display it

            Code changed in jenkins
            User: ninian
            Path:
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
            src/main/resources/hudson/plugins/claim/ClaimColumn/column.jelly
            http://jenkins-ci.org/commit/claim-plugin/45c067c337238053d12f87873c8369b6da768d42
            Log:
            JENKINS-7824: use spaces rather than tabs in jelly files modified to add
            assigned by details

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly src/main/resources/hudson/plugins/claim/ClaimColumn/column.jelly http://jenkins-ci.org/commit/claim-plugin/45c067c337238053d12f87873c8369b6da768d42 Log: JENKINS-7824 : use spaces rather than tabs in jelly files modified to add assigned by details

            Code changed in jenkins
            User: ninian
            Path:
            src/main/resources/hudson/plugins/claim/ClaimColumn/column.jelly
            http://jenkins-ci.org/commit/claim-plugin/0dd4449b9f1d6d49d608190e558cb86048b1abbf
            Log:
            JENKINS-7824: Correct indentation for change to add assigned by field

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/resources/hudson/plugins/claim/ClaimColumn/column.jelly http://jenkins-ci.org/commit/claim-plugin/0dd4449b9f1d6d49d608190e558cb86048b1abbf Log: JENKINS-7824 : Correct indentation for change to add assigned by field

            Code changed in jenkins
            User: ninian
            Path:
            pom.xml
            src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java
            src/main/java/hudson/plugins/claim/ClaimBuildAction.java
            src/main/java/hudson/plugins/claim/ClaimConfig.java
            src/main/java/hudson/plugins/claim/ClaimEmailer.java
            src/main/java/hudson/plugins/claim/ClaimTestAction.java
            src/main/java/hudson/plugins/claim/ClaimTestDataPublisher.java
            src/main/resources/hudson/plugins/claim/ClaimConfig/config.jelly
            src/main/resources/hudson/plugins/claim/ClaimConfig/config.properties
            src/main/resources/hudson/plugins/claim/Messages.properties
            src/main/webapp/help-sendEmails.html
            src/test/java/hudson/plugins/claim/ClaimEmailerTest.java
            http://jenkins-ci.org/commit/claim-plugin/a042eaaa28720855a67b45f87efd319966e9ce60
            Log:
            JENKINS-7824: Add configurable emails to assignees when assigning a
            failure

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: pom.xml src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java src/main/java/hudson/plugins/claim/ClaimBuildAction.java src/main/java/hudson/plugins/claim/ClaimConfig.java src/main/java/hudson/plugins/claim/ClaimEmailer.java src/main/java/hudson/plugins/claim/ClaimTestAction.java src/main/java/hudson/plugins/claim/ClaimTestDataPublisher.java src/main/resources/hudson/plugins/claim/ClaimConfig/config.jelly src/main/resources/hudson/plugins/claim/ClaimConfig/config.properties src/main/resources/hudson/plugins/claim/Messages.properties src/main/webapp/help-sendEmails.html src/test/java/hudson/plugins/claim/ClaimEmailerTest.java http://jenkins-ci.org/commit/claim-plugin/a042eaaa28720855a67b45f87efd319966e9ce60 Log: JENKINS-7824 : Add configurable emails to assignees when assigning a failure

            Code changed in jenkins
            User: ninian
            Path:
            src/main/webapp/help-sendEmails.html
            http://jenkins-ci.org/commit/claim-plugin/425b1979c31f25d7f360489344e832cced13ba4c
            Log:
            JENKINS-7824: Correct text for email help

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/webapp/help-sendEmails.html http://jenkins-ci.org/commit/claim-plugin/425b1979c31f25d7f360489344e832cced13ba4c Log: JENKINS-7824 : Correct text for email help

            Code changed in jenkins
            User: ninian
            Path:
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
            src/main/webapp/help-sendEmails.html
            http://jenkins-ci.org/commit/claim-plugin/231ef9f6ad00a509406ca04a23954cb9cca45f42
            Log:
            JENKINS-7824: Allow users to drop claims assigned to them by other users

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ninian Path: src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly src/main/webapp/help-sendEmails.html http://jenkins-ci.org/commit/claim-plugin/231ef9f6ad00a509406ca04a23954cb9cca45f42 Log: JENKINS-7824 : Allow users to drop claims assigned to them by other users

            Code changed in jenkins
            User: ki82
            Path:
            pom.xml
            src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java
            src/main/java/hudson/plugins/claim/ClaimBuildAction.java
            src/main/java/hudson/plugins/claim/ClaimConfig.java
            src/main/java/hudson/plugins/claim/ClaimEmailer.java
            src/main/java/hudson/plugins/claim/ClaimTestAction.java
            src/main/java/hudson/plugins/claim/ClaimTestDataPublisher.java
            src/main/java/hudson/plugins/claim/ClaimedBuildsReport.java
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly
            src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.properties
            src/main/resources/hudson/plugins/claim/ClaimColumn/column.jelly
            src/main/resources/hudson/plugins/claim/ClaimColumn/column.properties
            src/main/resources/hudson/plugins/claim/ClaimConfig/config.jelly
            src/main/resources/hudson/plugins/claim/ClaimConfig/config.properties
            src/main/resources/hudson/plugins/claim/Messages.properties
            src/main/webapp/help-assignee.html
            src/main/webapp/help-sendEmails.html
            src/test/java/hudson/plugins/claim/ClaimEmailerTest.java
            src/test/java/hudson/plugins/claim/ClaimTest.java
            http://jenkins-ci.org/commit/claim-plugin/10c6cf1221cab49bc9e59914a33aed3df5a0e6f3
            Log:
            Merge pull request #13 from ninian/master

            JENKINS-7824: Add 'assigned by' field and optional emails

            Compare: https://github.com/jenkinsci/claim-plugin/compare/dcefc3d941f9...10c6cf1221ca

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ki82 Path: pom.xml src/main/java/hudson/plugins/claim/AbstractClaimBuildAction.java src/main/java/hudson/plugins/claim/ClaimBuildAction.java src/main/java/hudson/plugins/claim/ClaimConfig.java src/main/java/hudson/plugins/claim/ClaimEmailer.java src/main/java/hudson/plugins/claim/ClaimTestAction.java src/main/java/hudson/plugins/claim/ClaimTestDataPublisher.java src/main/java/hudson/plugins/claim/ClaimedBuildsReport.java src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.jelly src/main/resources/hudson/plugins/claim/AbstractClaimBuildAction/summary.properties src/main/resources/hudson/plugins/claim/ClaimColumn/column.jelly src/main/resources/hudson/plugins/claim/ClaimColumn/column.properties src/main/resources/hudson/plugins/claim/ClaimConfig/config.jelly src/main/resources/hudson/plugins/claim/ClaimConfig/config.properties src/main/resources/hudson/plugins/claim/Messages.properties src/main/webapp/help-assignee.html src/main/webapp/help-sendEmails.html src/test/java/hudson/plugins/claim/ClaimEmailerTest.java src/test/java/hudson/plugins/claim/ClaimTest.java http://jenkins-ci.org/commit/claim-plugin/10c6cf1221cab49bc9e59914a33aed3df5a0e6f3 Log: Merge pull request #13 from ninian/master JENKINS-7824 : Add 'assigned by' field and optional emails Compare: https://github.com/jenkinsci/claim-plugin/compare/dcefc3d941f9...10c6cf1221ca

            Released in 2.4 today.

            ki82 Christian Bremer added a comment - Released in 2.4 today.
            jonmr Jon Radon added a comment -

            I noticed that 2.4 isn't available in my Jenkins instance, any idea when it will be available?

            jonmr Jon Radon added a comment - I noticed that 2.4 isn't available in my Jenkins instance, any idea when it will be available?
            bryunits Breck Yunits added a comment -

            Also noticed that 2.4 is not yet available. Would love to use this feature.

            bryunits Breck Yunits added a comment - Also noticed that 2.4 is not yet available. Would love to use this feature.
            david_resnick David Resnick added a comment -

            This has been rolled out and is fantastic!

            For some reason, no email is sent when assigning to someone else. Is there some configuration I'm missing for this feature? If not I will open an issue.

            david_resnick David Resnick added a comment - This has been rolled out and is fantastic! For some reason, no email is sent when assigning to someone else. Is there some configuration I'm missing for this feature? If not I will open an issue.
            ninian Ninian added a comment -

            Whether emails are sent or not is configurable:
            Go to Manage Jenkins->Configure System, then look for the 'Claim' section. There should be a check-box there "Send emails when assigning/claiming builds".

            This was added to allow preservation of the previous behaviour, which is that no mail is sent if someone claimed a build failure.

            ninian Ninian added a comment - Whether emails are sent or not is configurable: Go to Manage Jenkins->Configure System, then look for the 'Claim' section. There should be a check-box there "Send emails when assigning/claiming builds". This was added to allow preservation of the previous behaviour, which is that no mail is sent if someone claimed a build failure.
            david_resnick David Resnick added a comment -

            Thanks, I've updated the wiki about this.

            david_resnick David Resnick added a comment - Thanks, I've updated the wiki about this.
            abishop adam bishop added a comment -

            Thanks, this is excellent.

            abishop adam bishop added a comment - Thanks, this is excellent.

            Yes, thanks, it truly is.

            Getting JENKINS-30765 and JENKINS-30766 would make the happiness complete.

            magjac Magnus Jacobsson added a comment - Yes, thanks, it truly is. Getting JENKINS-30765 and JENKINS-30766 would make the happiness complete.

            People

              drekbour Marc Carter
              nikitad nikitad
              Votes:
              15 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: