[JENKINS-8617] cannot customize security group to launch slaves into - Jenkins Jira

XML

Word

Printable

Details

Type: Improvement
Status: Closed (View Workflow)
Priority: Minor
Resolution: Fixed
Component/s: ec2-plugin
Labels:
None

Similar Issues:

Show

Description

It's slightly inconvenient to have to use the 'default' security group for our slaves.

It's only slightly inconvenient, but it seems that this should be pretty easy to fix, too. I may even try myself!

Attachments

Activity

Ascending order - Click to sort in descending order

View 6 older comments

SCM/JIRA link daemon added a comment - 2012-05-22 05:02

Code changed in jenkins
User: Francis Upton
Path:
pom.xml
src/main/java/hudson/plugins/ec2/SlaveTemplate.java
src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly
src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java
src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java
http://jenkins-ci.org/commit/ec2-plugin/543777c6f79adaf243df931bfffda6d3a86ca5f7
Log:
Merge pull request #18 from yyuu/master

~~JENKINS-8617~~ cannot customize security group to launch slaves into

Compare: https://github.com/jenkinsci/ec2-plugin/compare/d96e049...543777c

SCM/JIRA link daemon added a comment - 2012-05-22 05:02 Code changed in jenkins User: Francis Upton Path: pom.xml src/main/java/hudson/plugins/ec2/SlaveTemplate.java src/main/resources/hudson/plugins/ec2/SlaveTemplate/config.jelly src/test/java/hudson/plugins/ec2/SlaveTemplateTest.java src/test/java/hudson/plugins/ec2/TemplateLabelsTest.java http://jenkins-ci.org/commit/ec2-plugin/543777c6f79adaf243df931bfffda6d3a86ca5f7 Log: Merge pull request #18 from yyuu/master JENKINS-8617 cannot customize security group to launch slaves into Compare: https://github.com/jenkinsci/ec2-plugin/compare/d96e049...543777c

Francis Upton added a comment - 2012-05-22 05:07

Thanks for your contribution Yuu.

I committed this, but I'm concerned about the the commit that changes the required version to 1.462; I think that 1.399 should be fine (certain for this work), unless something else has changed. If you agree can you provide another pull request to fix the version back?

Francis Upton added a comment - 2012-05-22 05:07 Thanks for your contribution Yuu. I committed this, but I'm concerned about the the commit that changes the required version to 1.462; I think that 1.399 should be fine (certain for this work), unless something else has changed. If you agree can you provide another pull request to fix the version back?

Francis Upton added a comment - 2012-05-22 05:19

Sorry for the spam, I fixed the version thing.

Francis Upton added a comment - 2012-05-22 05:19 Sorry for the spam, I fixed the version thing.

Francis Upton added a comment - 2012-05-22 05:20

Thanks for your contribution!

Francis Upton added a comment - 2012-05-22 05:20 Thanks for your contribution!

Yuu Yamashita added a comment - 2012-05-22 05:48

> I committed this, but I'm concerned about the the commit that changes the required version to 1.462; I think that 1.399 should be fine (certain for this work), unless something else has changed. If you agree can you provide another pull request to fix the version back?

Thanks for merging.

I'm agree to rollback Jenkins to 1.399.
There's no special reason to upgrade Jenkins to 1.462.
I just thought newer Jenkins must be greater

Yuu Yamashita added a comment - 2012-05-22 05:48 > I committed this, but I'm concerned about the the commit that changes the required version to 1.462; I think that 1.399 should be fine (certain for this work), unless something else has changed. If you agree can you provide another pull request to fix the version back? Thanks for merging. I'm agree to rollback Jenkins to 1.399. There's no special reason to upgrade Jenkins to 1.462. I just thought newer Jenkins must be greater

People

Assignee:: Yuu Yamashita

Reporter:: mwhudson

Votes:: 1 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2011-01-25 21:16

Updated:: 2016-01-27 06:09

Resolved:: 2012-05-22 05:20