Details
-
Improvement
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
Description
For parametrized promotion:
It is possible to set parameters values only for the first promotion execution for a specific build.
For re-execution parameters cannot be changed. Promotion process gets the same values.
Attachments
Issue Links
- is related to
-
JENKINS-22005 Repeating/Duplicating promotion parameters
-
- Reopened
-
-
-
- Resolved
-
Activity
liamjbennett
added a comment - This should be a configurable option. Also you may want to disable the ability to edit parameters if the previous promotion has failed, thus forcing the user to fix the failure before moving on to the next promotion.
liamjbennett
added a comment - This should be a configurable option. Also you may want to disable the ability to edit parameters if the previous promotion has failed, thus forcing the user to fix the failure before moving on to the next promotion. 
Chris Z
added a comment - A little bit frustrating bug. 
Nathan Overbey
added a comment - Would gladly pay for this enhancement Nathan Overbey
added a comment - Changed issue type from Bug to Improvement 
Nathan Overbey
added a comment - ok, my friends. I have found a work around. I wrote a script that executes after the promoted job. It strips out the promotion history (xml) from the build job (build.xml). I then post that xml file to http://jenkinsurl/job/test1/config.xml.
It takes a bit of scripting because you'll need to find the build.xml file.
Would still be nice to have this baked into the plugin in a manor that makes it easy to view the history via UI. My method wacks it in the UI.
Nathan Overbey
added a comment - ok, my friends. I have found a work around. I wrote a script that executes after the promoted job. It strips out the promotion history (xml) from the build job (build.xml). I then post that xml file to http://jenkinsurl/job/test1/config.xml .
It takes a bit of scripting because you'll need to find the build.xml file.
Would still be nice to have this baked into the plugin in a manor that makes it easy to view the history via UI. My method wacks it in the UI.
Clecio Varjao
added a comment - I've submitted a pull request: https://github.com/jenkinsci/promoted-builds-plugin/pull/27
Clecio Varjao
added a comment - I've submitted a pull request: https://github.com/jenkinsci/promoted-builds-plugin/pull/27 
Marvi Benedet
added a comment - Tried this snapshoot ad worked for me.
Many thanks Clecio! Clecio Varjao
added a comment - I need some comments/votes to include my fix with the source code:
https://github.com/jenkinsci/promoted-builds-plugin/pull/28
Anybody else have been using my patch?
Clecio Varjao
added a comment - I need some comments/votes to include my fix with the source code:
https://github.com/jenkinsci/promoted-builds-plugin/pull/28
Anybody else have been using my patch? Code changed in jenkins
User: cvarjao
Path:
src/main/java/hudson/plugins/promoted_builds/Promotion.java
src/main/java/hudson/plugins/promoted_builds/PromotionParametersAction.java
src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
src/main/java/hudson/plugins/promoted_builds/Status.java
src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java
src/main/resources/hudson/plugins/promoted_builds/PromotedBuildAction/index.jelly
src/main/resources/hudson/plugins/promoted_builds/conditions/ManualCondition/Badge/index.jelly
http://jenkins-ci.org/commit/promoted-builds-plugin/9395ed5d781ac93fcd6baf629e99a2f0048a05aa
Log:
[FIXED JENKINS-8962] Enable editing parameters for re-executions
Code changed in jenkins
User: Nicolas De Loof
Path:
src/main/java/hudson/plugins/promoted_builds/Promotion.java
src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
src/main/java/hudson/plugins/promoted_builds/Status.java
src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java
src/main/resources/hudson/plugins/promoted_builds/PromotedBuildAction/index.jelly
src/main/resources/hudson/plugins/promoted_builds/conditions/ManualCondition/Badge/index.jelly
http://jenkins-ci.org/commit/promoted-builds-plugin/4f62ff6259e7336e9378f5d9810dda9d7dbff61d
Log:
Merge remote-tracking branch 'cvarjao/JENKINS-8962'
Conflicts:
src/main/java/hudson/plugins/promoted_builds/Promotion.java
Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/770c7bbb69a2...4f62ff6259e7
Clecio Varjao
added a comment - fix on pull request #28 
In case of promote failure due to incorrect parameter given (maybe typo), there is no chance to get it correct again unless triggering a new build and do the promotion.