• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • promoted-builds-plugin
    • None
    • Since: 2.15

      When there is a job with multiple promotion processes, the parameters are getting mixed up among promotion processes.

      1) Create a job (Job001)
      a) add Promotion Process (PROM0)
      i) check "Only when manually approved" criteria
      ii) add a String parameter (name: param_1, default_value: PROM0_v1)
      ii) add a String parameter (name: param_2, default_value: PROM0_v2)
      b) add Promotion Process (PROM1)
      i) check "Only when manually approved" criteria
      ii) add a String parameter (name: param_1, default_value: PROM1_v1)
      ii) add a String parameter (name: param_2, default_value: PROM1_v2)
      c) add Promotion Process (PROM2)
      i) check "Only when manually approved" criteria
      ii) add a String parameter (name: param_1, default_value: PROM2_v1)
      ii) add a String parameter (name: param_2, default_value: PROM2_v2)
      2) Do a Build
      3) Approve "PROM0"
      4) Approve "PROM1"
      5) BUG: PROM1 parameters will have duplicate parameter fields mixed up between PROM0 and PROM1

          [JENKINS-22005] Repeating/Duplicating promotion parameters

          Clecio Varjao added a comment -

          Clecio Varjao added a comment - pending https://github.com/jenkinsci/promoted-builds-plugin/pull/39

          Code changed in jenkins
          User: cvarjao
          Path:
          src/main/java/hudson/plugins/promoted_builds/JobPropertyImpl.java
          src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
          src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java
          src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionBug22005.java
          src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionTest.java
          http://jenkins-ci.org/commit/promoted-builds-plugin/8a3928a2588d68b0be1d91389b8e17c6d0dc5739
          Log:

          • [FIXED JENKINS-22005]
          • Adding ManualCondition Test Cases and making a few changes for supporting them.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: cvarjao Path: src/main/java/hudson/plugins/promoted_builds/JobPropertyImpl.java src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionBug22005.java src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionTest.java http://jenkins-ci.org/commit/promoted-builds-plugin/8a3928a2588d68b0be1d91389b8e17c6d0dc5739 Log: [FIXED JENKINS-22005] Adding ManualCondition Test Cases and making a few changes for supporting them.

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/hudson/plugins/promoted_builds/JobPropertyImpl.java
          src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
          src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java
          src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionBug22005.java
          src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionTest.java
          http://jenkins-ci.org/commit/promoted-builds-plugin/505787d01cbbf0566107f64abf480b763ca2161a
          Log:
          Merge pull request #39 from cvarjao/JENKINS-22005

          FIXED JENKINS-22005

          Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/ab5c2a18c265...505787d01cbb

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/hudson/plugins/promoted_builds/JobPropertyImpl.java src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java src/main/java/hudson/plugins/promoted_builds/conditions/ManualCondition.java src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionBug22005.java src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionTest.java http://jenkins-ci.org/commit/promoted-builds-plugin/505787d01cbbf0566107f64abf480b763ca2161a Log: Merge pull request #39 from cvarjao/ JENKINS-22005 FIXED JENKINS-22005 Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/ab5c2a18c265...505787d01cbb

          Joshua ayson added a comment -

          This fix (2.17) created a new bug and I had to revert to 2.16 to get my build promotion chain to work.

          Here is what I have setup.

          Build A auto-promotes itself and calls build B, which auto-promotes itself to build C. Environment variables are passed from A to B to C. When they get to C instead of having the values of the variables, the variables names are passed through. Oddly enough if I go to build B and re-execute the promotion the proper interpolation happens for the variables, which did not occur during the auto-promotion.

          Regards,
          Joshua

          Joshua ayson added a comment - This fix (2.17) created a new bug and I had to revert to 2.16 to get my build promotion chain to work. Here is what I have setup. Build A auto-promotes itself and calls build B, which auto-promotes itself to build C. Environment variables are passed from A to B to C. When they get to C instead of having the values of the variables, the variables names are passed through. Oddly enough if I go to build B and re-execute the promotion the proper interpolation happens for the variables, which did not occur during the auto-promotion. Regards, Joshua

          Clecio Varjao added a comment -

          Would you be able to provide a test case? or at least the configuration files?
          Similar to this one:
          https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionTest.java

          What do you mean by "calls build B"? there a few ways (plugins) to trigger another build.

          Clecio Varjao added a comment - Would you be able to provide a test case? or at least the configuration files? Similar to this one: https://github.com/jenkinsci/promoted-builds-plugin/blob/master/src/test/java/hudson/plugins/promoted_builds/conditions/ManualConditionTest.java What do you mean by "calls build B"? there a few ways (plugins) to trigger another build.

          Joshua ayson added a comment - - edited

          Use case for issue with 2.17 update (PDF attached - https://issues.jenkins-ci.org/secure/attachment/25718/jenkins-promo-issue.pdf)

          Joshua ayson added a comment - - edited Use case for issue with 2.17 update (PDF attached - https://issues.jenkins-ci.org/secure/attachment/25718/jenkins-promo-issue.pdf )

            cvarjao Clecio Varjao
            cvarjao Clecio Varjao
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: