Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9277

NPE on empty label expression name

    XMLWordPrintable

Details

    Description

      steps to reproduce:

      • create a multi-configuration project
      • add a Label Expression axis
      • delete the expression name
      • click save

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-25448 NPE on job save when no expressions provided for label expression axis

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Descending order - Click to sort in ascending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            src/main/java/hudson/matrix/AxisDescriptor.java
            src/main/java/hudson/matrix/JDKAxis.java
            src/main/java/hudson/matrix/LabelExpAxis.java
            src/main/java/hudson/matrix/MatrixProject.java
            src/main/java/hudson/matrix/TextAxis.java
            src/main/resources/hudson/matrix/Messages.properties
            src/test/java/hudson/matrix/AxisDescriptorTest.java
            src/test/java/hudson/matrix/AxisTest.java
            http://jenkins-ci.org/commit/matrix-project-plugin/1bdbe10c552928ce2547df3fc180c1c5db4d9588
            Log:
            Merge pull request #14 from olivergondza/validate-axes

            [FIXED JENKINS-9277 JENKINS-25448 JENKINS-23614] Disallow special chars in axis names and values

            Compare: https://github.com/jenkinsci/matrix-project-plugin/compare/6be15fe17421...1bdbe10c5529

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/matrix/AxisDescriptor.java src/main/java/hudson/matrix/JDKAxis.java src/main/java/hudson/matrix/LabelExpAxis.java src/main/java/hudson/matrix/MatrixProject.java src/main/java/hudson/matrix/TextAxis.java src/main/resources/hudson/matrix/Messages.properties src/test/java/hudson/matrix/AxisDescriptorTest.java src/test/java/hudson/matrix/AxisTest.java http://jenkins-ci.org/commit/matrix-project-plugin/1bdbe10c552928ce2547df3fc180c1c5db4d9588 Log: Merge pull request #14 from olivergondza/validate-axes [FIXED JENKINS-9277 JENKINS-25448 JENKINS-23614] Disallow special chars in axis names and values Compare: https://github.com/jenkinsci/matrix-project-plugin/compare/6be15fe17421...1bdbe10c5529
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            src/main/java/hudson/matrix/AxisDescriptor.java
            src/main/java/hudson/matrix/JDKAxis.java
            src/main/java/hudson/matrix/LabelExpAxis.java
            src/main/resources/hudson/matrix/Messages.properties
            src/test/java/hudson/matrix/AxisTest.java
            http://jenkins-ci.org/commit/matrix-project-plugin/9ea857b279b86dd9c27268ffddad1359b3df8e27
            Log:
            [FIXED JENKINS-9277 JENKINS-25448] Reject invalid axis name/value at the time of configuration

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/matrix/AxisDescriptor.java src/main/java/hudson/matrix/JDKAxis.java src/main/java/hudson/matrix/LabelExpAxis.java src/main/resources/hudson/matrix/Messages.properties src/test/java/hudson/matrix/AxisTest.java http://jenkins-ci.org/commit/matrix-project-plugin/9ea857b279b86dd9c27268ffddad1359b3df8e27 Log: [FIXED JENKINS-9277 JENKINS-25448] Reject invalid axis name/value at the time of configuration
            olivergondza Oliver Gondža added a comment -

            Proposing fix https://github.com/jenkinsci/matrix-project-plugin/pull/14.

            olivergondza Oliver Gondža added a comment - Proposing fix https://github.com/jenkinsci/matrix-project-plugin/pull/14 .

            People

              olivergondza Oliver Gondža
              thorsten_horstmann thorsten_horstmann
              Votes:
              2 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: