Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9637

Problems with "Latest Test Result" and "Aggregated Test Result" links

    XMLWordPrintable

Details

    Description

      On the main page of a free-style project that aggregates test results from downstream projects,
      the "Latest Test Result" link points to
      http://jenkins/job/testJob/lastCompletedBuild/testReport/ instead of
      http://jenkins/job/testJob/lastCompletedBuild/aggregatedTestReport/ .
      The link should also say "Latest Aggregated Test Result".

      In Chrome and IE this leads to 404s. Firefox automatically shows the parent page (that's actually why I didn't notice this bug earlier).

      The underlying problem is that in main.jelly the following check is always true:

      ${tr.class.name != 'hudson.tasks.test.AggregatedTestResultAction}

      (the class name is in fact "hudson.tasks.test.AggregatedTestResultPublisher$TestResultAction" for a free-style project with aggregated test results)
      and

      ${it.lastCompletedBuild.aggregatedTestResultAction}

      always returns null, because AggregatedTestResultAction is not assigned to the job.

      I'm wondering if the AggregatedTestResultAction is obsolete (eventhough MatrixTestResult extends it)?

      Attachments

        Issue Links

          Activity

            Code changed in jenkins
            User: Stefan Wolf
            Path:
            changelog.html
            core/src/main/resources/hudson/model/AbstractProject/main.jelly
            test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java
            http://jenkins-ci.org/commit/jenkins/dd6eab438f62313cc10278a59c7dace972bca433
            Log:
            Merge pull request #943 from wolfs/aggregate-test-result

            [FIXED JENKINS-9637] More Fixes for Aggregated Test Result

            Compare: https://github.com/jenkinsci/jenkins/compare/22693ab39dc1...dd6eab438f62

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Wolf Path: changelog.html core/src/main/resources/hudson/model/AbstractProject/main.jelly test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java http://jenkins-ci.org/commit/jenkins/dd6eab438f62313cc10278a59c7dace972bca433 Log: Merge pull request #943 from wolfs/aggregate-test-result [FIXED JENKINS-9637] More Fixes for Aggregated Test Result Compare: https://github.com/jenkinsci/jenkins/compare/22693ab39dc1...dd6eab438f62
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2882
            [FIXED JENKINS-9637] Make link on Job page to aggregated Test result appear correctly (Revision dd2b4a180582e4e8e6bdd8a511a457d201fce1ed)

            Result = SUCCESS
            Stefan Wolf : dd2b4a180582e4e8e6bdd8a511a457d201fce1ed
            Files :

            • test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java
            • core/src/main/resources/hudson/model/AbstractProject/main.jelly
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2882 [FIXED JENKINS-9637] Make link on Job page to aggregated Test result appear correctly (Revision dd2b4a180582e4e8e6bdd8a511a457d201fce1ed) Result = SUCCESS Stefan Wolf : dd2b4a180582e4e8e6bdd8a511a457d201fce1ed Files : test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java core/src/main/resources/hudson/model/AbstractProject/main.jelly

            Code changed in jenkins
            User: Stefan Wolf
            Path:
            core/src/main/resources/hudson/model/AbstractProject/main.jelly
            test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java
            test/src/test/java/hudson/tasks/test/helper/AbstractPage.java
            test/src/test/java/hudson/tasks/test/helper/AbstractTestResultLink.java
            test/src/test/java/hudson/tasks/test/helper/BuildPage.java
            test/src/test/java/hudson/tasks/test/helper/LatestTestResultLink.java
            test/src/test/java/hudson/tasks/test/helper/ProjectPage.java
            test/src/test/java/hudson/tasks/test/helper/TestResultLink.java
            test/src/test/java/hudson/tasks/test/helper/TestResultsPage.java
            test/src/test/resources/hudson/tasks/test/AggregatedTestResultPublisherTest.zip
            http://jenkins-ci.org/commit/jenkins/ee888cae3a483017ac3d37f2e4660c876b7e516e
            Log:
            [FIXED JENKINS-9637] Fixed the 404 when clicking the testResult on the Project Page when there is only an aggregated test result for a freestyle job. The name of the link is still wrong.

            (cherry picked from commit 629be4ab30d0d046d6839c07ba5de1b31d8e1feb)

            Conflicts:
            core/src/main/resources/hudson/model/AbstractProject/main.jelly

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Wolf Path: core/src/main/resources/hudson/model/AbstractProject/main.jelly test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java test/src/test/java/hudson/tasks/test/helper/AbstractPage.java test/src/test/java/hudson/tasks/test/helper/AbstractTestResultLink.java test/src/test/java/hudson/tasks/test/helper/BuildPage.java test/src/test/java/hudson/tasks/test/helper/LatestTestResultLink.java test/src/test/java/hudson/tasks/test/helper/ProjectPage.java test/src/test/java/hudson/tasks/test/helper/TestResultLink.java test/src/test/java/hudson/tasks/test/helper/TestResultsPage.java test/src/test/resources/hudson/tasks/test/AggregatedTestResultPublisherTest.zip http://jenkins-ci.org/commit/jenkins/ee888cae3a483017ac3d37f2e4660c876b7e516e Log: [FIXED JENKINS-9637] Fixed the 404 when clicking the testResult on the Project Page when there is only an aggregated test result for a freestyle job. The name of the link is still wrong. (cherry picked from commit 629be4ab30d0d046d6839c07ba5de1b31d8e1feb) Conflicts: core/src/main/resources/hudson/model/AbstractProject/main.jelly

            Code changed in jenkins
            User: Stefan Wolf
            Path:
            test/src/test/java/hudson/tasks/test/helper/AbstractTestResultLink.java
            http://jenkins-ci.org/commit/jenkins/410d1b9e77e07648e81862e31e3ca2db0115520c
            Log:
            [FIXED JENKINS-9637] Fixed the 404 when clicking the testResult on the Project Page when there is only an aggregated test result for a freestyle job. The name of the link is still wrong.

            (cherry picked from commit 58e8bd7a2eebe7e283386817ac67ff977b2b8e62)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Wolf Path: test/src/test/java/hudson/tasks/test/helper/AbstractTestResultLink.java http://jenkins-ci.org/commit/jenkins/410d1b9e77e07648e81862e31e3ca2db0115520c Log: [FIXED JENKINS-9637] Fixed the 404 when clicking the testResult on the Project Page when there is only an aggregated test result for a freestyle job. The name of the link is still wrong. (cherry picked from commit 58e8bd7a2eebe7e283386817ac67ff977b2b8e62)

            Code changed in jenkins
            User: Stefan Wolf
            Path:
            core/src/main/resources/hudson/model/AbstractProject/main.jelly
            test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java
            http://jenkins-ci.org/commit/jenkins/f53e3eceee9b28e30f94898221fcfcdd33e0f6bb
            Log:
            [FIXED JENKINS-9637] Make link on Job page to aggregated Test result appear correctly

            (cherry picked from commit dd2b4a180582e4e8e6bdd8a511a457d201fce1ed)

            Conflicts:
            core/src/main/resources/hudson/model/AbstractProject/main.jelly

            Compare: https://github.com/jenkinsci/jenkins/compare/33ad058fae24...f53e3eceee9b

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Wolf Path: core/src/main/resources/hudson/model/AbstractProject/main.jelly test/src/test/java/hudson/tasks/test/AggregatedTestResultPublisherTest.java http://jenkins-ci.org/commit/jenkins/f53e3eceee9b28e30f94898221fcfcdd33e0f6bb Log: [FIXED JENKINS-9637] Make link on Job page to aggregated Test result appear correctly (cherry picked from commit dd2b4a180582e4e8e6bdd8a511a457d201fce1ed) Conflicts: core/src/main/resources/hudson/model/AbstractProject/main.jelly Compare: https://github.com/jenkinsci/jenkins/compare/33ad058fae24...f53e3eceee9b

            People

              abayer Andrew Bayer
              fredg Fred G
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: