• Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • promoted-builds-plugin
    • None
    • RH 5.5
      Jenkins 1.411
      Jenkins promoted builds 2.1

      I am able to do manual promotions even if the build failed. Not sure if this is a bug or a feature request.

          [JENKINS-9719] Promotions are allowed on failed builds

          Lukasz Tasz added a comment -

          I would say this is a feature, even if your testing is failing, you should have a possibility to pass/promote/publish build to project.
          I would vote to reject this ticket

          Lukasz Tasz added a comment - I would say this is a feature, even if your testing is failing, you should have a possibility to pass/promote/publish build to project. I would vote to reject this ticket

          Sasha Unknown added a comment - - edited

          I think, it's feature.

          “Criteria” in the config are joined with the logical conjunction (AND) operator. So, if you wish, you can enable two criteria at once:

          • (1) “Promote immediately once the build is complete” — despite its name, it actually implies only successful builds.
          • (2) “Only when manually approved”.

          In this way, a build will be promoted only when both the the following is true: (1) build was successful, (2) manual promotion button was clicked. (A user can click manual promotion even if the build was unsuccessful, but it won't cause actual promotion, because #1 is false.)

          Still, it think it can be improved:

          • Criteria could be given more reasonable names. For example, I would rename the “Promote immediately once the build is complete” to “Only successful builds”. (The “promote immediately once the build is complete” name may look clear if user selects only one criterion, but user may select multiple and the it gives “promote immediately once the build is complete” name absolutely no clue how the criterion will interact with other criteria.)
          • “Only when manually approved” could have an option “Show/enable the button only when the following (other) criteria are met”. (This would allow not only to “ignore” clicking the button but also to hide/disable the button in specific cases.)

          Sasha Unknown added a comment - - edited I think, it's feature. “Criteria” in the config are joined with the logical conjunction (AND) operator . So, if you wish, you can enable two criteria at once: (1) “Promote immediately once the build is complete” — despite its name, it actually implies only successful builds . (2) “Only when manually approved”. In this way, a build will be promoted only when both the the following is true: (1) build was successful, (2) manual promotion button was clicked. (A user can click manual promotion even if the build was unsuccessful, but it won't cause actual promotion, because #1 is false.) Still, it think it can be improved: Criteria could be given more reasonable names. For example, I would rename the “Promote immediately once the build is complete” to “Only successful builds”. (The “promote immediately once the build is complete” name may look clear if user selects only one criterion, but user may select multiple and the it gives “promote immediately once the build is complete” name absolutely no clue how the criterion will interact with other criteria.) “Only when manually approved” could have an option “Show/enable the button only when the following (other) criteria are met”. (This would allow not only to “ignore” clicking the button but also to hide/disable the button in specific cases.)

            Unassigned Unassigned
            winslowcat Praveen Haldipur
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: