Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1031

Log messages on changes page do not wrap.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      Subversion commit messages do not wrap if they do not contain line breaks.
      When rendered as HTML, all of the spaces are replaced with  , which
      prevents the wrapping. I don't think this is particularly useful behaviour
      since it means lots of horizontal scrolling when the message is long.

        Attachments

          Activity

          Hide
          dwdyer dwdyer added a comment -

          Fixed in version 1.36 of Util.java. Modified the escape(String) method so that
          it doesn't replace spaces with HTML non-breaking space entities. Should be in
          Hudson 1.159.

          Show
          dwdyer dwdyer added a comment - Fixed in version 1.36 of Util.java. Modified the escape(String) method so that it doesn't replace spaces with HTML non-breaking space entities. Should be in Hudson 1.159.
          Hide
          kohsuke Kohsuke Kawaguchi added a comment -

          I agree that we should render Subversion commit messages to allow wrapping, but
          I have a problem with this change.

          I think Util.espcae should remain faithful conversion from ascii text to HTML.
          Not converting whitespace to   means consective whitespaces will be
          combined into one.

          I suggest we handle this differently. We should convert like:

          'abc def' -> 'abc def'
          'abc def' -> 'abc  def'
          'abc def' -> 'abc   def'
          'abc def' -> 'abc    def'
          'abc def' -> 'abc     def'

          In this way we can allow line wraps but without incorrectly trimming whitespaces.

          Show
          kohsuke Kohsuke Kawaguchi added a comment - I agree that we should render Subversion commit messages to allow wrapping, but I have a problem with this change. I think Util.espcae should remain faithful conversion from ascii text to HTML. Not converting whitespace to   means consective whitespaces will be combined into one. I suggest we handle this differently. We should convert like: 'abc def' -> 'abc def' 'abc def' -> 'abc  def' 'abc def' -> 'abc   def' 'abc def' -> 'abc    def' 'abc def' -> 'abc     def' In this way we can allow line wraps but without incorrectly trimming whitespaces.
          Hide
          dwdyer dwdyer added a comment -

          OK. I'll take a look at doing it the way that you suggest when I get some time
          later today.

          Show
          dwdyer dwdyer added a comment - OK. I'll take a look at doing it the way that you suggest when I get some time later today.
          Hide
          dwdyer dwdyer added a comment -

          I've just checked in a change (version 1.37 of Util.java) that implements the
          space-escaping as suggested. Tested locally and it seems fine.

          Show
          dwdyer dwdyer added a comment - I've just checked in a change (version 1.37 of Util.java) that implements the space-escaping as suggested. Tested locally and it seems fine.

            People

            Assignee:
            dwdyer dwdyer
            Reporter:
            dwdyer dwdyer
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: