proposed fix https://github.com/jenkinsci/promoted-builds-plugin/pull/14

This seems like a hack or workaround rather than a fix - why is there disabled promotion there to begin with? Shouldn't the old one be deleted when it's renamed?

Code changed in jenkins
User: Nicolas De Loof
Path:
src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
http://jenkins-ci.org/commit/promoted-builds-plugin/b0c0504e3d76b59389e72e6925ae15b5f93e8c70
Log:
[FIXED JENKINS-10423] don't run promotionProcess that are disabled

Code changed in jenkins
User: Stephen Connolly
Path:
src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java
http://jenkins-ci.org/commit/promoted-builds-plugin/b2f7cedb25664a5a85f075c99b14f674105360fc
Log:
Merge pull request #14 from ndeloof/master

fix for JENKINS-10423

Compare: https://github.com/jenkinsci/promoted-builds-plugin/compare/314089c...b2f7ced

Integrated in plugins_promoted-builds #57
[FIXED JENKINS-10423] don't run promotionProcess that are disabled

Nicolas De Loof :
Files :

• src/main/java/hudson/plugins/promoted_builds/PromotionProcess.java

@Jørgen

It depends on why the promotion process was renamed.

If the promotion process is renamed, you may want to retain the old promotions with the old name, or you may want to rename all the old promotions too. In reality JENKINS-8783 should be fixed by adding a three button confirm rather than [Yes]/[No] it should be [Rename process and all previous promotions of this process]/[Rename process leaving all previous promotions with the old name]/[No]

That would make it clear why/how you can have disabled processes left lying around after a rename IMHO

Oh, thanks Stephen, now it makes much more sense to me. I didn't realize that it leaves the old promotions with the old name when you rename. Thanks for the fix!

I'm seeing this happen again on v2.22 of this plugin.

We renamed a promotion process and it resulted in double stars. We changed the name back and added a 2nd identical promotion process with the new name and deleted the old one. Still results in double stars. This is happening with a job that is inside one of the new folders. I don't know if that makes a difference or not.

I saw this in v2.19. I thought updating to latest might fix it, but it continues to happen in v2.23.1. Like mpeters this is happening for a job in a folder.

This is not related to the usage of folders (the same problem exists without it).

Workaround:

• Open you job configuration
• Add new promotion with the previous name before the renaming. They can be empty. Myself I just checked "Promote immediately once the build is complete"
• Save your configuration
• Open you job configuration a second time
• Remove the promotion with the old name
• Save your configuration

Your job should now work correctly without breaking old promotions and the object model.

The issue will be fixed by JENKINS-27716 in promotion plugin > 2.23.1 if you are running on Jenkins >= 1.585