Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10423

Builds get double promotions after promotion has been renamed

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • promoted-builds-plugin
    • None
    • Jenkins ver. 1.421
      Jenkins Promoted Builds Plugin 2.2

      When a promotion is renamed, all subsequent promotions of the new name will also promote it with the old name.

      To reproduce, I did the following:

      1. Create a job test-downstream, leave all settings as-is.
      2. Create a job test-upstream, and set the following:
        • Promote builds when ...
          • Name: First promotion
          • When the following downstream projects build successfully: test-downstream
        • Post-build actions, build other projects: test-downstream
      3. Save settings, and then click Configure again.
      4. Change the name of the promotion from First promotion to Second promotion.
      5. Save.
      6. Run the build of test-upstream, wait for the build of test-upstream and test-downstream to complete (about 10s with quiet periods etc).

      Now you'll observe that the new build has two gold stars: First promotion and Second promotion. Going to /job/test-upstream/1/promotion/ will show First promotion as "Pending promotion" for some reason. It shouldn't be there at all!

          [JENKINS-10423] Builds get double promotions after promotion has been renamed

          Jørgen Tjernø created issue -
          Jørgen Tjernø made changes -
          Description Original: When a promotion is renamed, all subsequent promotions of the new name will also promote it with the old name.

          To reproduce, I did the following:
          Create a job test-downstream, leave all settings as-is.
          Create a job test-upstream, and set the following:
            Promote builds when ...
              Name: First promotion
              When the following downstream projects build successfully: test-downstream
            Post-build actions, build other projects: test-downstream

          Now save settings, and then click Configure again. Change First promotion to Second promotion and save. Run the build of test-upstream, wait for the build of test-upstream and test-downstream to complete (about 10s with quiet periods etc), observe that the new build has two gold stars: First promotion *and* Second promotion. Going to {{/job/test-upstream/1/promotion/}} will show First promotion as "Pending promotion" for some reason.
            
          New: When a promotion is renamed, all subsequent promotions of the new name will also promote it with the old name.

          To reproduce, I did the following:
          # Create a job test-downstream, leave all settings as-is.
          # Create a job test-upstream, and set the following:
          #* Promote builds when ...
          #** Name: ??First promotion??
          #** When the following downstream projects build successfully: ??test-downstream??
          #* Post-build actions, build other projects: ??test-downstream??
          # Save settings, and then click Configure again.
          # Change the name of the promotion from ??First promotion?? to ??Second promotion??.
          # Save.
          # Run the build of test-upstream, wait for the build of test-upstream and test-downstream to complete (about 10s with quiet periods etc).

          Now you'll observe that the new build has two gold stars: First promotion *and* Second promotion. Going to {{/job/test-upstream/1/promotion/}} will show First promotion as "Pending promotion" for some reason. It shouldn't be there at all!
          Nicolas De Loof made changes -
          Link New: This issue is related to JENKINS-8783 [ JENKINS-8783 ]
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          Michael Peters made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]
          Arnaud Héritier made changes -
          Link New: This issue is related to JENKINS-12799 [ JENKINS-12799 ]
          Arnaud Héritier made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Reopened [ 4 ] New: Resolved [ 5 ]
          Arnaud Héritier made changes -
          Link New: This issue is related to JENKINS-27716 [ JENKINS-27716 ]
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 140615 ] New: JNJira + In-Review [ 189154 ]

            Unassigned Unassigned
            jorgenpt Jørgen Tjernø
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: