Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10423

Builds get double promotions after promotion has been renamed

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • promoted-builds-plugin
    • None
    • Jenkins ver. 1.421
      Jenkins Promoted Builds Plugin 2.2

    Description

      When a promotion is renamed, all subsequent promotions of the new name will also promote it with the old name.

      To reproduce, I did the following:

      1. Create a job test-downstream, leave all settings as-is.
      2. Create a job test-upstream, and set the following:
        • Promote builds when ...
          • Name: First promotion
          • When the following downstream projects build successfully: test-downstream
        • Post-build actions, build other projects: test-downstream
      3. Save settings, and then click Configure again.
      4. Change the name of the promotion from First promotion to Second promotion.
      5. Save.
      6. Run the build of test-upstream, wait for the build of test-upstream and test-downstream to complete (about 10s with quiet periods etc).

      Now you'll observe that the new build has two gold stars: First promotion and Second promotion. Going to /job/test-upstream/1/promotion/ will show First promotion as "Pending promotion" for some reason. It shouldn't be there at all!

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27716 Copying A Job With Promotions and Renaming New Promotion Causes Phantom Promotions

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-8783 Renamin promotion process doesn't remove the original promotion process

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-12799 When project configuration is changed, Promoted Builds Plugin continues to use "old" configuration data

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            jorgenpt Jørgen Tjernø created issue -
            jorgenpt Jørgen Tjernø made changes -
            Field Original Value New Value
            Description When a promotion is renamed, all subsequent promotions of the new name will also promote it with the old name.

            To reproduce, I did the following:
            Create a job test-downstream, leave all settings as-is.
            Create a job test-upstream, and set the following:
              Promote builds when ...
                Name: First promotion
                When the following downstream projects build successfully: test-downstream
              Post-build actions, build other projects: test-downstream

            Now save settings, and then click Configure again. Change First promotion to Second promotion and save. Run the build of test-upstream, wait for the build of test-upstream and test-downstream to complete (about 10s with quiet periods etc), observe that the new build has two gold stars: First promotion *and* Second promotion. Going to {{/job/test-upstream/1/promotion/}} will show First promotion as "Pending promotion" for some reason.
                           		When a promotion is renamed, all subsequent promotions of the new name will also promote it with the old name.

            To reproduce, I did the following:
            # Create a job test-downstream, leave all settings as-is.
            # Create a job test-upstream, and set the following:
            #* Promote builds when ...
            #** Name: ??First promotion??
            #** When the following downstream projects build successfully: ??test-downstream??
            #* Post-build actions, build other projects: ??test-downstream??
            # Save settings, and then click Configure again.
            # Change the name of the promotion from ??First promotion?? to ??Second promotion??.
            # Save.
            # Run the build of test-upstream, wait for the build of test-upstream and test-downstream to complete (about 10s with quiet periods etc).

            Now you'll observe that the new build has two gold stars: First promotion *and* Second promotion. Going to {{/job/test-upstream/1/promotion/}} will show First promotion as "Pending promotion" for some reason. It shouldn't be there at all!
            ndeloof Nicolas De Loof made changes -
            Link This issue is related to JENKINS-8783 [ JENKINS-8783 ]
            scm_issue_link SCM/JIRA link daemon made changes -
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Resolved [ 5 ]
            mpeters Michael Peters made changes -
            Resolution Fixed [ 1 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            aheritier Arnaud Héritier made changes -
            Link This issue is related to JENKINS-12799 [ JENKINS-12799 ]
            aheritier Arnaud Héritier made changes -
            Resolution Fixed [ 1 ]
            Status Reopened [ 4 ] Resolved [ 5 ]
            aheritier Arnaud Héritier made changes -
            Link This issue is related to JENKINS-27716 [ JENKINS-27716 ]
            rtyler R. Tyler Croy made changes -
            Workflow JNJira [ 140615 ] JNJira + In-Review [ 189154 ]

            People

              Unassigned Unassigned
              jorgenpt Jørgen Tjernø
              Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: