Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10675

Jenkins redirecting from https to http

XMLWordPrintable

      (Sorry – I'm not sure what component this falls under)

      I have a ssl proxy on another machine in front of jenkins. The ssl proxy listens on port 8080 and forwards to Jenkins on port 8080.

      After I submit my login details to Jenkins on https://domain.com:8080/login, it redirects me to http://domain.com:8080. I'd like to stay on https. I've configured the Jenkins URL to be https://domain.com:8080, but it didn't seem to make a difference.

      Two solutions?

      1. Never change the protocol. If the redirect was to '/' instead of 'http://domain.com', there would be no problem.
      2. The proxy adds a X-Forwarded-Proto to each request – could Jenkins look at that and realize it's a https request?

          [JENKINS-10675] Jenkins redirecting from https to http

          Joe Van Dyk created issue -

          Johno Crawford added a comment -

          What SSL proxy are you running? If you have Apache try enabling ProxyPreserveHost.

          Johno Crawford added a comment - What SSL proxy are you running? If you have Apache try enabling ProxyPreserveHost.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ian Hopkins
          Path:
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/test/java/jenkins/model/JenkinsGetRootUrlTest.java
          http://jenkins-ci.org/commit/jenkins/ddfa65fae64663cda51a7b9dd7b45eeebbd10eda
          Log:
          [FIXED JENKINS-10675] use X-Forwarded-Proto if present

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ian Hopkins Path: core/src/main/java/jenkins/model/Jenkins.java core/src/test/java/jenkins/model/JenkinsGetRootUrlTest.java http://jenkins-ci.org/commit/jenkins/ddfa65fae64663cda51a7b9dd7b45eeebbd10eda Log: [FIXED JENKINS-10675] use X-Forwarded-Proto if present
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Vojtěch Juránek
          Path:
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/test/java/jenkins/model/JenkinsGetRootUrlTest.java
          http://jenkins-ci.org/commit/jenkins/5c25cb6a1b3d5640a2c42c2ebd2ca6343ffd3d2f
          Log:
          Merge pull request #964 from edenrox/master

          [FIXED JENKINS-10675] use X-Forwarded-Proto if present

          Compare: https://github.com/jenkinsci/jenkins/compare/2b9347a00227...5c25cb6a1b3d

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Vojtěch Juránek Path: core/src/main/java/jenkins/model/Jenkins.java core/src/test/java/jenkins/model/JenkinsGetRootUrlTest.java http://jenkins-ci.org/commit/jenkins/5c25cb6a1b3d5640a2c42c2ebd2ca6343ffd3d2f Log: Merge pull request #964 from edenrox/master [FIXED JENKINS-10675] use X-Forwarded-Proto if present Compare: https://github.com/jenkinsci/jenkins/compare/2b9347a00227...5c25cb6a1b3d

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2917
          [FIXED JENKINS-10675] use X-Forwarded-Proto if present (Revision ddfa65fae64663cda51a7b9dd7b45eeebbd10eda)

          Result = SUCCESS
          ian : ddfa65fae64663cda51a7b9dd7b45eeebbd10eda
          Files :

          • core/src/test/java/jenkins/model/JenkinsGetRootUrlTest.java
          • core/src/main/java/jenkins/model/Jenkins.java

          dogfood added a comment - Integrated in jenkins_main_trunk #2917 [FIXED JENKINS-10675] use X-Forwarded-Proto if present (Revision ddfa65fae64663cda51a7b9dd7b45eeebbd10eda) Result = SUCCESS ian : ddfa65fae64663cda51a7b9dd7b45eeebbd10eda Files : core/src/test/java/jenkins/model/JenkinsGetRootUrlTest.java core/src/main/java/jenkins/model/Jenkins.java
          Daniel Beck made changes -
          Labels New: lts-candidate

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ian Hopkins
          Path:
          core/src/main/java/jenkins/model/Jenkins.java
          core/src/test/java/jenkins/model/JenkinsGetRootUrlTest.java
          http://jenkins-ci.org/commit/jenkins/2235fcd90526f1e22de114973da4d08fd1df777f
          Log:
          [FIXED JENKINS-10675] use X-Forwarded-Proto if present

          (cherry picked from commit ddfa65fae64663cda51a7b9dd7b45eeebbd10eda)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ian Hopkins Path: core/src/main/java/jenkins/model/Jenkins.java core/src/test/java/jenkins/model/JenkinsGetRootUrlTest.java http://jenkins-ci.org/commit/jenkins/2235fcd90526f1e22de114973da4d08fd1df777f Log: [FIXED JENKINS-10675] use X-Forwarded-Proto if present (cherry picked from commit ddfa65fae64663cda51a7b9dd7b45eeebbd10eda)
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 1.532.1-fixed

          Luis Arias added a comment -

          I'm seeing this behavior when offloading SSL to an ELB with

          https://mydomain.net -> http://jenkins-instance:9090

          Could I be missing a configuration setting somewhere ? This is on 1.558.

          Thanks!

          Luis Arias added a comment - I'm seeing this behavior when offloading SSL to an ELB with https://mydomain.net -> http://jenkins-instance:9090 Could I be missing a configuration setting somewhere ? This is on 1.558. Thanks!

            Unassigned Unassigned
            joevandyk Joe Van Dyk
            Votes:
            4 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved: