Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1080

hudson.model.Resource.isCollidingWith() is broken

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: other
    • Labels:
      None
    • Environment:
      Platform: All, OS: Windows XP
    • Similar Issues:

      Description

      I think there is a bug or two in the resource code.

      Resource a = new Resource("a name");

      ResourceList x = new ResourceList();
      ResourceList y = new ResourceList();

      x.w(a);
      y.r(a);

      assertTrue("Read-Write conflict should colide, x.isConflictingWith); // this
      will fail

      y = new ResourceList();
      y.w(a);

      assertTrue("Write-Write conflict (when only 1 concurrent writer is permitted)
      should colide", x.isConflictingWith); // this will fail

      There are others!

      I have checked in a JUnit test with some of the failure modes that I think there
      are.

      I tried some simple quick fixes to the Resource code but could not get it to
      work within the time I can spend on it.

      -Stephen

        Attachments

          Activity

          Show
          kohsuke Kohsuke Kawaguchi added a comment - Fixed in 1.161. Also see the relevant thread at http://www.nabble.com/Hudson-build-became-unstable-3A-Hudson--C2-BB-Hudson-core--203-to14251520.html

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: