[JENKINS-11062] thinBackup nextBuildNumber

Type: Improvement
Resolution: Fixed
Priority: Major
Component/s: thinbackup-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

backup was done on Debian 6.0/ amd64 / Jenkins 1.420, restore on Debian 6.0 / VMWare i386 / Jenkins 1.430 both backup and restore with thinBackup 1.4
A new build for a given project (been backuped with last version #n) will not build as version #n+1 but as build #1.
ThinBackup do not backup the nextBuildNumber (because it is in the workspace)
I propose to include in the backup the nexBuildNumber, in order to be able to restore a functional backup.

Thomas Fürer added a comment - 2011-09-20 16:24

As we implement the strategy we thought that it could be a problem to backup/restore the buildnumber. A build number must be unique in any case to prevent troubles. In the case if you restore a older backuped configuration you get in the situation that you uses a number twice. So we need to secure that a number is not used twice.

Maybe the solution is to allow a backup/restore but check that the build number is greater or equal the current on. So a already used buildnumber cannot be used twice.

Thomas Fürer added a comment - 2011-09-20 16:24 As we implement the strategy we thought that it could be a problem to backup/restore the buildnumber. A build number must be unique in any case to prevent troubles. In the case if you restore a older backuped configuration you get in the situation that you uses a number twice. So we need to secure that a number is not used twice. Maybe the solution is to allow a backup/restore but check that the build number is greater or equal the current on. So a already used buildnumber cannot be used twice.

Thomas Fürer added a comment - 2011-10-03 18:41

Integrated in thinBackup #22

correct scope to test for mockito
~~JENKINS-11062~~: restore nextBuildNumber only if greater than current

tofuatjava : 39934
Files :

/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java
/trunk/hudson/plugins/thinBackup/pom.xml

Thomas Fürer added a comment - 2011-10-03 18:41 Integrated in thinBackup #22 correct scope to test for mockito JENKINS-11062 : restore nextBuildNumber only if greater than current tofuatjava : 39934 Files : /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java /trunk/hudson/plugins/thinBackup/pom.xml

Thomas Fürer added a comment - 2011-11-11 18:57

is fixed in the up comming release
please verify and close or reopen the issue
thanks

Thomas Fürer added a comment - 2011-11-11 18:57 is fixed in the up comming release please verify and close or reopen the issue thanks

Thomas Fürer added a comment - 2011-11-12 11:33

Integrated in thinBackup #23

modify pom.xml to enable new m2e eclipse plugin
~~JENKINS-11062~~: fix broken tests and adopt help text (Revision 40112)

Result = FAILURE
tofuatjava : 40112
Files :

/trunk/hudson/plugins/thinBackup/pom.xml
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/DirectoryCleaner.java
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java
/trunk/hudson/plugins/thinBackup/src/main/webapp/help/help-backupNextBuildNumber.html
/trunk/hudson/plugins/thinBackup/src/test/java/org/jvnet/hudson/plugins/thinbackup/FileCollector.java
/trunk/hudson/plugins/thinBackup/src/test/java/org/jvnet/hudson/plugins/thinbackup/restore/TestHudsonRestore.java

Thomas Fürer added a comment - 2011-11-12 11:33 Integrated in thinBackup #23 modify pom.xml to enable new m2e eclipse plugin JENKINS-11062 : fix broken tests and adopt help text (Revision 40112) Result = FAILURE tofuatjava : 40112 Files : /trunk/hudson/plugins/thinBackup/pom.xml /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/DirectoryCleaner.java /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java /trunk/hudson/plugins/thinBackup/src/main/webapp/help/help-backupNextBuildNumber.html /trunk/hudson/plugins/thinBackup/src/test/java/org/jvnet/hudson/plugins/thinbackup/FileCollector.java /trunk/hudson/plugins/thinBackup/src/test/java/org/jvnet/hudson/plugins/thinbackup/restore/TestHudsonRestore.java

Thomas Fürer added a comment - 2011-11-12 11:57

Integrated in thinBackup #25

modify pom.xml to enable new m2e eclipse plugin
~~JENKINS-11062~~: fix broken tests and adopt help text (Revision 40112)

Result = SUCCESS
tofuatjava : 40112
Files :

/trunk/hudson/plugins/thinBackup/pom.xml
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/DirectoryCleaner.java
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java
/trunk/hudson/plugins/thinBackup/src/main/webapp/help/help-backupNextBuildNumber.html
/trunk/hudson/plugins/thinBackup/src/test/java/org/jvnet/hudson/plugins/thinbackup/FileCollector.java
/trunk/hudson/plugins/thinBackup/src/test/java/org/jvnet/hudson/plugins/thinbackup/restore/TestHudsonRestore.java

Thomas Fürer added a comment - 2011-11-12 11:57 Integrated in thinBackup #25 modify pom.xml to enable new m2e eclipse plugin JENKINS-11062 : fix broken tests and adopt help text (Revision 40112) Result = SUCCESS tofuatjava : 40112 Files : /trunk/hudson/plugins/thinBackup/pom.xml /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/DirectoryCleaner.java /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java /trunk/hudson/plugins/thinBackup/src/main/webapp/help/help-backupNextBuildNumber.html /trunk/hudson/plugins/thinBackup/src/test/java/org/jvnet/hudson/plugins/thinbackup/FileCollector.java /trunk/hudson/plugins/thinBackup/src/test/java/org/jvnet/hudson/plugins/thinbackup/restore/TestHudsonRestore.java

SCM/JIRA link daemon added a comment - 2012-11-09 11:21

Code changed in jenkins
User: tofuatgit
Path:
pom.xml
src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java
http://jenkins-ci.org/commit/thin-backup-plugin/0317fbdb7b6432edfa1b68b9c897414251ae23bd
Log:

correct scope to test for mockito
~~JENKINS-11062~~: restore nextBuildNumber only if greater than current

git-svn-id: https://svn.jenkins-ci.org/trunk/hudson/plugins/thinBackup@39934 71c3de6d-444a-0410-be80-ed276b4c234a

SCM/JIRA link daemon added a comment - 2012-11-09 11:21 Code changed in jenkins User: tofuatgit Path: pom.xml src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java http://jenkins-ci.org/commit/thin-backup-plugin/0317fbdb7b6432edfa1b68b9c897414251ae23bd Log: correct scope to test for mockito JENKINS-11062 : restore nextBuildNumber only if greater than current git-svn-id: https://svn.jenkins-ci.org/trunk/hudson/plugins/thinBackup@39934 71c3de6d-444a-0410-be80-ed276b4c234a

SCM/JIRA link daemon added a comment - 2012-11-09 11:21

Code changed in jenkins
User: tofuatgit
Path:
pom.xml
src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java
src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/DirectoryCleaner.java
src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java
src/main/webapp/help/help-backupNextBuildNumber.html
src/test/java/org/jvnet/hudson/plugins/thinbackup/FileCollector.java
src/test/java/org/jvnet/hudson/plugins/thinbackup/restore/TestHudsonRestore.java
http://jenkins-ci.org/commit/thin-backup-plugin/2eb9740474f59b29ed22ff86551d7c7dc90a8e07
Log:

modify pom.xml to enable new m2e eclipse plugin
~~JENKINS-11062~~: fix broken tests and adopt help text

git-svn-id: https://svn.jenkins-ci.org/trunk/hudson/plugins/thinBackup@40112 71c3de6d-444a-0410-be80-ed276b4c234a

SCM/JIRA link daemon added a comment - 2012-11-09 11:21 Code changed in jenkins User: tofuatgit Path: pom.xml src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupMgmtLink.java src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java src/main/java/org/jvnet/hudson/plugins/thinbackup/backup/DirectoryCleaner.java src/main/java/org/jvnet/hudson/plugins/thinbackup/restore/HudsonRestore.java src/main/webapp/help/help-backupNextBuildNumber.html src/test/java/org/jvnet/hudson/plugins/thinbackup/FileCollector.java src/test/java/org/jvnet/hudson/plugins/thinbackup/restore/TestHudsonRestore.java http://jenkins-ci.org/commit/thin-backup-plugin/2eb9740474f59b29ed22ff86551d7c7dc90a8e07 Log: modify pom.xml to enable new m2e eclipse plugin JENKINS-11062 : fix broken tests and adopt help text git-svn-id: https://svn.jenkins-ci.org/trunk/hudson/plugins/thinBackup@40112 71c3de6d-444a-0410-be80-ed276b4c234a

Assignee:: Stephane Winnepenninckx

Reporter:: Stephane Winnepenninckx

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Created:: 2011-09-20 12:00

Updated:: 2012-11-09 11:21

Resolved:: 2011-11-11 18:57

Jenkins

Details

Description

Attachments

Activity

Collapse comment: Thomas Fürer added a comment - 2011-09-20 16:24

Expand comment: Thomas Fürer added a comment - 2011-09-20 16:24

Collapse comment: Thomas Fürer added a comment - 2011-10-03 18:41

Expand comment: Thomas Fürer added a comment - 2011-10-03 18:41

Collapse comment: Thomas Fürer added a comment - 2011-11-11 18:57

Expand comment: Thomas Fürer added a comment - 2011-11-11 18:57

Collapse comment: Thomas Fürer added a comment - 2011-11-12 11:33

Expand comment: Thomas Fürer added a comment - 2011-11-12 11:33

Collapse comment: Thomas Fürer added a comment - 2011-11-12 11:57

Expand comment: Thomas Fürer added a comment - 2011-11-12 11:57

Collapse comment: SCM/JIRA link daemon added a comment - 2012-11-09 11:21

Expand comment: SCM/JIRA link daemon added a comment - 2012-11-09 11:21

Collapse comment: SCM/JIRA link daemon added a comment - 2012-11-09 11:21

Expand comment: SCM/JIRA link daemon added a comment - 2012-11-09 11:21

People

Dates