Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11068

Port on HTTP Proxy Configure accepts characters except the digits

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None
    • OS: Windows Server 2008 R2 Enterprise SP1

      There is no check for Port on HTTP Proxy Configure.
      So, it accepts characters except the digits.

      When we enter some string(ex. port_number) for Port, Jenkins shows the following stack trace.

      java.lang.IllegalArgumentException: Invalid proxy port: sample_port
      at hudson.PluginManager.doProxyConfigure(PluginManager.java:564)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
      at java.lang.reflect.Method.invoke(Unknown Source)
      at org.kohsuke.stapler.Function$InstanceFunction.invoke(Function.java:282)
      at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:149)
      at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:88)
      at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:103)
      at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
      at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:561)
      at org.kohsuke.stapler.Stapler.invoke(Stapler.java:646)
      at org.kohsuke.stapler.MetaClass$3.doDispatch(MetaClass.java:167)
      at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:53)
      at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:561)
      at org.kohsuke.stapler.Stapler.invoke(Stapler.java:646)
      at org.kohsuke.stapler.Stapler.invoke(Stapler.java:477)
      at org.kohsuke.stapler.Stapler.service(Stapler.java:159)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:45)
      at winstone.ServletConfiguration.execute(ServletConfiguration.java:249)
      at winstone.RequestDispatcher.forward(RequestDispatcher.java:335)
      at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:378)
      at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:94)
      at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:86)
      at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
      at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
      at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:47)
      at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
      at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
      at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84)
      at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:76)
      at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:164)
      at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
      at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
      at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:81)
      at winstone.FilterConfiguration.execute(FilterConfiguration.java:195)
      at winstone.RequestDispatcher.doFilter(RequestDispatcher.java:368)
      at winstone.RequestDispatcher.forward(RequestDispatcher.java:333)
      at winstone.RequestHandlerThread.processRequest(RequestHandlerThread.java:244)
      at winstone.RequestHandlerThread.run(RequestHandlerThread.java:150)
      at java.lang.Thread.run(Unknown Source)
      Caused by: java.lang.NumberFormatException: For input string: "sample_port"
      at java.lang.NumberFormatException.forInputString(Unknown Source)
      at java.lang.Integer.parseInt(Unknown Source)
      at java.lang.Integer.parseInt(Unknown Source)
      at hudson.PluginManager.doProxyConfigure(PluginManager.java:560)
      ... 40 more

          [JENKINS-11068] Port on HTTP Proxy Configure accepts characters except the digits

          Code changed in jenkins
          User: Seiji Sogabe
          Path:
          changelog.html
          core/src/main/java/hudson/PluginManager.java
          core/src/main/resources/hudson/Messages.properties
          core/src/main/resources/hudson/Messages_ja.properties
          core/src/main/resources/hudson/PluginManager/advanced.jelly
          http://jenkins-ci.org/commit/jenkins/96fa4c4bab90e4908f86be57cc604778a5cc878c
          Log:
          [FIXED JENKINS-11068] Port on HTTP Proxy Configure accepts characters except the digits

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Seiji Sogabe Path: changelog.html core/src/main/java/hudson/PluginManager.java core/src/main/resources/hudson/Messages.properties core/src/main/resources/hudson/Messages_ja.properties core/src/main/resources/hudson/PluginManager/advanced.jelly http://jenkins-ci.org/commit/jenkins/96fa4c4bab90e4908f86be57cc604778a5cc878c Log: [FIXED JENKINS-11068] Port on HTTP Proxy Configure accepts characters except the digits

          dogfood added a comment -

          Integrated in jenkins_main_trunk #1142
          [FIXED JENKINS-11068] Port on HTTP Proxy Configure accepts characters except the digits

          Seiji Sogabe : 96fa4c4bab90e4908f86be57cc604778a5cc878c
          Files :

          • core/src/main/resources/hudson/Messages_ja.properties
          • core/src/main/java/hudson/PluginManager.java
          • core/src/main/resources/hudson/PluginManager/advanced.jelly
          • changelog.html
          • core/src/main/resources/hudson/Messages.properties

          dogfood added a comment - Integrated in jenkins_main_trunk #1142 [FIXED JENKINS-11068] Port on HTTP Proxy Configure accepts characters except the digits Seiji Sogabe : 96fa4c4bab90e4908f86be57cc604778a5cc878c Files : core/src/main/resources/hudson/Messages_ja.properties core/src/main/java/hudson/PluginManager.java core/src/main/resources/hudson/PluginManager/advanced.jelly changelog.html core/src/main/resources/hudson/Messages.properties

          Code changed in jenkins
          User: Seiji Sogabe
          Path:
          core/src/main/java/hudson/PluginManager.java
          http://jenkins-ci.org/commit/jenkins/5b3990e5e30630b9a2950fa846ef3e906c86d743
          Log:
          JENKINS-11068 Do not check if port is not entered.

          Compare: https://github.com/jenkinsci/jenkins/compare/f67476c...5b3990e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Seiji Sogabe Path: core/src/main/java/hudson/PluginManager.java http://jenkins-ci.org/commit/jenkins/5b3990e5e30630b9a2950fa846ef3e906c86d743 Log: JENKINS-11068 Do not check if port is not entered. Compare: https://github.com/jenkinsci/jenkins/compare/f67476c...5b3990e

          dogfood added a comment -

          Integrated in jenkins_main_trunk #1143
          JENKINS-11068 Do not check if port is not entered.

          Seiji Sogabe : 5b3990e5e30630b9a2950fa846ef3e906c86d743
          Files :

          • core/src/main/java/hudson/PluginManager.java

          dogfood added a comment - Integrated in jenkins_main_trunk #1143 JENKINS-11068 Do not check if port is not entered. Seiji Sogabe : 5b3990e5e30630b9a2950fa846ef3e906c86d743 Files : core/src/main/java/hudson/PluginManager.java

          Code changed in jenkins
          User: Seiji Sogabe
          Path:
          changelog.html
          core/src/main/java/hudson/PluginManager.java
          core/src/main/resources/hudson/Messages.properties
          core/src/main/resources/hudson/Messages_ja.properties
          core/src/main/resources/hudson/PluginManager/advanced.jelly
          http://jenkins-ci.org/commit/jenkins/96fa4c4bab90e4908f86be57cc604778a5cc878c
          Log:
          [FIXED JENKINS-11068] Port on HTTP Proxy Configure accepts characters except the digits

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Seiji Sogabe Path: changelog.html core/src/main/java/hudson/PluginManager.java core/src/main/resources/hudson/Messages.properties core/src/main/resources/hudson/Messages_ja.properties core/src/main/resources/hudson/PluginManager/advanced.jelly http://jenkins-ci.org/commit/jenkins/96fa4c4bab90e4908f86be57cc604778a5cc878c Log: [FIXED JENKINS-11068] Port on HTTP Proxy Configure accepts characters except the digits

            sogabe sogabe
            yonezawah Hiroki Yonezawa
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: