Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11116

Non-deterministic log output if multiple trigger configs are used in one build step

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • parameterized-trigger-plugin version 2.10

      Steps to reproduce:

      Set up multiple (eg. six) blocking trigger builder configs in one trigger buildstep that each triggers a project (the first one triggers "project1", the second one triggers "project2", etc.)

      Expected console log output should be:

      Started by user SYSTEM
      Waiting for the completion of project1
      project1 #1 completed. Result was SUCCESS
      Waiting for the completion of project2
      project2 #1 completed. Result was SUCCESS
      Waiting for the completion of project3
      project3 #1 completed. Result was SUCCESS
      Waiting for the completion of project4
      project4 #1 completed. Result was SUCCESS
      Waiting for the completion of project5
      project5 #1 completed. Result was SUCCESS
      Waiting for the completion of project6
      project6 #1 completed. Result was SUCCESS
      Finished: SUCCESS
      

      Actual output is something like this:

      Started by user SYSTEM
      Waiting for the completion of project5
      project5 #1 completed. Result was SUCCESS
      Waiting for the completion of project1
      project1 #1 completed. Result was SUCCESS
      Waiting for the completion of project3
      project3 #1 completed. Result was SUCCESS
      Waiting for the completion of project2
      project2 #1 completed. Result was SUCCESS
      Waiting for the completion of project4
      project4 #1 completed. Result was SUCCESS
      Waiting for the completion of project6
      project6 #1 completed. Result was SUCCESS
      Finished: SUCCESS
      

      The order of the project's completion might actually depend on where they are executed (different slaves), different system loads, etc,
      but thats not the reason for the non-deterministic order of the projects in the console log. It's simply because all the configs are
      added to a hashmap before they are processed.
      I think it's more reasonable to show the projects in the log output in the same order they are defined.

          [JENKINS-11116] Non-deterministic log output if multiple trigger configs are used in one build step

          Fred G added a comment -

          Fred G added a comment - Pull-Request: https://github.com/jenkinsci/parameterized-trigger-plugin/pull/8

          Andrew Bayer added a comment -

          Merged in today (Dec 2 2012)

          Andrew Bayer added a comment - Merged in today (Dec 2 2012)

          dogfood added a comment -

          Integrated in plugins_parameterized-trigger #26
          [FIXED JENKINS-11116] and [FIXED JENKINS-11117] Order of completed

          Fred G :
          Files :

          • src/test/java/hudson/plugins/parameterizedtrigger/test/TriggerBuilderTest.java
          • src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java

          dogfood added a comment - Integrated in plugins_parameterized-trigger #26 [FIXED JENKINS-11116] and [FIXED JENKINS-11117] Order of completed Fred G : Files : src/test/java/hudson/plugins/parameterizedtrigger/test/TriggerBuilderTest.java src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          src/main/java/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig.java
          src/main/java/hudson/plugins/parameterizedtrigger/BuildTriggerConfig.java
          src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java
          src/test/java/hudson/plugins/parameterizedtrigger/test/TriggerBuilderTest.java
          http://jenkins-ci.org/commit/parameterized-trigger-plugin/320f7f0b4d5c12f585b5aada39006c406e8b3ef7
          Log:
          Merge pull request #8 from fredg02/master

          [FIXED JENKINS-11116] and [FIXED JENKINS-11117]

          Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/c8a57a2...320f7f0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/hudson/plugins/parameterizedtrigger/BlockableBuildTriggerConfig.java src/main/java/hudson/plugins/parameterizedtrigger/BuildTriggerConfig.java src/main/java/hudson/plugins/parameterizedtrigger/TriggerBuilder.java src/test/java/hudson/plugins/parameterizedtrigger/test/TriggerBuilderTest.java http://jenkins-ci.org/commit/parameterized-trigger-plugin/320f7f0b4d5c12f585b5aada39006c406e8b3ef7 Log: Merge pull request #8 from fredg02/master [FIXED JENKINS-11116] and [FIXED JENKINS-11117] Compare: https://github.com/jenkinsci/parameterized-trigger-plugin/compare/c8a57a2...320f7f0

            fredg Fred G
            fredg Fred G
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: