Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11419

Use the name set by the 'Build Name Setter' plugin in messages

    XMLWordPrintable

Details

    Description

      Hi,
      Would it be possible to update the plugin so that it uses the build name output by the build name setter plugin? We replace the build # with an SCM changelist/revision so it's much more meaningful to have that than a build number.
      FYI The email based notifier does use the output of the Name Setter plugin.

      Ta
      Andy

      Attachments

        Issue Links

          Activity

            kutzi kutzi added a comment -

            I can implement this. But there's one problem: the build start notification of the instant-messaging plugins is running before the build name setter plugin gets the chance to set the build name.
            So the name reported at build start is always the default name, while the one on build end is the customized name.

            I'm currently musing if this isn't a too confusing behaviour for users.

            kutzi kutzi added a comment - I can implement this. But there's one problem: the build start notification of the instant-messaging plugins is running before the build name setter plugin gets the chance to set the build name. So the name reported at build start is always the default name, while the one on build end is the customized name. I'm currently musing if this isn't a too confusing behaviour for users.
            abigos Andy Bigos added a comment -


            Maybe you could include both for the end report - e.g. keep the build# and put the build in name in parenthesis after it, or vice-versa.

            abigos Andy Bigos added a comment - Maybe you could include both for the end report - e.g. keep the build# and put the build in name in parenthesis after it, or vice-versa.
            kutzi kutzi added a comment -

            I guess, I'll just take whatever is available and wait if someone complains about the inconsistent behaviour

            After all, it only affects users which use the build name setter and have both of pre- and post-build notifications enabled.

            kutzi kutzi added a comment - I guess, I'll just take whatever is available and wait if someone complains about the inconsistent behaviour After all, it only affects users which use the build name setter and have both of pre- and post-build notifications enabled.
            abigos Andy Bigos added a comment -

            Sounds good! Thanks

            abigos Andy Bigos added a comment - Sounds good! Thanks

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/plugins/im/build_notify/DefaultBuildToChatNotifier.java
            src/main/java/hudson/plugins/im/build_notify/SummaryOnlyBuildToChatNotifier.java
            src/main/resources/hudson/plugins/im/build_notify/Messages.properties
            http://jenkins-ci.org/commit/instant-messaging-plugin/8241564a92d342259ae4c95b1467b45998fb0188
            Log:
            [FIXED JENKINS-11419] support custom build names

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/im/build_notify/DefaultBuildToChatNotifier.java src/main/java/hudson/plugins/im/build_notify/SummaryOnlyBuildToChatNotifier.java src/main/resources/hudson/plugins/im/build_notify/Messages.properties http://jenkins-ci.org/commit/instant-messaging-plugin/8241564a92d342259ae4c95b1467b45998fb0188 Log: [FIXED JENKINS-11419] support custom build names
            dogfood dogfood added a comment -

            Integrated in plugins_instant-messaging #98
            [FIXED JENKINS-11419] support custom build names

            Christoph Kutzinski :
            Files :

            • src/main/java/hudson/plugins/im/build_notify/SummaryOnlyBuildToChatNotifier.java
            • src/main/resources/hudson/plugins/im/build_notify/Messages.properties
            • src/main/java/hudson/plugins/im/build_notify/DefaultBuildToChatNotifier.java
            dogfood dogfood added a comment - Integrated in plugins_instant-messaging #98 [FIXED JENKINS-11419] support custom build names Christoph Kutzinski : Files : src/main/java/hudson/plugins/im/build_notify/SummaryOnlyBuildToChatNotifier.java src/main/resources/hudson/plugins/im/build_notify/Messages.properties src/main/java/hudson/plugins/im/build_notify/DefaultBuildToChatNotifier.java
            ozizka ozizka added a comment -

            So how does one customize the messages now? I think I need the same feature.

            ozizka ozizka added a comment - So how does one customize the messages now? I think I need the same feature.

            People

              kutzi kutzi
              abigos Andy Bigos
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: