• Icon: New Feature New Feature
    • Resolution: Unresolved
    • Icon: Major Major
    • p4-plugin
    • None

      email-ext looks for getDate getTimestamp and getRevision getCommitId methods using reflection when retrieving changelog information. Currently the perforce plugin does not implement these methods, so the date and change number are not available.

          [JENKINS-11600] Implement Entry functions for email-ext support

          Walter Couto added a comment -

          I can't tell the version as it is not reported in the emails, but it stopped working for us on October 30th, 2013. So recently. We keep up to date with the latest Jenkins and plugins. Our P4 server version hasn't changed between those dates.

          Walter Couto added a comment - I can't tell the version as it is not reported in the emails, but it stopped working for us on October 30th, 2013. So recently. We keep up to date with the latest Jenkins and plugins. Our P4 server version hasn't changed between those dates.

          Rob Petti added a comment -

          I'd recommend rolling back to see if it fixes your issue. As I've said, this doesn't appear to be an issue with the Perforce Plugin.

          Rob Petti added a comment - I'd recommend rolling back to see if it fixes your issue. As I've said, this doesn't appear to be an issue with the Perforce Plugin.

          Nik San added a comment -

          Any ideas on this or what version of Jenkins we should go back to? I'm a newcomer so unable to have ever seen it working (last two weeks) but am also seeing the null for revision.

          Cheers.

          Nik San added a comment - Any ideas on this or what version of Jenkins we should go back to? I'm a newcomer so unable to have ever seen it working (last two weeks) but am also seeing the null for revision. Cheers.

          Rob Petti added a comment -

          Email-ext has changed something on their end. It seems they are now using Entry.getTimestamp and Entry.getCommitId instead of getDate and getRevision like they were previously... The perforce plugin will need these two new functions implemented.

          Rob Petti added a comment - Email-ext has changed something on their end. It seems they are now using Entry.getTimestamp and Entry.getCommitId instead of getDate and getRevision like they were previously... The perforce plugin will need these two new functions implemented.

          Rob Petti added a comment -

          Updated ticket with details.

          Rob Petti added a comment - Updated ticket with details.

          Nik San added a comment -

          Nice one Rob. Also, probably not the place but thanks for a great plugin.

          Nik San added a comment - Nice one Rob. Also, probably not the place but thanks for a great plugin.

          Nik San added a comment -

          My first time using github and everything in relation to developing jenkins plugins, but I have a pull request for this.

          https://github.com/jenkinsci/perforce-plugin/pull/49

          Nik San added a comment - My first time using github and everything in relation to developing jenkins plugins, but I have a pull request for this. https://github.com/jenkinsci/perforce-plugin/pull/49

          Alex Earl added a comment -

          ChangeLogSet.Entry didn't have those methods and I didn't want to use reflection anymore. I missed checking perforce when I looked at the different SCM implementations. Apologies for the issue the change caused.

          Alex Earl added a comment - ChangeLogSet.Entry didn't have those methods and I didn't want to use reflection anymore. I missed checking perforce when I looked at the different SCM implementations. Apologies for the issue the change caused.

          Code changed in jenkins
          User: Paul Tankard
          Path:
          src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java
          http://jenkins-ci.org/commit/perforce-plugin/fda9b707c2fcc4afff0a37c6d83aa23451b6d3ca
          Log:
          Fix for JENKINS-11600, email-ext now queries getTimestamp and getCommitId

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Tankard Path: src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java http://jenkins-ci.org/commit/perforce-plugin/fda9b707c2fcc4afff0a37c6d83aa23451b6d3ca Log: Fix for JENKINS-11600 , email-ext now queries getTimestamp and getCommitId

          Code changed in jenkins
          User: Rob Petti
          Path:
          src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java
          http://jenkins-ci.org/commit/perforce-plugin/e49e9cb874d9536210aa9c90119c96ce50a1ad82
          Log:
          Merge pull request #49 from HexTank/master

          Fix for JENKINS-11600, email-ext now queries getTimestamp and getCommite...

          Compare: https://github.com/jenkinsci/perforce-plugin/compare/2da2bf91851f...e49e9cb874d9

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rob Petti Path: src/main/java/hudson/plugins/perforce/PerforceChangeLogEntry.java http://jenkins-ci.org/commit/perforce-plugin/e49e9cb874d9536210aa9c90119c96ce50a1ad82 Log: Merge pull request #49 from HexTank/master Fix for JENKINS-11600 , email-ext now queries getTimestamp and getCommite... Compare: https://github.com/jenkinsci/perforce-plugin/compare/2da2bf91851f...e49e9cb874d9

            Unassigned Unassigned
            rpetti Rob Petti
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated: