Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11606

configuration option for disabling the commands

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Major Major
    • ircbot-plugin
    • None

      As it was pointed out in https://issues.jenkins-ci.org/browse/JENKINS-5931 there is no option for restricting who can access what command, which can be a problem from the access control POV.
      I would suggest a more simpler solution: having the ability to disable the whole irc command interface, this way the irc notification can still be used without allowing unauthorized access to random people.
      I think this would be really easy to implement, and it would be a good-enough solution for most people.

          [JENKINS-11606] configuration option for disabling the commands

          kutzi added a comment -

          I like the idea

          kutzi added a comment - I like the idea

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/im/GroupChatIMMessageTarget.java
          src/main/java/hudson/plugins/im/IMChat.java
          src/main/java/hudson/plugins/im/bot/Bot.java
          http://jenkins-ci.org/commit/instant-messaging-plugin/a531942907f9fd2615a029092b27ebf154b57812
          Log:
          [FIXED JENKINS-11606]: configuration option to disable commands in chat rooms

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/im/GroupChatIMMessageTarget.java src/main/java/hudson/plugins/im/IMChat.java src/main/java/hudson/plugins/im/bot/Bot.java http://jenkins-ci.org/commit/instant-messaging-plugin/a531942907f9fd2615a029092b27ebf154b57812 Log: [FIXED JENKINS-11606] : configuration option to disable commands in chat rooms

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/ircbot/IrcPublisher.java
          src/main/java/hudson/plugins/ircbot/v2/IRCChannel.java
          src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java
          src/main/java/hudson/plugins/ircbot/v2/IRCPrivateChat.java
          src/main/resources/hudson/plugins/ircbot/IrcPublisher/config.jelly
          src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly
          http://jenkins-ci.org/commit/ircbot-plugin/ee5e974566395c01da714bec39e64ce515124b87
          Log:
          [FIXED JENKINS-11606]: configuration option to disable commands in chat rooms

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/ircbot/IrcPublisher.java src/main/java/hudson/plugins/ircbot/v2/IRCChannel.java src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java src/main/java/hudson/plugins/ircbot/v2/IRCPrivateChat.java src/main/resources/hudson/plugins/ircbot/IrcPublisher/config.jelly src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly http://jenkins-ci.org/commit/ircbot-plugin/ee5e974566395c01da714bec39e64ce515124b87 Log: [FIXED JENKINS-11606] : configuration option to disable commands in chat rooms

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/jabber/im/transport/JabberChat.java
          src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java
          src/main/java/hudson/plugins/jabber/im/transport/JabberMultiUserChat.java
          src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java
          src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly
          http://jenkins-ci.org/commit/jabber-plugin/f2ec60677324aafe38ca8a1568cf8ff3b297d354
          Log:
          [FIXED JENKINS-11606]: configuration option to disable commands in chat rooms

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/jabber/im/transport/JabberChat.java src/main/java/hudson/plugins/jabber/im/transport/JabberIMConnection.java src/main/java/hudson/plugins/jabber/im/transport/JabberMultiUserChat.java src/main/java/hudson/plugins/jabber/im/transport/JabberPublisherDescriptor.java src/main/resources/hudson/plugins/jabber/im/transport/JabberPublisher/global.jelly http://jenkins-ci.org/commit/jabber-plugin/f2ec60677324aafe38ca8a1568cf8ff3b297d354 Log: [FIXED JENKINS-11606] : configuration option to disable commands in chat rooms

          Ferenc Kovacs added a comment -

          \o/ thanks!
          any ETA relasing the next version?

          Ferenc Kovacs added a comment - \o/ thanks! any ETA relasing the next version?

          dogfood added a comment -

          Integrated in plugins_instant-messaging #103
          [FIXED JENKINS-11606]: configuration option to disable commands in chat rooms

          Christoph Kutzinski :
          Files :

          • src/main/java/hudson/plugins/im/GroupChatIMMessageTarget.java
          • src/main/java/hudson/plugins/im/bot/Bot.java
          • src/main/java/hudson/plugins/im/IMChat.java

          dogfood added a comment - Integrated in plugins_instant-messaging #103 [FIXED JENKINS-11606] : configuration option to disable commands in chat rooms Christoph Kutzinski : Files : src/main/java/hudson/plugins/im/GroupChatIMMessageTarget.java src/main/java/hudson/plugins/im/bot/Bot.java src/main/java/hudson/plugins/im/IMChat.java

          dogfood added a comment -

          Integrated in plugins_ircbot #125
          [FIXED JENKINS-11606]: configuration option to disable commands in chat rooms

          Christoph Kutzinski :
          Files :

          • src/main/java/hudson/plugins/ircbot/v2/IRCPrivateChat.java
          • src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly
          • src/main/java/hudson/plugins/ircbot/v2/IRCChannel.java
          • src/main/java/hudson/plugins/ircbot/IrcPublisher.java
          • src/main/resources/hudson/plugins/ircbot/IrcPublisher/config.jelly
          • src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java

          dogfood added a comment - Integrated in plugins_ircbot #125 [FIXED JENKINS-11606] : configuration option to disable commands in chat rooms Christoph Kutzinski : Files : src/main/java/hudson/plugins/ircbot/v2/IRCPrivateChat.java src/main/resources/hudson/plugins/ircbot/IrcPublisher/global.jelly src/main/java/hudson/plugins/ircbot/v2/IRCChannel.java src/main/java/hudson/plugins/ircbot/IrcPublisher.java src/main/resources/hudson/plugins/ircbot/IrcPublisher/config.jelly src/main/java/hudson/plugins/ircbot/v2/IRCConnection.java

          dogfood added a comment -

          Integrated in plugins_jabber #116

          dogfood added a comment - Integrated in plugins_jabber #116

          cforce added a comment - - edited

          How does this work?
          I found option to set globally "Initial group chats" with switch "Notification only".
          If i give users the right to configure/admin their jobs themself, then they also can enter any jabber room/user to be notified in job config. How can i then restrict to notication ony (no !bot control) for all rooms/users but for some be able to allow !bot control as Jenkins admin (in global config)?

          Please explain, can't find any helo for this new feature.

          cforce added a comment - - edited How does this work? I found option to set globally "Initial group chats" with switch "Notification only". If i give users the right to configure/admin their jobs themself, then they also can enter any jabber room/user to be notified in job config. How can i then restrict to notication ony (no !bot control) for all rooms/users but for some be able to allow !bot control as Jenkins admin (in global config)? Please explain, can't find any helo for this new feature.

            kutzi kutzi
            tyrael Ferenc Kovacs
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: