Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12061

When a build is in the queue, build history widget entry is missing the right border

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Attachments

        Activity

        Hide
        kohsuke Kohsuke Kawaguchi added a comment -

        This apparently has something to do with table border model being collapse.

        http://www.w3.org/TR/CSS2/tables.html#borders

        Show
        kohsuke Kohsuke Kawaguchi added a comment - This apparently has something to do with table border model being collapse. http://www.w3.org/TR/CSS2/tables.html#borders
        Hide
        kohsuke Kohsuke Kawaguchi added a comment -

        When we make table row and table borders thick, we can clearly see that the right border is clipped.

        Show
        kohsuke Kohsuke Kawaguchi added a comment - When we make table row and table borders thick, we can clearly see that the right border is clipped.
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Kohsuke Kawaguchi
        Path:
        war/src/main/webapp/css/style.css
        http://jenkins-ci.org/commit/jenkins/90432b56e9c04893b44cf45bd336db98746c40aa
        Log:
        [FIXED JENKINS-12061]

        I still don't fully understand why the right border gets cropped, but
        playing with DOM manipulation window, it seems like the cell-level
        "border-right: none" is winning over the table level "border: 1px solid
        talks about the border conflict resolution specified in
        http://www.w3.org/TR/CSS2/tables.html#border-conflict-resolution

        What this fix does is to set the cell-level right border for pane
        tables. I realize that this might break table nesting inside another
        table.

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: war/src/main/webapp/css/style.css http://jenkins-ci.org/commit/jenkins/90432b56e9c04893b44cf45bd336db98746c40aa Log: [FIXED JENKINS-12061] I still don't fully understand why the right border gets cropped, but playing with DOM manipulation window, it seems like the cell-level "border-right: none" is winning over the table level "border: 1px solid talks about the border conflict resolution specified in http://www.w3.org/TR/CSS2/tables.html#border-conflict-resolution What this fix does is to set the cell-level right border for pane tables. I realize that this might break table nesting inside another table.
        Hide
        dogfood dogfood added a comment -

        Integrated in jenkins_main_trunk #1357
        [FIXED JENKINS-12061]

        Kohsuke Kawaguchi : 90432b56e9c04893b44cf45bd336db98746c40aa
        Files :

        • war/src/main/webapp/css/style.css
        Show
        dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1357 [FIXED JENKINS-12061] Kohsuke Kawaguchi : 90432b56e9c04893b44cf45bd336db98746c40aa Files : war/src/main/webapp/css/style.css

          People

          Assignee:
          Unassigned Unassigned
          Reporter:
          kohsuke Kohsuke Kawaguchi
          Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

            Dates

            Created:
            Updated:
            Resolved: