Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12369

when upgrading from 1.1.14 to 1.1.15 all git builds shown no succesfull builds on jenkins dashboard

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • git-plugin
    • None

      summary says mostly all.

      I upgraded jenkins from 1.424.1 to 1.424.2.
      then I upgraded plugins (among which the git plugin)

      after upgrading the git plugin from 1.1.14 to 1.1.15, all succesfull builds from git repositories seem not to be seen:
      for those projects the last succes column only contains N/A, but the last failure column does contain the expected (kind of) info
      (I already downgraded to 1.1.14 and did not check whether the build numbers shown in the last failure column were correct)

      I noticed this as non-logged-in user – I don't recall whether being logged in or not makes a difference, I think it didn't.

      downgrading to 1.1.14 showed again the correct info on the dashboard.

          [JENKINS-12369] when upgrading from 1.1.14 to 1.1.15 all git builds shown no succesfull builds on jenkins dashboard

          Mariusz Sakowski added a comment - - edited

          I have attached log showing failure of loading successful builds.

          Mariusz Sakowski added a comment - - edited I have attached log showing failure of loading successful builds.

          I had the same issue - but after manually compiling the plugin from git-1.1.15 tag it was solved.

          It seems that it's the 1.1.15 build that's broken, not the code.

          Another hint is that I couldn't build git-plugin until I cherry-picked this commit: https://github.com/lukegb/git-plugin/commit/6ad1b38eb4dcd34465410b8ecca18428ba1c51c0
          so there may be some dependencies issues in project.

          Mariusz Sakowski added a comment - I had the same issue - but after manually compiling the plugin from git-1.1.15 tag it was solved. It seems that it's the 1.1.15 build that's broken, not the code. Another hint is that I couldn't build git-plugin until I cherry-picked this commit: https://github.com/lukegb/git-plugin/commit/6ad1b38eb4dcd34465410b8ecca18428ba1c51c0 so there may be some dependencies issues in project.

          I can reproduce the issue :

          git co git-1.1.14
          mvn clean hpi:run

          configure a project to checkout a git repo, run a build
          stop jenkins

          mvn clean hpi:run
          project and build loads fine

          git co git-1.1.15 (same on master)

          mvn hpi:run
          project and build loads fine

          BUT
          mvn clean hpi:run
          ---- Debugging information ----
          class : hudson.model.FreeStyleBuild
          required-type : org.eclipse.jgit.lib.ObjectId
          path : /build/actions/hudson.plugins.git.util.BuildData/buildsByBranchName/entry/hudson.plugins.git.util.Build/revision/sha1
          line number : 29
          -------------------------------

          So, something has been removed from git-1.1.15/master compared to 1.1.14
          Investigating ...

          Nicolas De Loof added a comment - I can reproduce the issue : git co git-1.1.14 mvn clean hpi:run configure a project to checkout a git repo, run a build stop jenkins mvn clean hpi:run project and build loads fine git co git-1.1.15 (same on master) mvn hpi:run project and build loads fine BUT mvn clean hpi:run ---- Debugging information ---- class : hudson.model.FreeStyleBuild required-type : org.eclipse.jgit.lib.ObjectId path : /build/actions/hudson.plugins.git.util.BuildData/buildsByBranchName/entry/hudson.plugins.git.util.Build/revision/sha1 line number : 29 ------------------------------- So, something has been removed from git-1.1.15/master compared to 1.1.14 Investigating ...

          git bisect to the rescue, this regression was introduced by 76564003671a736cef6bc9b95e93497696aaa5b2

          Nicolas De Loof added a comment - git bisect to the rescue, this regression was introduced by 76564003671a736cef6bc9b95e93497696aaa5b2

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/hudson/plugins/git/GitTool.java
          http://jenkins-ci.org/commit/git-plugin/3bc8e30bcfb5f527ab7cfb47591f2796bac88ee4
          Log:
          [FIXED JENKINS-12369] can't deserialize build history
          This amends commit 76564003671a736cef6bc9b95e93497696aaa5b2.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/plugins/git/GitTool.java http://jenkins-ci.org/commit/git-plugin/3bc8e30bcfb5f527ab7cfb47591f2796bac88ee4 Log: [FIXED JENKINS-12369] can't deserialize build history This amends commit 76564003671a736cef6bc9b95e93497696aaa5b2.

          dogfood added a comment -

          Integrated in plugins_git-plugin #301
          [FIXED JENKINS-12369] can't deserialize build history (Revision 3bc8e30bcfb5f527ab7cfb47591f2796bac88ee4)

          Result = UNSTABLE
          Nicolas De Loof : 3bc8e30bcfb5f527ab7cfb47591f2796bac88ee4
          Files :

          • src/main/java/hudson/plugins/git/GitTool.java

          dogfood added a comment - Integrated in plugins_git-plugin #301 [FIXED JENKINS-12369] can't deserialize build history (Revision 3bc8e30bcfb5f527ab7cfb47591f2796bac88ee4) Result = UNSTABLE Nicolas De Loof : 3bc8e30bcfb5f527ab7cfb47591f2796bac88ee4 Files : src/main/java/hudson/plugins/git/GitTool.java

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/hudson/plugins/git/GitSCM.java
          src/main/java/hudson/plugins/git/GitTool.java
          http://jenkins-ci.org/commit/git-plugin/1e7d0a2c097b34ca3cd609382be4a7e4a29492bc
          Log:
          [FIXED JENKINS-12369] can't deserialize build history
          This amends commit 76564003671a736cef6bc9b95e93497696aaa5b2.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/hudson/plugins/git/GitSCM.java src/main/java/hudson/plugins/git/GitTool.java http://jenkins-ci.org/commit/git-plugin/1e7d0a2c097b34ca3cd609382be4a7e4a29492bc Log: [FIXED JENKINS-12369] can't deserialize build history This amends commit 76564003671a736cef6bc9b95e93497696aaa5b2.

          dogfood added a comment -

          Integrated in plugins_git-plugin #302
          [FIXED JENKINS-12369] can't deserialize build history (Revision 1e7d0a2c097b34ca3cd609382be4a7e4a29492bc)

          Result = UNSTABLE
          Nicolas De Loof : 1e7d0a2c097b34ca3cd609382be4a7e4a29492bc
          Files :

          • src/main/java/hudson/plugins/git/GitSCM.java
          • src/main/java/hudson/plugins/git/GitTool.java

          dogfood added a comment - Integrated in plugins_git-plugin #302 [FIXED JENKINS-12369] can't deserialize build history (Revision 1e7d0a2c097b34ca3cd609382be4a7e4a29492bc) Result = UNSTABLE Nicolas De Loof : 1e7d0a2c097b34ca3cd609382be4a7e4a29492bc Files : src/main/java/hudson/plugins/git/GitSCM.java src/main/java/hudson/plugins/git/GitTool.java

            Unassigned Unassigned
            axel Axel Belinfante
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: