Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-12680

onOffline in ComputerListener not getting called when node is taken offline

      In ComputerListener, onOffline is only called if a node is taken down with the disconnect link in jenkins, any other cause for a node to go offline, makes the call postponed until the master is taken down.

          [JENKINS-12680] onOffline in ComputerListener not getting called when node is taken offline

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/slaves/SlaveComputer.java
          test/src/test/java/hudson/slaves/JNLPLauncherTest.java
          http://jenkins-ci.org/commit/jenkins/4378e878ae327a954911ae4ef84679e0060b63e2
          Log:
          [FIXED JENKINS-12680] the onOffline method wasn't called for abrupt client termination

          Compare: https://github.com/jenkinsci/jenkins/compare/dd0f362...4378e87

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/slaves/SlaveComputer.java test/src/test/java/hudson/slaves/JNLPLauncherTest.java http://jenkins-ci.org/commit/jenkins/4378e878ae327a954911ae4ef84679e0060b63e2 Log: [FIXED JENKINS-12680] the onOffline method wasn't called for abrupt client termination Compare: https://github.com/jenkinsci/jenkins/compare/dd0f362...4378e87

          dogfood added a comment -

          Integrated in jenkins_main_trunk #1523
          [FIXED JENKINS-12680] the onOffline method wasn't called for abrupt client termination (Revision 4378e878ae327a954911ae4ef84679e0060b63e2)

          Result = SUCCESS
          Kohsuke Kawaguchi : 4378e878ae327a954911ae4ef84679e0060b63e2
          Files :

          • test/src/test/java/hudson/slaves/JNLPLauncherTest.java
          • core/src/main/java/hudson/slaves/SlaveComputer.java
          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #1523 [FIXED JENKINS-12680] the onOffline method wasn't called for abrupt client termination (Revision 4378e878ae327a954911ae4ef84679e0060b63e2) Result = SUCCESS Kohsuke Kawaguchi : 4378e878ae327a954911ae4ef84679e0060b63e2 Files : test/src/test/java/hudson/slaves/JNLPLauncherTest.java core/src/main/java/hudson/slaves/SlaveComputer.java changelog.html

            Unassigned Unassigned
            jenschristensen Jens Christensen
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: