Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13129

Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • core
    • None
    • jenkins 1.456, tomcat 7.0.25, java 1.6.0-31 running on windows vista

      I still cannot update cvs or subversion plugins without manually creating a .pinned file.

      When e.g. updating cvs plugin 1.6 (shipped with jenkins.war) to 2.1, the file is installed into the plugin dir, but no cvs.jpi.pinned file is created. When restarting the tomcat server, the file is replaced by the 1.6 version from the war directory.

          [JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          Alex Lehmann added a comment -

          i think i found the cause, there is problem with the isBundled property in plugins, I will write a patch tomorrow.

          Alex Lehmann added a comment - i think i found the cause, there is problem with the isBundled property in plugins, I will write a patch tomorrow.

          Alex Lehmann added a comment -

          https://github.com/alexlehm/jenkins/commit/2453985ca5f4cb2c824466d132fe3658020b72fe

          [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          changed bundled plugin detection, added unit test

          Alex Lehmann added a comment - https://github.com/alexlehm/jenkins/commit/2453985ca5f4cb2c824466d132fe3658020b72fe [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup changed bundled plugin detection, added unit test

          Alex Lehmann added a comment -

          I should note that this is not a specific Windows issue, I have had the same problem with 1.456 on linux as well

          Alex Lehmann added a comment - I should note that this is not a specific Windows issue, I have had the same problem with 1.456 on linux as well

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          core/src/main/java/hudson/PluginManager.java
          test/src/test/java/hudson/PluginManagerTest2.java
          http://jenkins-ci.org/commit/jenkins/860cc9eb61a6a3212e4b8589ac11a74b59b1fcf7
          Log:
          Merge pull request #418 from alexlehm/master

          Fixed JENKINS-13129: Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: core/src/main/java/hudson/PluginManager.java test/src/test/java/hudson/PluginManagerTest2.java http://jenkins-ci.org/commit/jenkins/860cc9eb61a6a3212e4b8589ac11a74b59b1fcf7 Log: Merge pull request #418 from alexlehm/master Fixed JENKINS-13129 : Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          dogfood added a comment -

          Integrated in jenkins_main_trunk #1623
          [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup (Revision 2453985ca5f4cb2c824466d132fe3658020b72fe)

          Result = SUCCESS
          alexlehm : 2453985ca5f4cb2c824466d132fe3658020b72fe
          Files :

          • test/src/test/java/hudson/PluginManagerTest2.java
          • core/src/main/java/hudson/PluginManager.java

          dogfood added a comment - Integrated in jenkins_main_trunk #1623 [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup (Revision 2453985ca5f4cb2c824466d132fe3658020b72fe) Result = SUCCESS alexlehm : 2453985ca5f4cb2c824466d132fe3658020b72fe Files : test/src/test/java/hudson/PluginManagerTest2.java core/src/main/java/hudson/PluginManager.java

          Alex Lehmann added a comment -

          fixed in jenkins_main_trunk#1623

          Alex Lehmann added a comment - fixed in jenkins_main_trunk#1623

          Bumping up the priority to be on the LTS backporting radar.

          Kohsuke Kawaguchi added a comment - Bumping up the priority to be on the LTS backporting radar.

          Code changed in jenkins
          User: Alex Lehmann
          Path:
          core/src/main/java/hudson/PluginManager.java
          test/src/test/java/hudson/PluginManagerTest2.java
          http://jenkins-ci.org/commit/jenkins/2453985ca5f4cb2c824466d132fe3658020b72fe
          Log:
          [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          changed bundled plugin detection, added unit test

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Lehmann Path: core/src/main/java/hudson/PluginManager.java test/src/test/java/hudson/PluginManagerTest2.java http://jenkins-ci.org/commit/jenkins/2453985ca5f4cb2c824466d132fe3658020b72fe Log: [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup changed bundled plugin detection, added unit test

          dogfood added a comment -

          Integrated in jenkins_ui-changes_branch #21
          [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup (Revision 2453985ca5f4cb2c824466d132fe3658020b72fe)

          Result = SUCCESS
          alexlehm : 2453985ca5f4cb2c824466d132fe3658020b72fe
          Files :

          • test/src/test/java/hudson/PluginManagerTest2.java
          • core/src/main/java/hudson/PluginManager.java

          dogfood added a comment - Integrated in jenkins_ui-changes_branch #21 [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup (Revision 2453985ca5f4cb2c824466d132fe3658020b72fe) Result = SUCCESS alexlehm : 2453985ca5f4cb2c824466d132fe3658020b72fe Files : test/src/test/java/hudson/PluginManagerTest2.java core/src/main/java/hudson/PluginManager.java

          Code changed in jenkins
          User: Alex Lehmann
          Path:
          core/src/main/java/hudson/PluginManager.java
          test/src/test/java/hudson/PluginManagerTest2.java
          http://jenkins-ci.org/commit/jenkins/e986dcd929886182db6c5c1926ba01a927ba55d2
          Log:
          [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup

          changed bundled plugin detection, added unit test
          (cherry picked from commit 2453985ca5f4cb2c824466d132fe3658020b72fe)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Lehmann Path: core/src/main/java/hudson/PluginManager.java test/src/test/java/hudson/PluginManagerTest2.java http://jenkins-ci.org/commit/jenkins/e986dcd929886182db6c5c1926ba01a927ba55d2 Log: [Fixed JENKINS-13129] Updating built-in plugins doesn't work, the file doesn't get pinned and is overwritten on the next startup changed bundled plugin detection, added unit test (cherry picked from commit 2453985ca5f4cb2c824466d132fe3658020b72fe)

            alexlehm Alex Lehmann
            alexlehm Alex Lehmann
            Votes:
            1 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: