Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13200

1.455: Block build when downstream project is building doesn't work

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Cannot Reproduce
    • Icon: Blocker Blocker
    • build-pipeline-plugin
    • Jenkins 1.455, CentOS 5.5

      We have a test job chain that runs on a single slave. As this chain can be triggered serveral times during the day it's very important that it is blocked from running on that slave, if a downstream job is building. That doesn't work anymore.

          [JENKINS-13200] 1.455: Block build when downstream project is building doesn't work

          Kay Abendroth added a comment -

          A fix that works for me: https://github.com/kayabendroth/jenkins/commit/d2743e7b17954ec8bbf89f3bd4ba00c3bf4eee43.

          I haven't updated or added a test case, because I didn't get the bundled test suite to work.

          Kay Abendroth added a comment - A fix that works for me: https://github.com/kayabendroth/jenkins/commit/d2743e7b17954ec8bbf89f3bd4ba00c3bf4eee43 . I haven't updated or added a test case, because I didn't get the bundled test suite to work.

          Kay Abendroth added a comment -

          This is the commit that I think broke the behavior in the first place: https://github.com/jenkinsci/jenkins/commit/d6a92f37f9111a68a5f13dc938fe60889eb7273f.

          Kay Abendroth added a comment - This is the commit that I think broke the behavior in the first place: https://github.com/jenkinsci/jenkins/commit/d6a92f37f9111a68a5f13dc938fe60889eb7273f .

          Kay Abendroth added a comment -

          dty:

          I don't think this is the correct fix. isBuilding() will return always return true if isLogUpdated() returns true. Adding a condition for isBuilding() would actually allow builds in the POST_PRODUCTION state to be considered not blocking, which was what I fixed with my checkin.

          —
          [1] https://github.com/jenkinsci/jenkins/pull/414#issuecomment-4710598

          Kay Abendroth added a comment - dty : I don't think this is the correct fix. isBuilding() will return always return true if isLogUpdated() returns true. Adding a condition for isBuilding() would actually allow builds in the POST_PRODUCTION state to be considered not blocking, which was what I fixed with my checkin. — [1] https://github.com/jenkinsci/jenkins/pull/414#issuecomment-4710598

          Kay Abendroth added a comment -

          I will try to reproduce the error.

          Kay Abendroth added a comment - I will try to reproduce the error.

          Kay Abendroth added a comment - - edited

          The fix I mentioned doesn't work. The problem is somewhere else, but still present.

          Kay Abendroth added a comment - - edited The fix I mentioned doesn't work. The problem is somewhere else, but still present.

            Unassigned Unassigned
            kay_abendroth Kay Abendroth
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: