Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13243

Do not replace slashes in URLs with backslashes on Windows

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Component/s: xshell-plugin
    • Labels:
      None
    • Environment:
      Can be reproduced on any Windows platform
    • Similar Issues:

      Description

      When you call a script which expects an URL as parameter, the slashes will also be converted to backslashes. It results in a broken parameter for the build. So on Windows the plugin should not convert parameters which contain URLs.

        Attachments

          Activity

          Hide
          davehunt Dave Hunt added a comment -

          I have submitted a pull request with a fix for this: https://github.com/jenkinsci/xshell-plugin/pull/2

          Show
          davehunt Dave Hunt added a comment - I have submitted a pull request with a fix for this: https://github.com/jenkinsci/xshell-plugin/pull/2
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Marco Ambu
          Path:
          src/main/java/hudson/plugins/xshell/XShellBuilder.java
          http://jenkins-ci.org/commit/xshell-plugin/1a793f745f94de278438672db29e5f5cc6b89789
          Log:
          Merge pull request #2 from davehunt/13243

          Don't replace slashes in URLs. Fixes JENKINS-13243

          Compare: https://github.com/jenkinsci/xshell-plugin/compare/f0cbc9c...1a793f7

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marco Ambu Path: src/main/java/hudson/plugins/xshell/XShellBuilder.java http://jenkins-ci.org/commit/xshell-plugin/1a793f745f94de278438672db29e5f5cc6b89789 Log: Merge pull request #2 from davehunt/13243 Don't replace slashes in URLs. Fixes JENKINS-13243 Compare: https://github.com/jenkinsci/xshell-plugin/compare/f0cbc9c...1a793f7
          Hide
          whimboo Henrik Skupin added a comment -
          Show
          whimboo Henrik Skupin added a comment - Code has been merged: https://github.com/jenkinsci/xshell-plugin/pull/2
          Hide
          achoo Andrew C added a comment - - edited

          Git URLs are still affected: git://github.com/user/repo.git becomes git:\github.com\user\repo.git

          Show
          achoo Andrew C added a comment - - edited Git URLs are still affected: git://github.com/user/repo.git becomes git:\github.com\user\repo.git
          Hide
          achoo Andrew C added a comment -

          I have submitted a pull request with a suggested fix for this: https://github.com/jenkinsci/xshell-plugin/pull/7

          One concern I have is that there might be other legitimate arguments beginning with git: that aren't git URLs but I can't think of any right now. So hopefully this is sufficient.

          Show
          achoo Andrew C added a comment - I have submitted a pull request with a suggested fix for this: https://github.com/jenkinsci/xshell-plugin/pull/7 One concern I have is that there might be other legitimate arguments beginning with git: that aren't git URLs but I can't think of any right now. So hopefully this is sufficient.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Andrew Cheng
          Path:
          src/main/java/hudson/plugins/xshell/XShellBuilder.java
          http://jenkins-ci.org/commit/xshell-plugin/8b564d19c457e85c88763d270edc803772286c75
          Log:
          add git to URL matcher for JENKINS-13243

          otherwise git://github.com/user/repo.git becomes git:\github.com\user\repo.git

          see https://issues.jenkins-ci.org/browse/JENKINS-13243?focusedCommentId=178712&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-178712

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Cheng Path: src/main/java/hudson/plugins/xshell/XShellBuilder.java http://jenkins-ci.org/commit/xshell-plugin/8b564d19c457e85c88763d270edc803772286c75 Log: add git to URL matcher for JENKINS-13243 otherwise git://github.com/user/repo.git becomes git:\github.com\user\repo.git see https://issues.jenkins-ci.org/browse/JENKINS-13243?focusedCommentId=178712&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-178712
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Marco Ambu
          Path:
          src/main/java/hudson/plugins/xshell/XShellBuilder.java
          http://jenkins-ci.org/commit/xshell-plugin/3ac09e1cf3ce8de0e0c9eedfd076998dc754c961
          Log:
          Merge pull request #7 from achengs/master

          Don't replace slashes in git URLs. Fixes JENKINS-13243

          Compare: https://github.com/jenkinsci/xshell-plugin/compare/3c8ade876689...3ac09e1cf3ce

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marco Ambu Path: src/main/java/hudson/plugins/xshell/XShellBuilder.java http://jenkins-ci.org/commit/xshell-plugin/3ac09e1cf3ce8de0e0c9eedfd076998dc754c961 Log: Merge pull request #7 from achengs/master Don't replace slashes in git URLs. Fixes JENKINS-13243 Compare: https://github.com/jenkinsci/xshell-plugin/compare/3c8ade876689...3ac09e1cf3ce

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            whimboo Henrik Skupin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: