Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13639

Use Token Macro capability to expand variables

XMLWordPrintable

      Jenkins provides a powerful macro expansion capability https://wiki.jenkins-ci.org/display/JENKINS/Token+Macro+Plugin

      In file ArtifactDeployerBuilder.java I'd suggest to replace:
      final String includes = build.getEnvironment(listener).expand(entry.getIncludes());
      final String excludes = build.getEnvironment(listener).expand(entry.getExcludes());
      final String outputPath = build.getEnvironment(listener).expand(entry.getRemote());

      with something like:
      final String includes = TokenMacro.expandAll(build, listener, entry.getIncludes());
      final String excludes = TokenMacro.expandAll(build, listener, entry.getExcludes());
      final String outputPath = TokenMacro.expandAll(build, listener, entry.getRemote());

      Thank you for considering this and for the great ArtifactDeployer plugin.

          [JENKINS-13639] Use Token Macro capability to expand variables

          Gregory Boissinot added a comment -

          Thanks for using the artifactdeployer plugin.
          Why not using this feature.
          However, I don't want to introduce a dependency to the Token Macro plugin. It doesn't make sense.
          Token Marco should extract its API to a dedicated library and then I could integrate this library.

          Gregory Boissinot added a comment - Thanks for using the artifactdeployer plugin. Why not using this feature. However, I don't want to introduce a dependency to the Token Macro plugin. It doesn't make sense. Token Marco should extract its API to a dedicated library and then I could integrate this library.

          Gregory Boissinot added a comment -

          Improvement for the token-macro plugin:

          • Make a dedicated library for using it in another plugins without introduced hard dependency to the token-macro plugin.

          Gregory Boissinot added a comment - Improvement for the token-macro plugin: Make a dedicated library for using it in another plugins without introduced hard dependency to the token-macro plugin.

          Alex Earl added a comment -

          The token-macro plugin IS basically a library. There won't be a dedicated library created for it.

          Alex Earl added a comment - The token-macro plugin IS basically a library. There won't be a dedicated library created for it.

            slide_o_mix Alex Earl
            noseka1 Ales Nosek
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: