Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13745

Valgrind Plugin: Any Configuration of the "publish valgrind results" part triggers exception

      I have tested the Valgrind plugin, but I cannot configure it.
      The build configuration part is working find, but when I try to configure the "publish valgrind results" part, I get the exception in the attached file.

        1. graph.png
          graph.png
          31 kB
        2. hudson_valgrind_plugin_excpetion.txt
          5 kB
        3. logs
          3 kB
        4. Overview.png
          Overview.png
          29 kB
        5. valgrind.tar.gz
          2 kB

          [JENKINS-13745] Valgrind Plugin: Any Configuration of the "publish valgrind results" part triggers exception

          Georg Hofmann added a comment -

          I have tested version 0.8 with jenkins 1.464. Configuration and execution is now working fine.
          Nice plugin, thanks.

          Georg Hofmann added a comment - I have tested version 0.8 with jenkins 1.464. Configuration and execution is now working fine. Nice plugin, thanks.

          Artem Popov added a comment -

          [Valgrind] copying source file '/var/lib/jenkins/jobs/Orig_MMS_experimental/workspace/Gateway/core/smtp/smtp_parser.c' to 'source_31.tmp'...
          [Valgrind] workspacePath: /var/lib/jenkins/jobs/Orig_MMS_experimental_UnitTests/workspace/
          ERROR: Publisher org.jenkinsci.plugins.valgrind.ValgrindPublisher aborted due to exception
          java.lang.NullPointerException
          at org.jenkinsci.plugins.valgrind.ValgrindPublisher.perform(ValgrindPublisher.java:184)
          at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45)
          at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:745)
          at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:709)
          at hudson.model.Build$BuildExecution.post2(Build.java:182)
          at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:658)
          at hudson.model.Run.execute(Run.java:1734)
          at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
          at hudson.model.ResourceController.execute(ResourceController.java:88)
          at hudson.model.Executor.run(Executor.java:231)

          Jenkins ver. 1.561
          Valgrind Plug-in 0.21

          Artem Popov added a comment - [Valgrind] copying source file '/var/lib/jenkins/jobs/Orig_MMS_experimental/workspace/Gateway/core/smtp/smtp_parser.c' to 'source_31.tmp'... [Valgrind] workspacePath: /var/lib/jenkins/jobs/Orig_MMS_experimental_UnitTests/workspace/ ERROR: Publisher org.jenkinsci.plugins.valgrind.ValgrindPublisher aborted due to exception java.lang.NullPointerException at org.jenkinsci.plugins.valgrind.ValgrindPublisher.perform(ValgrindPublisher.java:184) at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45) at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:745) at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:709) at hudson.model.Build$BuildExecution.post2(Build.java:182) at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:658) at hudson.model.Run.execute(Run.java:1734) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:88) at hudson.model.Executor.run(Executor.java:231) Jenkins ver. 1.561 Valgrind Plug-in 0.21

          @Artem: other users seem to have no problem with the latest release (see comments of ticket JENKINS-24256), so i suspect there is something special with your data or your setup.
          Thanks for the stacktrace, it tells me where the plugin crashed but not exactly why. Could you send me the xml report from valgrind?

          Johannes Ohlemacher added a comment - @Artem: other users seem to have no problem with the latest release (see comments of ticket JENKINS-24256 ), so i suspect there is something special with your data or your setup. Thanks for the stacktrace, it tells me where the plugin crashed but not exactly why. Could you send me the xml report from valgrind?

          Artem Popov added a comment - - edited

          I didn't tested which one of XMLs cause a crash, but it is someone from "valgrind.tar.gz"

          Artem Popov added a comment - - edited I didn't tested which one of XMLs cause a crash, but it is someone from "valgrind.tar.gz"

          Artem Popov added a comment -

          Johannes, have you any updates regarding this bug?

          Artem Popov added a comment - Johannes, have you any updates regarding this bug?

          Code changed in jenkins
          User: Johannes Ohlemacher
          Path:
          src/main/java/org/jenkinsci/plugins/valgrind/ValgrindPublisher.java
          src/main/java/org/jenkinsci/plugins/valgrind/model/ValgrindProcess.java
          src/main/java/org/jenkinsci/plugins/valgrind/model/ValgrindReport.java
          src/main/java/org/jenkinsci/plugins/valgrind/parser/ValgrindParserResult.java
          http://jenkins-ci.org/commit/valgrind-plugin/9d580e6b8f05774d7ce8ff7134ee938485beda6f
          Log:
          fixed JENKINS-13745 don't crash on invalid or incomplete report files

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Johannes Ohlemacher Path: src/main/java/org/jenkinsci/plugins/valgrind/ValgrindPublisher.java src/main/java/org/jenkinsci/plugins/valgrind/model/ValgrindProcess.java src/main/java/org/jenkinsci/plugins/valgrind/model/ValgrindReport.java src/main/java/org/jenkinsci/plugins/valgrind/parser/ValgrindParserResult.java http://jenkins-ci.org/commit/valgrind-plugin/9d580e6b8f05774d7ce8ff7134ee938485beda6f Log: fixed JENKINS-13745 don't crash on invalid or incomplete report files

          @Artem: thanks for uploading your report files. Most of those files are basically empty or contain no process information (required by the plugin). Those files caused the plugin to crash. It shouldn't happend anymore with version 0.22 (just released, wait a few hours until it shows up in your update center)

          btw: I am not sure, how you managed to create those empty report files... maybe there is a problem with your valgrind calls...

          Johannes Ohlemacher added a comment - @Artem: thanks for uploading your report files. Most of those files are basically empty or contain no process information (required by the plugin). Those files caused the plugin to crash. It shouldn't happend anymore with version 0.22 (just released, wait a few hours until it shows up in your update center) btw: I am not sure, how you managed to create those empty report files... maybe there is a problem with your valgrind calls...

          Artem Popov added a comment - - edited

          @Johannes, thank you for the fix, it works fine for me now. Bug happened because I use my own valgrind version with some extra functionality, and I did not add some field to the report which I considered as not mandatory, but it was.

          Reports looks like correct now, but I am worried about performance. Jenkins need to many time for display reports. It take about 45 seconds for each request. I attached screenshot of timing. It is not related to this story, but will be interesting to know your opinion about performance issues.

          P.S. Job contain ~250 valgrind report files, with 1Mb data in the each file.

          Artem Popov added a comment - - edited @Johannes, thank you for the fix, it works fine for me now. Bug happened because I use my own valgrind version with some extra functionality, and I did not add some field to the report which I considered as not mandatory, but it was. Reports looks like correct now, but I am worried about performance. Jenkins need to many time for display reports. It take about 45 seconds for each request. I attached screenshot of timing. It is not related to this story, but will be interesting to know your opinion about performance issues. P.S. Job contain ~250 valgrind report files, with 1Mb data in the each file.

          @Artem: you are welcome

          I am worried about performance too, its on my todo list since quite some time. I have a lot on my plate right now, so this has to wait a few more weeks. 250Mb of valgrind reports seems like a challenging test case

          Johannes Ohlemacher added a comment - @Artem: you are welcome I am worried about performance too, its on my todo list since quite some time. I have a lot on my plate right now, so this has to wait a few more weeks. 250Mb of valgrind reports seems like a challenging test case

          The actual problems was fixed some time ago.

          I created a new issue JENKINS-25750 for the performance concerns (see comments above).

          Johannes Ohlemacher added a comment - The actual problems was fixed some time ago. I created a new issue JENKINS-25750 for the performance concerns (see comments above).

            existence Johannes Ohlemacher
            gwebdhofmann Georg Hofmann
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: