Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-13822

Maven plugin: expand variables in "Room POM" field

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Trivial Trivial
    • maven-plugin
    • None

      The Root POM field in the maven-plugin does not expand build/environment variables. I have made a code change to allow this and will commit + push+ send a pull request as soon as it's checked in.

      I have a question about the maven-plugin though - why is it integrated into the Jenkins core and not in its own separate repository?

          [JENKINS-13822] Maven plugin: expand variables in "Room POM" field

          Code changed in jenkins
          User: Olivier Lamy
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/25b694351f68076129734604dd270ae48f31b020
          Log:
          changelog entry for JENKINS-13822

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: changelog.html http://jenkins-ci.org/commit/jenkins/25b694351f68076129734604dd270ae48f31b020 Log: changelog entry for JENKINS-13822

          dogfood added a comment -

          Integrated in jenkins_main_trunk #1725
          Fixes JENKINS-13822: expand variables in "Root POM" field of Maven plugin (Revision 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0)
          changelog entry for JENKINS-13822 (Revision 25b694351f68076129734604dd270ae48f31b020)

          Result = SUCCESS
          ian.kemp : 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0
          Files :

          • maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
          • maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java

          Olivier Lamy : 25b694351f68076129734604dd270ae48f31b020
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #1725 Fixes JENKINS-13822 : expand variables in "Root POM" field of Maven plugin (Revision 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0) changelog entry for JENKINS-13822 (Revision 25b694351f68076129734604dd270ae48f31b020) Result = SUCCESS ian.kemp : 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0 Files : maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java Olivier Lamy : 25b694351f68076129734604dd270ae48f31b020 Files : changelog.html

          dogfood added a comment -

          Integrated in jenkins_ui-changes_branch #30
          Fixes JENKINS-13822: expand variables in "Root POM" field of Maven plugin (Revision 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0)
          changelog entry for JENKINS-13822 (Revision 25b694351f68076129734604dd270ae48f31b020)

          Result = SUCCESS
          ian.kemp : 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0
          Files :

          • maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
          • maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java

          Olivier Lamy : 25b694351f68076129734604dd270ae48f31b020
          Files :

          • changelog.html

          dogfood added a comment - Integrated in jenkins_ui-changes_branch #30 Fixes JENKINS-13822 : expand variables in "Root POM" field of Maven plugin (Revision 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0) changelog entry for JENKINS-13822 (Revision 25b694351f68076129734604dd270ae48f31b020) Result = SUCCESS ian.kemp : 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0 Files : maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java Olivier Lamy : 25b694351f68076129734604dd270ae48f31b020 Files : changelog.html

          Jesse Glick added a comment -

          @olamy is 486be07 (fixed in 1.469 I think) related to this?

          Jesse Glick added a comment - @olamy is 486be07 (fixed in 1.469 I think) related to this?

          Jesse Glick added a comment - - edited

          Jesse Glick added a comment - - edited https://github.com/jenkinsci/jenkins/commit/486be0748ad99adb755d5460f742cd58f81f5b88 and https://github.com/jenkinsci/jenkins/commit/9a3f25acbf8c078bd7ecde3330c31dbef9756418 (in 1.468) do seem to be part of this.

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java
          http://jenkins-ci.org/commit/jenkins/32748591dc7a38791f0728a56bb7662f0347454e
          Log:
          JENKINS-13822 olamy’s 9a3f25a & 25b6943 claimed this fix was in 1.466; actually in 1.467.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java http://jenkins-ci.org/commit/jenkins/32748591dc7a38791f0728a56bb7662f0347454e Log: JENKINS-13822 olamy’s 9a3f25a & 25b6943 claimed this fix was in 1.466; actually in 1.467.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #2063
          JENKINS-13822 olamy’s 9a3f25a & 25b6943 claimed this fix was in 1.466; actually in 1.467. (Revision 32748591dc7a38791f0728a56bb7662f0347454e)

          Result = UNSTABLE
          Jesse Glick : 32748591dc7a38791f0728a56bb7662f0347454e
          Files :

          • maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java
          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #2063 JENKINS-13822 olamy’s 9a3f25a & 25b6943 claimed this fix was in 1.466; actually in 1.467. (Revision 32748591dc7a38791f0728a56bb7662f0347454e) Result = UNSTABLE Jesse Glick : 32748591dc7a38791f0728a56bb7662f0347454e Files : maven-plugin/src/main/java/hudson/maven/MavenModuleSet.java changelog.html

          Code changed in jenkins
          User: IanKemp
          Path:
          src/main/java/hudson/maven/MavenModuleSet.java
          src/main/java/hudson/maven/MavenModuleSetBuild.java
          http://jenkins-ci.org/commit/maven-plugin/486095226d206f2a1806ba803b6358970d3870c3
          Log:
          Fixes JENKINS-13822: expand variables in "Root POM" field of Maven plugin

          Originally-Committed-As: 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: IanKemp Path: src/main/java/hudson/maven/MavenModuleSet.java src/main/java/hudson/maven/MavenModuleSetBuild.java http://jenkins-ci.org/commit/maven-plugin/486095226d206f2a1806ba803b6358970d3870c3 Log: Fixes JENKINS-13822 : expand variables in "Root POM" field of Maven plugin Originally-Committed-As: 4e8775fc2c53a4fe4409a8b79c3bdd7eaa0274c0

          Code changed in jenkins
          User: Olivier Lamy
          Path:
          src/main/java/hudson/maven/MavenModuleSet.java
          src/main/java/hudson/maven/MavenModuleSetBuild.java
          http://jenkins-ci.org/commit/maven-plugin/d9a1efe158bc90e29b90144b65a9da613bace90e
          Log:
          Merge pull request #480 from IanKemp/master

          JENKINS-13822 fix
          Thanks
          Originally-Committed-As: ec9d403c63131206d9ca4a77c4c90ffb190129d8

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: src/main/java/hudson/maven/MavenModuleSet.java src/main/java/hudson/maven/MavenModuleSetBuild.java http://jenkins-ci.org/commit/maven-plugin/d9a1efe158bc90e29b90144b65a9da613bace90e Log: Merge pull request #480 from IanKemp/master JENKINS-13822 fix Thanks Originally-Committed-As: ec9d403c63131206d9ca4a77c4c90ffb190129d8

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/hudson/maven/MavenModuleSet.java
          http://jenkins-ci.org/commit/maven-plugin/57eb5ee235095411aafa853fb052e11da5f6ae93
          Log:
          JENKINS-13822 olamy’s 9a3f25a & 25b6943 claimed this fix was in 1.466; actually in 1.467.

          Originally-Committed-As: 32748591dc7a38791f0728a56bb7662f0347454e

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/MavenModuleSet.java http://jenkins-ci.org/commit/maven-plugin/57eb5ee235095411aafa853fb052e11da5f6ae93 Log: JENKINS-13822 olamy’s 9a3f25a & 25b6943 claimed this fix was in 1.466; actually in 1.467. Originally-Committed-As: 32748591dc7a38791f0728a56bb7662f0347454e

            olamy Olivier Lamy
            iankemp Ian Kemp
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: