-
Bug
-
Resolution: Fixed
-
Major
-
None
-
Windows 7. Jenkins v1.472. ThinBackup v1.6
Hi there,
It appears that once thinBackup has run, Jenkins is always taken out of shutdown mode even if it was in shutdown before thinBackup ran.
Consider this:
1) Jenkins is in shutdown mode.
2) thinBackup runs.
3) Jenkins is no longer in shutdown.
This is a bug and the plugin should be updated to put back the shutdown flag setting after backing up.
Regards,
Tom.
[JENKINS-14288] thinBackup doesn't put back the current shutdown flag after backing up
Thomas Fields
added a comment - This is still an issue with thinBackup 1.6.1. Thomas Fields
added a comment - Is there any chance we can get a fix for this?
If I put Jenkins in shutdown before leaving the office at night, thinBackup runs overnight, then the next morning Jenkins is no longer in shutdown. This is really annoying. Please fix.
Thomas Fields
added a comment - Is there any chance we can get a fix for this?
If I put Jenkins in shutdown before leaving the office at night, thinBackup runs overnight, then the next morning Jenkins is no longer in shutdown. This is really annoying. Please fix. 
Thomas Fürer
added a comment - I'm a bit confused. Please correct me if I am wrong. Your problem is that jenkins is set to shutdown not via thinbackup but some mechanism outside of thinbackup (e.g. manually, as you describted in your last post), and you would have jenkins still be in shutdown also after a successful backup. Am I right?
Thomas Fürer
added a comment - I'm a bit confused. Please correct me if I am wrong. Your problem is that jenkins is set to shutdown not via thinbackup but some mechanism outside of thinbackup (e.g. manually, as you describted in your last post), and you would have jenkins still be in shutdown also after a successful backup. Am I right? Thomas Fields
added a comment - That's correct. Thomas Fürer
added a comment - In reply to comment #5:
> That's correct.
sorry for the delay. I was simply confused, but it was a simple fix. I just committed a change. I will also try to push a new release but I need to do some testing before. so please hold on.
thomas
Thomas Fürer
added a comment - In reply to comment #5:
> That's correct.
sorry for the delay. I was simply confused, but it was a simple fix. I just committed a change. I will also try to push a new release but I need to do some testing before. so please hold on.
thomas Thomas Fürer
added a comment - Integrated in 
thinBackup #47
JENKINS-14288: thinBackup doesn't put back the current shutdown flag after backing up (Revision 40678)
Result = FAILURE
tofuatjava : 40678
Files :
- /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
- /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
Thomas Fürer
added a comment - Integrated in thinBackup #47
JENKINS-14288 : thinBackup doesn't put back the current shutdown flag after backing up (Revision 40678)
Result = FAILURE
tofuatjava : 40678
Files :
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
Thomas Fürer
added a comment - Integrated in thinBackup #50
JENKINS-14288: thinBackup doesn't put back the current shutdown flag after backing up (Revision 40678)
Result = FAILURE
tofuatjava : 40678
Files :
- /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
- /trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
Thomas Fürer
added a comment - Integrated in thinBackup #50
JENKINS-14288 : thinBackup doesn't put back the current shutdown flag after backing up (Revision 40678)
Result = FAILURE
tofuatjava : 40678
Files :
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
/trunk/hudson/plugins/thinBackup/src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
Code changed in jenkins
User: tofuatgit
Path:
src/main/java/org/jvnet/hudson/plugins/thinbackup/ThinBackupPeriodicWork.java
src/main/java/org/jvnet/hudson/plugins/thinbackup/utils/Utils.java
http://jenkins-ci.org/commit/thin-backup-plugin/e125d9972cb8ab326c52e1b759e456f35849fa1a
Log:
JENKINS-14288: thinBackup doesn't put back the current shutdown flag after backing up
git-svn-id: https://svn.jenkins-ci.org/trunk/hudson/plugins/thinBackup@40678 71c3de6d-444a-0410-be80-ed276b4c234a
please try also the newer version 1.6.1 where I did some bug fixing about this topic.
Please be aware that once you have chosen a value greater than zero for 'Force Jenkins to quite mode after specified minutes' jenkins will be forced to quiet mode until the backup is finished (compare https://wiki.jenkins-ci.org/display/JENKINS/thinBackup). Be also aware that the quiet mode in case of an triggered backup is not cancleable, for now.
please also check if the backup do not have some problems like missing permissions or slow network connection with shared folders.
thanks