-
Bug
-
Resolution: Fixed
-
Major
-
Jenkins v1.455
The use of <f:section> elements inside newly-added items in a hetero list are broken. This appears to be caused by the introduction of resource adjuncts in Jenkins 1.455.
The generated html of a <f:section> entry changed in v1.455 to include these extra elements:
<link rel="stylesheet" href="/adjuncts/29830985/lib/form/section_.css" type="text/css"> <script src="/adjuncts/29830985/lib/form/section_.js" type="text/javascript"></script>
I believe it is the link element causing the problems because if I wrap the <f:section> in an <f:advanced> tag, then edit the DOM to remove the <link ... href="/adjuncts/29830985/lib/form/section_.css"> element, then the hetero list entry loads successfully when the advanced section is expanded.
An example of this is the Sectioned View Plugin. If you add a new List View Section to a Sectioned View then the Advanced section (which contains a <f:section> tag) is empty when expanded in Jenkins 1.455+. If you edit the DOM immediately after adding the List View Section (before clicking the Advanced button) to remove that extra <link ...> element, then the Advanced section will work properly.
- is related to
-
JENKINS-13212 "Advanced" button fails for newly created list view section
-
- Open
-
-
JENKINS-19169 Invalid location for <link>
-
- Open
-
- links to
Code changed in jenkins
User: Vincent Latombe
Path:
core/src/main/resources/lib/form/advanced/advanced.js
test/src/test/java/lib/form/AdvancedButtonTest.java
test/src/test/resources/lib/form/AdvancedButtonTest/testSectionInsideOfAdvanced.jelly
http://jenkins-ci.org/commit/jenkins/7619aeda1ab4b9d63f73f4548d181882b622c063
Log:
JENKINS-14632Use a more specific selector so we don't risk matchin… (#3467)JENKINS-14632Use a more specific selector so we don't risk matching an element we are not expectingJENKINS-14632Annotate test with issue number*NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.