Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-14759

Job created by posting config.xml to /createItem does not set GitHub webhook

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If job is created by posting config.xml, even "build when a change is pushed on github" is checked in config, no hook is registered on github.

        Attachments

          Activity

          Hide
          ndeloof Nicolas De Loof added a comment - - edited

          PushTrigger.start only set the hook for newInstance=true, but for jobs created from posting config.xml item.onLoad() is used, so newInstance=false
          This may require a fix in jenkins core ?

          Show
          ndeloof Nicolas De Loof added a comment - - edited PushTrigger.start only set the hook for newInstance=true, but for jobs created from posting config.xml item.onLoad() is used, so newInstance=false This may require a fix in jenkins core ?
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/AbstractItem.java
          core/src/main/java/hudson/model/AbstractProject.java
          core/src/main/java/hudson/model/ItemGroupMixIn.java
          core/src/main/java/hudson/model/Items.java
          core/src/main/java/hudson/triggers/Trigger.java
          test/pom.xml
          test/src/test/java/hudson/triggers/TriggerStartTest.java
          http://jenkins-ci.org/commit/jenkins/597ea1e6a2c8ec9aac432b6955417afb76588398
          Log:
          [FIXED JENKINS-14759] Job created by posting config.xml to /createItem does not set GitHub webhook.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/AbstractItem.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/ItemGroupMixIn.java core/src/main/java/hudson/model/Items.java core/src/main/java/hudson/triggers/Trigger.java test/pom.xml test/src/test/java/hudson/triggers/TriggerStartTest.java http://jenkins-ci.org/commit/jenkins/597ea1e6a2c8ec9aac432b6955417afb76588398 Log: [FIXED JENKINS-14759] Job created by posting config.xml to /createItem does not set GitHub webhook.
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #1895
          [FIXED JENKINS-14759] Job created by posting config.xml to /createItem does not set GitHub webhook. (Revision 597ea1e6a2c8ec9aac432b6955417afb76588398)

          Result = SUCCESS
          Jesse Glick : 597ea1e6a2c8ec9aac432b6955417afb76588398
          Files :

          • core/src/main/java/hudson/triggers/Trigger.java
          • test/src/test/java/hudson/triggers/TriggerStartTest.java
          • test/pom.xml
          • core/src/main/java/hudson/model/ItemGroupMixIn.java
          • core/src/main/java/hudson/model/AbstractProject.java
          • core/src/main/java/hudson/model/AbstractItem.java
          • core/src/main/java/hudson/model/Items.java
          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1895 [FIXED JENKINS-14759] Job created by posting config.xml to /createItem does not set GitHub webhook. (Revision 597ea1e6a2c8ec9aac432b6955417afb76588398) Result = SUCCESS Jesse Glick : 597ea1e6a2c8ec9aac432b6955417afb76588398 Files : core/src/main/java/hudson/triggers/Trigger.java test/src/test/java/hudson/triggers/TriggerStartTest.java test/pom.xml core/src/main/java/hudson/model/ItemGroupMixIn.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/AbstractItem.java core/src/main/java/hudson/model/Items.java changelog.html

            People

            Assignee:
            jglick Jesse Glick
            Reporter:
            ndeloof Nicolas De Loof
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: