Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15369

NPE from Jenkins.removeNode

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Observed an exception trying to remove a slave which failed to launch:

      java.lang.NullPointerException
      	jenkins.model.Jenkins.removeNode(Jenkins.java:1645)
      	hudson.model.Computer.doDoDelete(Computer.java:1131)
      

      Easy to fix the NPE; @CheckForNull is being ignored here. Unclear whether fixing the NPE would really help the original problem which was apparently a zombie slave of some kind.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/Computer.java
          core/src/main/java/hudson/model/labels/LabelAtom.java
          core/src/main/java/jenkins/model/Jenkins.java
          http://jenkins-ci.org/commit/jenkins/300bfc463bc4377d6124fa538f64ff6e2b8d7813
          Log:
          [FIXED JENKINS-15369] NPE deleting a slave.

          Compare: https://github.com/jenkinsci/jenkins/compare/202903aaef6e...300bfc463bc4

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Computer.java core/src/main/java/hudson/model/labels/LabelAtom.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/300bfc463bc4377d6124fa538f64ff6e2b8d7813 Log: [FIXED JENKINS-15369] NPE deleting a slave. Compare: https://github.com/jenkinsci/jenkins/compare/202903aaef6e...300bfc463bc4
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #1963
          [FIXED JENKINS-15369] NPE deleting a slave. (Revision 300bfc463bc4377d6124fa538f64ff6e2b8d7813)

          Result = SUCCESS
          Jesse Glick : 300bfc463bc4377d6124fa538f64ff6e2b8d7813
          Files :

          • core/src/main/java/hudson/model/labels/LabelAtom.java
          • core/src/main/java/hudson/model/Computer.java
          • core/src/main/java/jenkins/model/Jenkins.java
          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1963 [FIXED JENKINS-15369] NPE deleting a slave. (Revision 300bfc463bc4377d6124fa538f64ff6e2b8d7813) Result = SUCCESS Jesse Glick : 300bfc463bc4377d6124fa538f64ff6e2b8d7813 Files : core/src/main/java/hudson/model/labels/LabelAtom.java core/src/main/java/hudson/model/Computer.java core/src/main/java/jenkins/model/Jenkins.java changelog.html
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          changelog.html
          core/src/main/java/hudson/model/Computer.java
          http://jenkins-ci.org/commit/jenkins/87d9a6e413c11eda69f7c2966c3f2a5f97381585
          Log:
          JENKINS-15369 NPE from Jenkins.removeNode continued.
          /computer/*/doDelete should try harder to remove even a “zombie” Computer with no associated Node.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/Computer.java http://jenkins-ci.org/commit/jenkins/87d9a6e413c11eda69f7c2966c3f2a5f97381585 Log: JENKINS-15369 NPE from Jenkins.removeNode continued. /computer/*/doDelete should try harder to remove even a “zombie” Computer with no associated Node.
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #1997
          JENKINS-15369 NPE from Jenkins.removeNode continued. (Revision 87d9a6e413c11eda69f7c2966c3f2a5f97381585)

          Result = SUCCESS
          Jesse Glick : 87d9a6e413c11eda69f7c2966c3f2a5f97381585
          Files :

          • core/src/main/java/hudson/model/Computer.java
          • changelog.html
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1997 JENKINS-15369 NPE from Jenkins.removeNode continued. (Revision 87d9a6e413c11eda69f7c2966c3f2a5f97381585) Result = SUCCESS Jesse Glick : 87d9a6e413c11eda69f7c2966c3f2a5f97381585 Files : core/src/main/java/hudson/model/Computer.java changelog.html

            People

            Assignee:
            jglick Jesse Glick
            Reporter:
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: