Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15426

Run animal-sniffer:check as part of build

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Critical
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Similar Issues:

      Description

      Currently animal-sniffer:check is theoretically run during the release process, though in fact it fails when you try it, pending http://jira.codehaus.org/browse/MANIMALSNIFFER-29 being released.

      Need to use the 1.9 plugin when available, and make this goal be run as part of dev builds by default, perhaps skipping just when -DskipTests was passed.

      See also @kohsuke’s e2bfcb3 & 7ef347b.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/PluginSubtypeMarker.java
          pom.xml
          http://jenkins-ci.org/commit/jenkins/e582616791778891ee07acc3057303204bda82ee
          Log:
          JENKINS-15426 Animal Sniffer upgraded to 1.8, and noting what is needed from 1.9.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/PluginSubtypeMarker.java pom.xml http://jenkins-ci.org/commit/jenkins/e582616791778891ee07acc3057303204bda82ee Log: JENKINS-15426 Animal Sniffer upgraded to 1.8, and noting what is needed from 1.9.
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #1982

          Result = SUCCESS

          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #1982 Result = SUCCESS
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          core/src/main/java/jenkins/PluginSubtypeMarker.java
          plugins/pom.xml
          pom.xml
          test/src/main/java/org/jvnet/hudson/test/ThreadPoolImpl.java
          http://jenkins-ci.org/commit/jenkins/918cf8dfcae97204bc173ce8f92f4eeaa89ef247
          Log:
          [FIXED JENKINS-15426] Run animal-sniffer:check by default (-DskipTests suppresses).

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/jenkins/PluginSubtypeMarker.java plugins/pom.xml pom.xml test/src/main/java/org/jvnet/hudson/test/ThreadPoolImpl.java http://jenkins-ci.org/commit/jenkins/918cf8dfcae97204bc173ce8f92f4eeaa89ef247 Log: [FIXED JENKINS-15426] Run animal-sniffer:check by default (-DskipTests suppresses).
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2012
          [FIXED JENKINS-15426] Run animal-sniffer:check by default (-DskipTests suppresses). (Revision 918cf8dfcae97204bc173ce8f92f4eeaa89ef247)

          Result = SUCCESS
          Jesse Glick : 918cf8dfcae97204bc173ce8f92f4eeaa89ef247
          Files :

          • test/src/main/java/org/jvnet/hudson/test/ThreadPoolImpl.java
          • core/src/main/java/jenkins/PluginSubtypeMarker.java
          • plugins/pom.xml
          • pom.xml
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2012 [FIXED JENKINS-15426] Run animal-sniffer:check by default (-DskipTests suppresses). (Revision 918cf8dfcae97204bc173ce8f92f4eeaa89ef247) Result = SUCCESS Jesse Glick : 918cf8dfcae97204bc173ce8f92f4eeaa89ef247 Files : test/src/main/java/org/jvnet/hudson/test/ThreadPoolImpl.java core/src/main/java/jenkins/PluginSubtypeMarker.java plugins/pom.xml pom.xml
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          test/src/main/java/org/jvnet/hudson/test/ThreadPoolImpl.java
          http://jenkins-ci.org/commit/jenkins-test-harness/a184a039543629132bdd000d7b73b565f8afb82e
          Log:
          [FIXED JENKINS-15426] Run animal-sniffer:check by default (-DskipTests suppresses).
          Originally-Committed-As: 918cf8dfcae97204bc173ce8f92f4eeaa89ef247

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/main/java/org/jvnet/hudson/test/ThreadPoolImpl.java http://jenkins-ci.org/commit/jenkins-test-harness/a184a039543629132bdd000d7b73b565f8afb82e Log: [FIXED JENKINS-15426] Run animal-sniffer:check by default (-DskipTests suppresses). Originally-Committed-As: 918cf8dfcae97204bc173ce8f92f4eeaa89ef247

            People

            Assignee:
            jglick Jesse Glick
            Reporter:
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: