Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-1544

"Failed Tests" does not de-escape testcase names

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • junit-plugin
    • None
    • Platform: All, OS: All

      The "Failed Tests" view does not de-escape testcase names, e.g. it displays
      '"' instead of '"'. In the "All Tests" view, things are handled properly.

          [JENKINS-1544] "Failed Tests" does not de-escape testcase names

          fkonvick added a comment -

          Any progress?
          When I open a specific testcase, the name is mis-escaped too (ie. on the
          testcase detail page).

          The "All Tests" listing is escaped properly though.

          Is there anything I can do to get this fixed?

          fkonvick added a comment - Any progress? When I open a specific testcase, the name is mis-escaped too (ie. on the testcase detail page). The "All Tests" listing is escaped properly though. Is there anything I can do to get this fixed?

          Alan Harder added a comment -

          Things have likely changed quite a bit since this was filed.. I manually made some junit XML with a quotation in the class name and test name. I didn't see any display or link problems when I browsed around. I did get a javascript error clicking the ">>>" to show the failure details. I'll fix that and close out this old issue.. feel free to reopen or file a new issue if you see any problems on 1.347 or newer, thanks.

          Alan Harder added a comment - Things have likely changed quite a bit since this was filed.. I manually made some junit XML with a quotation in the class name and test name. I didn't see any display or link problems when I browsed around. I did get a javascript error clicking the ">>>" to show the failure details. I'll fix that and close out this old issue.. feel free to reopen or file a new issue if you see any problems on 1.347 or newer, thanks.

          Code changed in hudson
          User: : mindless
          Path:
          trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/CaseResult/summary.jelly
          trunk/hudson/main/core/src/main/resources/hudson/tasks/test/MetaTabulatedResult/body.jelly
          trunk/www/changelog.html
          http://jenkins-ci.org/commit/27444
          Log:
          [FIXED JENKINS-1544] add jsStringEscape in case test name has quote or backslash.
          also set text/plain content type on ajax summary response so browser doesn't try
          to parse response (firefox 3.6 showed error in console with text/html).

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : mindless Path: trunk/hudson/main/core/src/main/resources/hudson/tasks/junit/CaseResult/summary.jelly trunk/hudson/main/core/src/main/resources/hudson/tasks/test/MetaTabulatedResult/body.jelly trunk/www/changelog.html http://jenkins-ci.org/commit/27444 Log: [FIXED JENKINS-1544] add jsStringEscape in case test name has quote or backslash. also set text/plain content type on ajax summary response so browser doesn't try to parse response (firefox 3.6 showed error in console with text/html).

            mindless Alan Harder
            fkonvick fkonvick
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: