Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15540

Update logging levels in LogRotator - hudson.tasks.LogRotator perform

    XMLWordPrintable

Details

    • Patch
    • Status: Resolved (View Workflow)
    • Trivial
    • Resolution: Fixed
    • core
    • None

    Description

      I noticed a couple of things when looking at the code for perform() in hudson.tasks.LogRotator, related to the way actions are logged.

      1. Removals are logged at the same level (FINER) as notices about builds not to be removed (FINER),
      2. Artifact removals are not logged at all.

      I was planning to change this:

      1. Log all removals as FINE instead of FINER.
      2. Log artifact removes as FINE.

      Attachments

        Activity

          wcjk Wade C added a comment -
          • Currently setting up dev environment, going to create pull request.
          • Opened this issue for tracking purposes.
          wcjk Wade C added a comment - Currently setting up dev environment, going to create pull request. Opened this issue for tracking purposes.
          wcjk Wade C added a comment - https://github.com/jenkinsci/jenkins/pull/592

          Code changed in jenkins
          User: Wade Carpenter
          Path:
          core/src/main/java/hudson/tasks/LogRotator.java
          http://jenkins-ci.org/commit/jenkins/3ae859402002320394829bcdbddf6408a45d0610
          Log:
          [FIXED JENKINS-15540] Update logging levels in LogRotator

          1. Log all removals as FINE instead of FINER.
          2. Log artifact removes as FINE.

          Affects:
          hudson.tasks.LogRotator perform()

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Wade Carpenter Path: core/src/main/java/hudson/tasks/LogRotator.java http://jenkins-ci.org/commit/jenkins/3ae859402002320394829bcdbddf6408a45d0610 Log: [FIXED JENKINS-15540] Update logging levels in LogRotator 1. Log all removals as FINE instead of FINER. 2. Log artifact removes as FINE. Affects: hudson.tasks.LogRotator perform()

          Code changed in jenkins
          User: Olivier Lamy
          Path:
          core/src/main/java/hudson/tasks/LogRotator.java
          http://jenkins-ci.org/commit/jenkins/88503bce4971814455481df1bba13f5d9d987b4e
          Log:
          Merge pull request #592 from wwade/master

          [FIXED JENKINS-15540] Update logging levels in LogRotator

          Compare: https://github.com/jenkinsci/jenkins/compare/fcbc0c683e1b...88503bce4971

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: core/src/main/java/hudson/tasks/LogRotator.java http://jenkins-ci.org/commit/jenkins/88503bce4971814455481df1bba13f5d9d987b4e Log: Merge pull request #592 from wwade/master [FIXED JENKINS-15540] Update logging levels in LogRotator Compare: https://github.com/jenkinsci/jenkins/compare/fcbc0c683e1b...88503bce4971

          Code changed in jenkins
          User: Olivier Lamy
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/ff3cf5e1047fff9f0106a1372b9a460b6f08ecd9
          Log:
          JENKINS-15540 add changelog entry

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Olivier Lamy Path: changelog.html http://jenkins-ci.org/commit/jenkins/ff3cf5e1047fff9f0106a1372b9a460b6f08ecd9 Log: JENKINS-15540 add changelog entry
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #2042
          [FIXED JENKINS-15540] Update logging levels in LogRotator (Revision 3ae859402002320394829bcdbddf6408a45d0610)
          JENKINS-15540 add changelog entry (Revision ff3cf5e1047fff9f0106a1372b9a460b6f08ecd9)

          Result = SUCCESS
          wcarpenter : 3ae859402002320394829bcdbddf6408a45d0610
          Files :

          • core/src/main/java/hudson/tasks/LogRotator.java

          Olivier Lamy : ff3cf5e1047fff9f0106a1372b9a460b6f08ecd9
          Files :

          • changelog.html
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2042 [FIXED JENKINS-15540] Update logging levels in LogRotator (Revision 3ae859402002320394829bcdbddf6408a45d0610) JENKINS-15540 add changelog entry (Revision ff3cf5e1047fff9f0106a1372b9a460b6f08ecd9) Result = SUCCESS wcarpenter : 3ae859402002320394829bcdbddf6408a45d0610 Files : core/src/main/java/hudson/tasks/LogRotator.java Olivier Lamy : ff3cf5e1047fff9f0106a1372b9a460b6f08ecd9 Files : changelog.html

          People

            wcjk Wade C
            wcjk Wade C
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: