[JENKINS-15617] <st:bind> does not work inside <l:ajax> - Jenkins Jira

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: core
Labels:
- javascript
Environment:
1.424

Similar Issues:

Show

Description

The contents of the bind expression, and any further contents of your <script>, are dumped outside of any script block and appear as plain text in the web page.

Adding <st:adjunct includes="org.kohsuke.stapler.bind"/> first solves that problem, but now your <script> block is not run at all.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

JENKINS-15617.zip
7 kB
2012-10-25 00:05

Issue Links

depends on

JENKINS-16561 Jelly form control f:validateButton giving a warning popup in IE irrespective of whether validation is successfull

Resolved

Activity

Ascending order - Click to sort in descending order

View 9 older comments

Jesse Glick added a comment - 2012-10-27 00:13

51f508b breaks config page loading in IE 8 on XP.

Jesse Glick added a comment - 2012-10-27 00:13 51f508b breaks config page loading in IE 8 on XP.

Jesse Glick added a comment - 2012-10-27 00:18

diff --git a/war/src/main/webapp/scripts/hudson-behavior.js b/war/src/main/webapp/scripts/hudson-behavior.js
index c88fc9f..4eb41b7 100644
--- a/war/src/main/webapp/scripts/hudson-behavior.js
+++ b/war/src/main/webapp/scripts/hudson-behavior.js
@@ -500,7 +500,7 @@ function isInsideRemovable(e) {
  */
 function renderOnDemand(e,callback,noBehaviour) {
     if (!e || !Element.hasClassName(e,"render-on-demand")) return;
-    var proxy = geval(e.getAttribute("proxy"));
+    var proxy = eval(e.getAttribute("proxy"));
     proxy.render(function (t) {
         var contextTagName = e.parentNode.tagName;
         var c;

seems to fix it. Why is geval being used so widely?

Jesse Glick added a comment - 2012-10-27 00:18 diff --git a/war/src/main/webapp/scripts/hudson-behavior.js b/war/src/main/webapp/scripts/hudson-behavior.js index c88fc9f..4eb41b7 100644 --- a/war/src/main/webapp/scripts/hudson-behavior.js +++ b/war/src/main/webapp/scripts/hudson-behavior.js @@ -500,7 +500,7 @@ function isInsideRemovable(e) { */ function renderOnDemand(e,callback,noBehaviour) { if (!e || !Element.hasClassName(e, "render-on-demand" )) return ; - var proxy = geval(e.getAttribute( "proxy" )); + var proxy = eval(e.getAttribute( "proxy" )); proxy.render(function (t) { var contextTagName = e.parentNode.tagName; var c; seems to fix it. Why is geval being used so widely?

Kohsuke Kawaguchi added a comment - 2012-10-27 02:13

The idea behind geval is not to let evaluated script to access local in-scope variables as well as letting them put stuff into global scope, so I think it's sound to prefer geval as much as possible.

Now, it turns out execScript always return null which means it can't be used at all where we need the return value.

The next step is, who said eval on IE is broken? On my IE8 in the standards mode, "window.eval" seems to work as expected. MSDN backs me up and claims it has been there since IE6.

Kohsuke Kawaguchi added a comment - 2012-10-27 02:13 The idea behind geval is not to let evaluated script to access local in-scope variables as well as letting them put stuff into global scope, so I think it's sound to prefer geval as much as possible. Now, it turns out execScript always return null which means it can't be used at all where we need the return value. The next step is, who said eval on IE is broken? On my IE8 in the standards mode, "window.eval" seems to work as expected. MSDN backs me up and claims it has been there since IE6.

SCM/JIRA link daemon added a comment - 2012-10-27 02:21

Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
war/src/main/webapp/scripts/hudson-behavior.js
http://jenkins-ci.org/commit/jenkins/1c578ab5542bd20904c4a5e4ebcc80b42af31bbb
Log:
[FIXED JENKINS-15617]

execScript cannot return value [1], so I'm restricting its use to where
we don't care about the return value. See ticket for more discussions

[1] http://msdn.microsoft.com/en-us/library/ie/ms536420(v=vs.85).aspx

SCM/JIRA link daemon added a comment - 2012-10-27 02:21 Code changed in jenkins User: Kohsuke Kawaguchi Path: war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/1c578ab5542bd20904c4a5e4ebcc80b42af31bbb Log: [FIXED JENKINS-15617] execScript cannot return value [1] , so I'm restricting its use to where we don't care about the return value. See ticket for more discussions [1] http://msdn.microsoft.com/en-us/library/ie/ms536420(v=vs.85).aspx

dogfood added a comment - 2012-10-27 03:18

Integrated in jenkins_main_trunk #2037
[FIXED JENKINS-15617] (Revision 1c578ab5542bd20904c4a5e4ebcc80b42af31bbb)

Result = UNSTABLE
kohsuke : 1c578ab5542bd20904c4a5e4ebcc80b42af31bbb
Files :

war/src/main/webapp/scripts/hudson-behavior.js

dogfood added a comment - 2012-10-27 03:18 Integrated in jenkins_main_trunk #2037 [FIXED JENKINS-15617] (Revision 1c578ab5542bd20904c4a5e4ebcc80b42af31bbb) Result = UNSTABLE kohsuke : 1c578ab5542bd20904c4a5e4ebcc80b42af31bbb Files : war/src/main/webapp/scripts/hudson-behavior.js

Jenkins

<st:bind> does not work inside <l:ajax>

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates