Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-15823

Make GerritCause a Subclass of SCMTriggerCause

      If GerritCause was a Subclass of SCMTriggerCause (which is not that far fetched, since a GerritTrigger is in fact an SCMChange), we could make it easier for plugins that react on Code-Changes.

      In my special case, I am currently working on some improvements in Jenkins' incremental module handling which should behave differently when the a build is ONLY caused by sourcecode changes.

      Making that change would quite neatly solve a couple of problems without creating unnatural dependencies.

      I will create a pull request for this.

          [JENKINS-15823] Make GerritCause a Subclass of SCMTriggerCause

          Stephan Pauxberger added a comment - created https://github.com/jenkinsci/gerrit-trigger-plugin/pull/34

          Code changed in jenkins
          User: Stephan Pauxberger
          Path:
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritCause.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/9219b738aef82d67e4d1f6c309ff61487f5667ee
          Log:
          JENKINS-15823 Make GerritCause a Subclass of SCMTriggerCause

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephan Pauxberger Path: gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritCause.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/9219b738aef82d67e4d1f6c309ff61487f5667ee Log: JENKINS-15823 Make GerritCause a Subclass of SCMTriggerCause

          Code changed in jenkins
          User: Robert Sandell
          Path:
          gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritCause.java
          http://jenkins-ci.org/commit/gerrit-trigger-plugin/ee832ba4018f96cc6eaef2044d6f0222d6c778a1
          Log:
          Merge pull request #34 from pauxus/gerrit-change-is-scm-change

          JENKINS-15823 Make GerritCause a Subclass of SCMTriggerCause

          Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/dd8c8131208b...ee832ba4018f

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Robert Sandell Path: gerrithudsontrigger/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/hudsontrigger/GerritCause.java http://jenkins-ci.org/commit/gerrit-trigger-plugin/ee832ba4018f96cc6eaef2044d6f0222d6c778a1 Log: Merge pull request #34 from pauxus/gerrit-change-is-scm-change JENKINS-15823 Make GerritCause a Subclass of SCMTriggerCause Compare: https://github.com/jenkinsci/gerrit-trigger-plugin/compare/dd8c8131208b...ee832ba4018f

          rin_ne added a comment -

          Seems already merged

          rin_ne added a comment - Seems already merged

            rsandell rsandell
            paux Stephan Pauxberger
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: