DiskSpaceMonitor.install and TemporarySpaceMonitor.install are returning null on Java 5, but apparently this is not preventing NodeMonitor.all() from listing them.

Cannot consistently reproduce.

Also when building from sources rather than using a released WAR I get bogus errors such as

Nov 19, 2012 1:47:33 PM hudson.ExtensionFinder$Sezpoz scout
WARNING: Failed to scout hudson.scm.MailAddressResolverImpl
java.lang.InstantiationException: file:…/plugins/cvs/WEB-INF/classes/META-INF/annotations/hudson.Extension might need to be rebuilt: java.lang.ClassNotFoundException: hudson.scm.MailAddressResolverImpl
	at net.java.sezpoz.IndexItem.element(IndexItem.java:144)
	at hudson.ExtensionFinder$Sezpoz.scout(ExtensionFinder.java:646)
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:290)
	at hudson.ExtensionList.load(ExtensionList.java:295)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:248)
	at hudson.ExtensionList.iterator(ExtensionList.java:138)
	at hudson.ClassicPluginStrategy.findComponents(ClassicPluginStrategy.java:289)
	at hudson.ExtensionList.load(ExtensionList.java:295)
	at hudson.ExtensionList.ensureLoaded(ExtensionList.java:248)
	at hudson.ExtensionList.size(ExtensionList.java:157)
	at java.util.AbstractCollection.isEmpty(AbstractCollection.java:78)
	at hudson.model.queue.QueueSorter.installDefaultQueueSorter(QueueSorter.java:47)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:592)
	at hudson.init.InitializerFinder.invoke(InitializerFinder.java:120)
	at hudson.init.InitializerFinder$TaskImpl.run(InitializerFinder.java:184)
	at org.jvnet.hudson.reactor.Reactor.runTask(Reactor.java:259)
	at jenkins.model.Jenkins$7.runTask(Jenkins.java:875)
	at org.jvnet.hudson.reactor.Reactor$2.run(Reactor.java:187)
	at org.jvnet.hudson.reactor.Reactor$Node.run(Reactor.java:94)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:651)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:676)
	at java.lang.Thread.run(Thread.java:595)
Caused by: java.lang.ClassNotFoundException: hudson.scm.MailAddressResolverImpl
	at hudson.PluginManager$UberClassLoader.findClass(PluginManager.java:783)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:307)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:252)
	at net.java.sezpoz.IndexItem.element(IndexItem.java:134)
	... 24 more

which may or may not be related.

Causes http://localhost:8080/computer/ to crash with a 500 error.

Code changed in jenkins
User: Jesse Glick
Path:
changelog.html
core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java
core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java
core/src/main/resources/hudson/node_monitors/Messages.properties
http://jenkins-ci.org/commit/jenkins/8ad62f77cb429a49318444fad2191d0e08857ca6
Log:
[FIXED JENKINS-15869] When running on Java 5, must still load DiskSpaceMonitor/TemporarySpaceMonitor, even though they will show N/A.
Returning null from an @Extension method does not seem to work reliably, and is not supported by SezPoz.
If desirable to hide a monitor column in $server/computer/, add a boolean isEnabled() method interpretable in Jelly.

Still not consistently reproducible, but may be necessary to run using Java 6+ before running on Java 5, presumably to populate $JENKINS_HOME/nodeMonitors.xml.

Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
changelog.html
core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java
core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java
core/src/main/resources/hudson/node_monitors/Messages.properties
http://jenkins-ci.org/commit/jenkins/6465ba0f8386fcdef22d2f523357f3024dafd57b
Log:
JENKINS-15869 reverting the change.

"When running on Java 5, must still load DiskSpaceMonitor/TemporarySpaceMonitor, even though they will show N/A."

This reverts commit 8ad62f77cb429a49318444fad2191d0e08857ca6.

Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
core/src/main/java/hudson/model/ComputerSet.java
http://jenkins-ci.org/commit/jenkins/5eada311c640663a2dbe40c69a7257e80be9ffca
Log:
[FIXED JENKINS-15869]

revisiting the fix by vetting the deserialized NodeMonitors to make sure they are valid.

Compare: https://github.com/jenkinsci/jenkins/compare/8ad62f77cb42...5eada311c640

Integrated in jenkins_main_trunk #2086
[FIXED JENKINS-15869] When running on Java 5, must still load DiskSpaceMonitor/TemporarySpaceMonitor, even though they will show N/A. (Revision 8ad62f77cb429a49318444fad2191d0e08857ca6)
JENKINS-15869 reverting the change. (Revision 6465ba0f8386fcdef22d2f523357f3024dafd57b)
[FIXED JENKINS-15869] (Revision 5eada311c640663a2dbe40c69a7257e80be9ffca)

Result = SUCCESS
Jesse Glick : 8ad62f77cb429a49318444fad2191d0e08857ca6
Files :

• changelog.html
• core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java
• core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java
• core/src/main/resources/hudson/node_monitors/Messages.properties

kohsuke : 6465ba0f8386fcdef22d2f523357f3024dafd57b
Files :

• changelog.html
• core/src/main/java/hudson/node_monitors/DiskSpaceMonitor.java
• core/src/main/resources/hudson/node_monitors/Messages.properties
• core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java

kohsuke : 5eada311c640663a2dbe40c69a7257e80be9ffca
Files :

• core/src/main/java/hudson/model/ComputerSet.java