Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16244

View.hasPeople too slow to use in sidepanel.jelly

    XMLWordPrintable

Details

    Description

      On large Jenkins installations, rendering view pages can be extremely slow. Thread dumps point to the use of View.hasPeople, which is an arbitrarily expensive call that must not be made from HTTP service.

      Attachments

        Issue Links

          Activity

            jglick Jesse Glick added a comment -

            Fixing by just unconditionally linking to asynchPeople.

            Unclear if hyperlink construction in this sidepanel is correct in all cases; https://github.com/jenkinsci/jenkins/commit/5c7184d3cdccde44eaf8d73a38151a1c6ee5f9a9 has discussion.

            jglick Jesse Glick added a comment - Fixing by just unconditionally linking to asynchPeople . Unclear if hyperlink construction in this sidepanel is correct in all cases; https://github.com/jenkinsci/jenkins/commit/5c7184d3cdccde44eaf8d73a38151a1c6ee5f9a9 has discussion.

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/View.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/resources/hudson/model/View/sidepanel.jelly
            http://jenkins-ci.org/commit/jenkins/73aac1073983e1f667d801387571d31857253ffc
            Log:
            [FIXED JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly.

            Compare: https://github.com/jenkinsci/jenkins/compare/5eede6e5d58d...73aac1073983

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/View.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/View/sidepanel.jelly http://jenkins-ci.org/commit/jenkins/73aac1073983e1f667d801387571d31857253ffc Log: [FIXED JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly. Compare: https://github.com/jenkinsci/jenkins/compare/5eede6e5d58d...73aac1073983
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2169

            Result = SUCCESS

            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2169 Result = SUCCESS

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/model/View.java
            core/src/main/java/jenkins/model/Jenkins.java
            core/src/main/resources/hudson/model/View/sidepanel.jelly
            http://jenkins-ci.org/commit/jenkins/4998a373c831665814233b2b330392299bdc101b
            Log:
            [FIXED JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly.(cherry picked from commit 73aac1073983e1f667d801387571d31857253ffc)

            Conflicts:
            changelog.html

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/model/View.java core/src/main/java/jenkins/model/Jenkins.java core/src/main/resources/hudson/model/View/sidepanel.jelly http://jenkins-ci.org/commit/jenkins/4998a373c831665814233b2b330392299bdc101b Log: [FIXED JENKINS-16244] View.hasPeople too slow to use in sidepanel.jelly.(cherry picked from commit 73aac1073983e1f667d801387571d31857253ffc) Conflicts: changelog.html
            eguess74 eguess74 added a comment - - edited

            We are running 1.504 and we still have problem with very long load of the main page view at times. If I specify the URL for particular job - it works fine. It also works fine for few days after restart, but then suddenly gets stuck. But the at some point releases and works fast again.
            We have about 800+ jobs and about 100 users

            eguess74 eguess74 added a comment - - edited We are running 1.504 and we still have problem with very long load of the main page view at times. If I specify the URL for particular job - it works fine. It also works fine for few days after restart, but then suddenly gets stuck. But the at some point releases and works fast again. We have about 800+ jobs and about 100 users
            jglick Jesse Glick added a comment -

            @eguess74 the bug reported here has been fixed. Whatever problem you are encountering is probably unrelated. File it separately and include a thread dump, without which it is impossible to guess at what is going on in your instance.

            jglick Jesse Glick added a comment - @eguess74 the bug reported here has been fixed. Whatever problem you are encountering is probably unrelated. File it separately and include a thread dump, without which it is impossible to guess at what is going on in your instance.

            People

              jglick Jesse Glick
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: