Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16368

Hardcoded protocol in some links

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Some links (e.g. in console output lnks "Building remotely on slaveXYZ") don't preserve protocol and have hardcoded HTTP even if the page is opened via HTTPS. This can be considered as a security risk (e.g. user doesn't notice change of the protocol and later on can open another console output with sensitive data and the data would be sent over unsecure HTTP in this case)

        Attachments

          Issue Links

            Activity

            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2316
            JENKINS-16368 "mvn hudson-dev:run" to run with context path (Revision ded37a2b626419fcef6e9ae425331c275d827b48)

            Result = UNSTABLE
            kohsuke : ded37a2b626419fcef6e9ae425331c275d827b48
            Files :

            • war/pom.xml
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2316 JENKINS-16368 "mvn hudson-dev:run" to run with context path (Revision ded37a2b626419fcef6e9ae425331c275d827b48) Result = UNSTABLE kohsuke : ded37a2b626419fcef6e9ae425331c275d827b48 Files : war/pom.xml
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2317
            JENKINS-16368 "mvn hpi:run" to use non-empty context path. (Revision 17d2df75ffdcf49d6026f67e250747481cf39c28)

            Result = SUCCESS
            kohsuke : 17d2df75ffdcf49d6026f67e250747481cf39c28
            Files :

            • plugins/pom.xml
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2317 JENKINS-16368 "mvn hpi:run" to use non-empty context path. (Revision 17d2df75ffdcf49d6026f67e250747481cf39c28) Result = SUCCESS kohsuke : 17d2df75ffdcf49d6026f67e250747481cf39c28 Files : plugins/pom.xml
            Hide
            jglick Jesse Glick added a comment -

            AFAICT #682 does create app-relative URLs, or purports to.

            Show
            jglick Jesse Glick added a comment - AFAICT #682 does create app-relative URLs, or purports to.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Kohsuke Kawaguchi
            Path:
            changelog.html
            core/src/main/java/hudson/Functions.java
            core/src/main/java/hudson/console/HyperlinkNote.java
            core/src/main/java/jenkins/model/Jenkins.java
            http://jenkins-ci.org/commit/jenkins/9447289c87522d96d54228e817c5aa3cd04744c6
            Log:
            [FIXED JENKINS-16368]

            HyperlinkNote shouldn't emit the absolute URL.

            Compare: https://github.com/jenkinsci/jenkins/compare/902edc38aa26...9447289c8752


            You received this message because you are subscribed to the Google Groups "Jenkins Commits" group.
            To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com.
            For more options, visit https://groups.google.com/groups/opt_out.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/Functions.java core/src/main/java/hudson/console/HyperlinkNote.java core/src/main/java/jenkins/model/Jenkins.java http://jenkins-ci.org/commit/jenkins/9447289c87522d96d54228e817c5aa3cd04744c6 Log: [FIXED JENKINS-16368] HyperlinkNote shouldn't emit the absolute URL. Compare: https://github.com/jenkinsci/jenkins/compare/902edc38aa26...9447289c8752 – You received this message because you are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out .
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #2320
            [FIXED JENKINS-16368] (Revision 9447289c87522d96d54228e817c5aa3cd04744c6)

            Result = SUCCESS
            kohsuke : 9447289c87522d96d54228e817c5aa3cd04744c6
            Files :

            • core/src/main/java/hudson/console/HyperlinkNote.java
            • changelog.html
            • core/src/main/java/hudson/Functions.java
            • core/src/main/java/jenkins/model/Jenkins.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #2320 [FIXED JENKINS-16368] (Revision 9447289c87522d96d54228e817c5aa3cd04744c6) Result = SUCCESS kohsuke : 9447289c87522d96d54228e817c5aa3cd04744c6 Files : core/src/main/java/hudson/console/HyperlinkNote.java changelog.html core/src/main/java/hudson/Functions.java core/src/main/java/jenkins/model/Jenkins.java

              People

              Assignee:
              kohsuke Kohsuke Kawaguchi
              Reporter:
              vjuranek vjuranek
              Votes:
              5 Vote for this issue
              Watchers:
              13 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: